From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD7D3D170D for ; Wed, 22 Apr 2026 11:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856938; cv=none; b=tyZzHkIS8jADLaGrY7LopUEteO+K5vyF+9BMHdu+fmHopRzFNWh2CBaaLZTiqkpDerJECz10RsWITIvZ639CdOpWWemKma6uFHmD28cFDE3L9w079DXrDO5xRCE52ZdA4s6IAZibPgsM6J8Xw7t+g/c7qVVri5PoIImy4B+K0So= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856938; c=relaxed/simple; bh=ELeduL2AOJ0a21jL4mB8Ddr8Zke1vXbWgcFBi/970lY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bCq1NXY5O3YfMPNtj7Ers03p/MHegAS3RY1z0xEAsrgzDVl801rd8VW11hjSMZFPkBReXO2sk3Ws1JpZ9FAc/F9z3zlqOREgDWC7n8gqD4OllZ2Cq+L5xGvGo13NGUWbcLBndxebZo9jcOj1c3Af/EB/m925l+FTYNNyYeowdT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yeq3eDKx; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yeq3eDKx" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b9c3a9fe80fso746516966b.3 for ; Wed, 22 Apr 2026 04:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776856935; x=1777461735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6H6WelrBg+h3VHziDGIho/XkEcoBV7nOVLijFF+4rdI=; b=Yeq3eDKxjzb6MgTwKH5fYng6BNsIblm+4pDWwUmLyL/WNBe6gW88D1VpjWz/TyP6Bt 1MZBK9iQ/KGgtNs2Rgs3ZADGWhZ2w6qvTtONz7m3W8DUGzwR2A1q6ifcQbNeQTIfL5xZ CSx7beRKLv/AF/Z4lxEfQdkrA41NHyXr2PeCR3TfuvgCyPZyB1oi0hBphW7U8yAm9PhM z5ByYFO62Gl2LmYKg81wLlxyMCZmaRDZn7fhGcKbXdP/C1hVNXWLR7K+S378l6/P0EoW 8Z40DPYDpbwdvkveA/uRAhoEVsqP0oJsq6GFtTbm7CaOCeQIV9O+C5X77afJGE3pzrIt eAPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856935; x=1777461735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6H6WelrBg+h3VHziDGIho/XkEcoBV7nOVLijFF+4rdI=; b=bh50GjPxD6LnnfJ9Vn93XlN31L4tMEk9FALAWRJNxflhVYGF2rlrCdsMldqTh2KgZ4 io8wOIaHUJdFdJByVkWadmrGEL65uW9ZeuoYIKMkyjjxyKqhKl7G4MdC2Vskp11Cyn93 napTBmFCMxVkM8tIqzv6G2McykXtREfPudrenQclqHri6UZw7ZquRrS64GJvQle6Kz27 PSw/E6/vr1+6/ZIr9wtOsufuHlASFFGmcDe4xO/K3CNFxHLwii4b7TxzJEgxulEgj5CX te6ZlHoEZnuRewBFh9gwORm+5wOFZDrcOqYWgFP8YQu9XjYUNk6NgCxO13RBDcw6a5N0 I/mw== X-Forwarded-Encrypted: i=1; AFNElJ86FBMrbtQgDXt9g/Di5fxt4FlyM4m+o/rx+SAIMaesJEvqgrS/bPEuiQrk4QXFx1tJktN0btkaU2HCZC4=@vger.kernel.org X-Gm-Message-State: AOJu0YzdeNGHx/GWjZPIvW8fg/ayb/edpn2Cfo2ueFmOiGzePMz1Q05f JqjdnhR3Jl/JY3QF9osotPl65ETjzyjUpiGgfKvHuewBTYXNHjUZ8XNg X-Gm-Gg: AeBDiesvb8030IqeQNCkRQfbPkXPBqF4NeDUeNZ9LfM5Y/7k7g5ibJJIUkPJCJoLY+z JpGpm/umfZ1QfliFtOpHZauLnjxFL0SsQUQ0zyK+fl3ytxrmb40q274GLEsAI1EmqnyI9TVThDv Q9qPtUZwAxrFENV6TrNnxcD2k2/E35znLhshhHEstaelB6yj/wFjxBVx+jwEanyTKEQe6BgdHHU 8VeYeiVvDpU2NYC/4Rm3xA1vBStYQVVn8hSOkSJMtIE96AGTnwLTZCz+3UZHmKOJftsKWNxRW3x 54oI0lYY3R9aATKxBOGxoGNDRTgqvJiomacypPrkOnPC6vIB7W0Su8aTbHhg5c5ZjPVun50o56x ooGuKRf6B9Cww43YSQXHHhFzWDxaKeJ8GADqMtIA+i8LtgpqpT2tx1jnfeJyMS/91QZRGOaTVpO OIcPrHgENIvxsJEJPYH8k1tGRjH3p4xCKHM/ZccovLtPmnUJsCE4OADDJudl6CY7kMiuDYy4iLN DLZkJC7bpQF6Ej/YA4IspStG+K1Frvuvd0sRwQuxcIMidDzqTvYlSu6FkPx01z+8pEOUQ2TY0NG 7NUpk7CQWmEoVVjroFrwHGLnxrUncuZarjTxxJDVT1CTPTDl7sx4xL2WM9imglA2oFtMj2EE2rb SAL3TSwLTLRVEw/VbL6+Ys7xRNmM9c/XCslU/KTIX7AKF6lPCnLcFPqVRZf6DRQUrptTHtruTXG 7z8bLBjWQ= X-Received: by 2002:a17:907:3f8d:b0:ba7:3d21:c137 with SMTP id a640c23a62f3a-ba73d31091dmr660607866b.17.1776856934999; Wed, 22 Apr 2026 04:22:14 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.od237066db22328bb-tp.internal (25.236.141.34.bc.googleusercontent.com. [34.141.236.25]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba6366452c6sm395156866b.11.2026.04.22.04.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:22:14 -0700 (PDT) From: Joshua Crofts To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 6/6] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Date: Wed, 22 Apr 2026 11:22:07 +0000 Message-ID: <20260422112207.1313-7-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260422112207.1313-1-joshua.crofts1@gmail.com> References: <20260422112207.1313-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver currently uses while loops and msleep() for polling during conversion waits. Replace the custom polling loops with readx_poll_timeout() and read_poll_timeout() macros from . This reduces boilerplate, standardizes timeout handling and improves overall code readability, keeping the original timing and error behaviour. Add for USEC_PER_MSEC macro instead of using magic numbers. Assisted-by: Gemini:3.1-Pro Signed-off-by: Joshua Crofts --- drivers/iio/magnetometer/ak8975.c | 47 ++++++++++++++----------------- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c index 723c2f64b8e..0724569e766 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -23,6 +24,7 @@ #include #include #include +#include #include #include @@ -652,18 +654,16 @@ static int ak8975_setup(struct i2c_client *client) static int wait_conversion_complete_gpio(struct ak8975_data *data) { struct i2c_client *client = data->client; - u32 timeout_ms = AK8975_MAX_CONVERSION_TIMEOUT; int ret; + int val; /* Wait for the conversion to complete. */ - while (timeout_ms) { - msleep(AK8975_CONVERSION_DONE_POLL_TIME); - if (gpiod_get_value(data->eoc_gpiod)) - break; - timeout_ms -= AK8975_CONVERSION_DONE_POLL_TIME; - } - if (!timeout_ms) - return -ETIMEDOUT; + ret = readx_poll_timeout(gpiod_get_value, data->eoc_gpiod, val, + val != 0, + AK8975_CONVERSION_DONE_POLL_TIME * USEC_PER_MSEC, + AK8975_MAX_CONVERSION_TIMEOUT * USEC_PER_MSEC); + if (ret) + return ret; ret = i2c_smbus_read_byte_data(client, data->def->ctrl_regs[ST1]); if (ret < 0) @@ -675,28 +675,23 @@ static int wait_conversion_complete_gpio(struct ak8975_data *data) static int wait_conversion_complete_polled(struct ak8975_data *data) { struct i2c_client *client = data->client; - u8 read_status; - u32 timeout_ms = AK8975_MAX_CONVERSION_TIMEOUT; int ret; + int val; /* Wait for the conversion to complete. */ - while (timeout_ms) { - msleep(AK8975_CONVERSION_DONE_POLL_TIME); - ret = i2c_smbus_read_byte_data(client, - data->def->ctrl_regs[ST1]); - if (ret < 0) { - dev_err(&client->dev, "Error in reading ST1\n"); - return ret; - } - read_status = ret; - if (read_status) - break; - timeout_ms -= AK8975_CONVERSION_DONE_POLL_TIME; + ret = read_poll_timeout(i2c_smbus_read_byte_data, val, val != 0, + AK8975_CONVERSION_DONE_POLL_TIME * USEC_PER_MSEC, + AK8975_MAX_CONVERSION_TIMEOUT * USEC_PER_MSEC, + true, + client, data->def->ctrl_regs[ST1]); + if (ret) + return ret; + if (val < 0) { + dev_err(&client->dev, "Error in reading ST1\n"); + return val; } - if (!timeout_ms) - return -ETIMEDOUT; - return read_status; + return val; } /* Returns 0 if the end of conversion interrupt occurred or -ETIME otherwise */ -- 2.47.3