From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D26C3E9F82 for ; Wed, 22 Apr 2026 13:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776862960; cv=none; b=pHlgmQbZoIjxlbkrIu4cXbMLgI+RaXdhLwc++clcArS4R8ImUZCSk8Nnswxq8yZ0EM0cwByvKINx3ldrPPrZybWfSgFY9/OqdZXcKsvUepAqrcy78RbDmx6cer9MNgcjo7Y9wn9IHK8Yu74IwyKxnMnC2fglECd8p6c1ofmpkQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776862960; c=relaxed/simple; bh=T1FD6RRcZe1hlxn6auCxKw8qq4oFtx3vYeZRnRheLT4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZpjtxVYnibVTFw33M1tMpSybUbwk+P5UBsSJONC6pHFc1WSFuPUNFuH11lYLYcgMW4capzsnk9ZZnQAiDsHP/k2EaZs1P/6XG1N2xEOPq/DTVOIQvE4l+pxLX42Ct84HEpGNQOB/CT3DAneHyRZV5F3Zend/eB2x4sjl5n2T6po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pQG6fkkv; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pQG6fkkv" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4891f625344so37659485e9.0 for ; Wed, 22 Apr 2026 06:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776862958; x=1777467758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=PAvQgbFKezKfMVm807wMCPxeAcqwUdGT7XqFMU3AArc=; b=pQG6fkkvtotFAsuQw5S4TIwt4x0B0hSMeRhkM+QeL6AWoW0tmVYxzIhD3KIBgCiVN/ pR1nIizwwh9GTE6ddjHGr+Ckj0EAejj6jzxM3Fuzl6LmZA/PYHex+Zv/SFpiSFGwi3rn sfjR7Gk/G+mGhcEch4vr/rHj1obAqmUoJYDYaUfJFZnSqOeUxgJuEWG+IRFrYj4ldQz2 K6muItrOIbfZvR2OYT8t7CwUnn2Bxwe6AGxWxo+uAYud3mAjKO30p3Ti2caYXuTGWzsn yz2dTPGQHuN3y8mhBUtt+F+WiogGvAQEdooTr5tO6mPy16fzWF5YWYYKPTrIk+sDmeEE SsIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776862958; x=1777467758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PAvQgbFKezKfMVm807wMCPxeAcqwUdGT7XqFMU3AArc=; b=gZfW23awuJ5rY7ANAHXBIC1SU58/rXOhN4C/wk5jHmNqQ73Vkk45qfmwVzHjsbj+BP k1m7JFK4CaV1gcwSuNKs5A8QZ2iEa38LTNH1JhGdwGYL/9Y0GWwJD/8gbXnWcXt0kl51 BhY9cpkFN467ReRf/fNdoZmnGizGNcK1fYBvfrHx0a4OYZz7mz8980ill5RvTOZImPi1 KhHsFNZpjVncnnchuOOw8breit59HDB6zuM9tWR2MfPlzDHGhdh9qnFGWCuPDFQ3VATJ 2l1xfIGBu7UnwZJFnq16prw/ufRtHm2ElIQcIutqhhA3iZLuu7L6OJtIz+YSOPGf1aqH EAHQ== X-Forwarded-Encrypted: i=1; AFNElJ/KnFeTr8OrTwcbVAL0/Da88ObI3tuwfFB93EAhL39f3RtNqTiDhi+ugDYkS55Vy9TRYo7SK1W+vqTHeT0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1lLYErAuF96HboUqgq3H/O5m+C4jO6gkN1Rrk1wZiauhA0JAp 2Jmj5sKmFRSB1l5F0OqpeymRY9rpWWG0yAYK+f8yFWCsoahuIwvIfLO7Rtx31MB7 X-Gm-Gg: AeBDievN83uuyXpyUCQLuSFqqMiXXaRv913O/2eA3egRajHiYvHXim1b28SrTKImP7/ o+ls1DEojXCweRm2G02974/vtCdhMB0UkalfOjbhPvr266rTklcaoY5usK65lAsBb5Nz/hFx9IZ eItzhSZS2yoDWhyH+X2WCXBcay3SbK/0gOw2y6AY4vRxw5phMO2x3spF9nb+aIMwRt7JuYhrW4T yv5mvlCWIELy3zWRHx2IIJnZeBbM3qD8Okm0tmWjAI6QsmQ+vob3W55jBcxLauQXUBsahXOiqPy jJBsWFlAA6gS6vWCXtrby2gc6RWKFtxQei2gaeoRAvz3/H6d+5dROpJF0UtciOmJYKrmUNEEwZI 34u3Pge2ueWWmg2Cs8InCoe6dQMKI18rI60NMOAM52yjeuUnYJQEusUjuskkcHMmnjbrkeli5Gl j2Zvzti6S+MuY6Lo/0ZWDikkERK+4BfU4GKI/NbNcKqGfypNfoOTEUlKsFt2YgcY/G4H9XzAbLm eM= X-Received: by 2002:a05:600c:a305:b0:48a:53cb:8604 with SMTP id 5b1f17b1804b1-48a53cb8949mr97880775e9.14.1776862957416; Wed, 22 Apr 2026 06:02:37 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a59816b71sm36512125e9.1.2026.04.22.06.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 06:02:37 -0700 (PDT) Date: Wed, 22 Apr 2026 14:02:29 +0100 From: David Laight To: Miguel Ojeda Cc: Marco Elver , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Arnd Bergmann , Miguel Ojeda , Dmitry Vyukov , Nathan Chancellor , llvm@lists.linux.dev Subject: Re: [PATCH 1/2] Compiler Attributes: Add __access macro Message-ID: <20260422140229.5a6f23f2@pumpkin> In-Reply-To: References: <20260421190351.1976329-1-elver@google.com> <20260422110114.0f48d109@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 22 Apr 2026 12:25:32 +0200 Miguel Ojeda wrote: > On Wed, Apr 22, 2026 at 12:01=E2=80=AFPM David Laight > wrote: > > > > Putting the actual syntax in the comment would help, eg as: > > __access__(read_only|read_write|write_only|none, param_number[,= size]) =20 >=20 > I guess you mean as a quick reminder for those that already know about > the attribute? >=20 > That sounds OK for an attribute like this, though generally speaking I > would avoid duplicating the compiler docs. (Hopefully people will > still read the actual docs... :) It might save someone who is just 'wondering what it is about' from having to read the gcc docs - particularly if reading the file where you don't have a browser handy, or in an editor that doesn't support following links. I also had to read a lot of the 'actual doc' to get a hint of what it all meant. > By the way, that could be `__access`, i.e. documenting our side, i.e. the= macro. True, and ', size' should be ', count'. David >=20 > Cheers, > Miguel