Re: [PATCH V4 02/10] iommufd: Move igroup allocation to a function

Jacob Pan
2026-05-05T21:32:19Z

Hi Kevin,

On Thu, 16 Apr 2026 07:48:27 +0000
"Tian, Kevin" <kevin.tian@intel.com> wrote:

> > From: Jacob Pan <jacob.pan@linux.microsoft.com>
> > Sent: Wednesday, April 15, 2026 5:14 AM
> >
> > From: Jason Gunthorpe <jgg@nvidia.com>
> >
> > So it can be reused in the next patch which allows binding to
> > noiommu device.
> >
> > Reviewed-by: Samiullah Khawaja <skhawaja@google.com>
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > Signed-off-by: Jacob Pan <jacob.pan@linux.microsoft.com>
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
>
> with a nit:
>
> > +
> > + /*
> > + * The ictx is not additionally refcounted here becase all
> > objects using
> > + * an igroup must put it before their destroy completes.
> > + */
>
> s/becase/because/, though it's not added by this patch
will do.

Thanks,