From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF9EC383C97 for ; Wed, 22 Apr 2026 16:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776877024; cv=none; b=Rws785LmV5VmAV4LT7wXuxu9tycpqX3yI0WAsQx9I5o4NNbzuZeUhrsxs6S9jNaFM8U+0zaUySUrRERuyNj6lapKGeQ4oyJA8E4MqlvOg+y4cG6rd0bp072jfz4/FDJCUpdtzcYZT3FDG7ZC0xJRaxps384Z3GZqPOU5bLSI/yY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776877024; c=relaxed/simple; bh=OOT211Qg5Ti/MMGkmp30LRLc49w8nKu+eUOAg3LHjQU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XGQMrUVpJmG7vIAZSb+aAInvHnuLYZtSh2NtBdjImKN3uih/wPyezU/o2rGVd8gNlu0gUFUofn6Gw967Mn9ObNvYpSkTjDbomN8/YbH3whWIhGWjHFNKMZvIhhdB/G5qE/c2MkC1qY1S8s9KhPZgOZv2B8Io2+XnSp/MtbdRzdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=esgEjj1/; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="esgEjj1/" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c70ea5e9e9dso2414760a12.1 for ; Wed, 22 Apr 2026 09:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776877022; x=1777481822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=riaMk8etyq0rzfYVnIkS4yGsS6/2CNoO7Rh/WBiTOh0=; b=esgEjj1/sphdPN6y2Q/ZD5qfPd9ywxli8mMYH1Q2D8mVSkfWcVArLquiOLyvmaL1vN oSR8fFsS5VYIOIJ2wt6zfDCWN/VG5JDLhk7o3vHVwLfP0/6qgrqbn4pBuzzzHUL3jOw2 3QZOWU+8o8EmvyHvQ5f7bEgUY3XI5RfGnJmPhDpLNRfog9DYL+2droTT5A6RmMHMjztr f0s153tnWFxGpteO2EBbkGy5Hujy+NRV0cYgv49XJJGIUZYwQbbT2rO4ONQI2tYpYUPo 4mm2uLUKdElqcW0nQm3Kn/iryQ8CfhAcc+UIA1irRmQs6dQ5XK1ESOvSKL/V4xftER3m jPhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776877022; x=1777481822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=riaMk8etyq0rzfYVnIkS4yGsS6/2CNoO7Rh/WBiTOh0=; b=MBORsPhmLt1ZqD7xwef0FoXsgZ4l+1aEyXYS4Xas+0uym9WSgftFSRRE0gxr7eKhzq DHRmrUJngMcNoS3p4CwSMg0dNeW82FwbEV2NV+zL2lGICEIQIU9xsKSqaFzf37qqQilk UDsCaPLpN3J9UPYWRzQtERQpnLIZE+1sm59fSzBd6iyz/j1tgXoRYaAmThFAesA2LYQP 5vxkoZ7rg9gPSxUYpgj+bTzumbqEK06WsvULcJVZGNhKzrmiHmsKnnAadEYNdAlvSSkz F6wXU+jwY+d63kzV4Oloydo+23mretipFfarBnGd8mlL3Wk46vFxOoXbV0agHRp+7iuf VjAw== X-Forwarded-Encrypted: i=1; AFNElJ/D5bi5QKGcAQgUTY/z7QP7XWO/1ENuRyGc8jjDDDw8YD4MNBez6mFxpX453cKENz5UUD/3ss+xMRuIk+Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5Kp2lBahZYBaReOhMTIJSUggIcZtmiNmTOjGjpQIDV1iWn032 ktqzivqvAPy/3v+rGFXSJIQSnfliTjwzQuO6U493VuGR+dsfrHvlord6 X-Gm-Gg: AeBDievZIuh+GT44EVk/gCp4KV4yn/IrZscFG271fZ0W/PeXj9lB3ydQPgqePEb+lTR Y5EIq8gvww23eVYRbICFVpkfEpLvL0SxKy7ydMIr5A2VaXDwye6Z8wAB8VndtydKjP4/u7f3D2/ fTaPgK2a8PIQ1npqCAxEU0Q/vOtjF9+Qr0yd/xkZHMptQCl/i9kvmtHvolgjlRXeowJGvlYH8S/ n01uqrcyfTZWDg0G9weslOXXeJN3/zP7/0EWW1KwXDIZ2TPAXJBm7y5pVCAp2WTp7yB/eIw3kxs 2Un5feGbFyHE/uqSzalU8kv8rsI9OEwT+5jAEmcNN3gvyasgWKOVg3SWIXQrbuq1UD4Jmen/0JE 6lvKldqK1Ss6y1Qi9V/jpuLUluL2zM0W5xwu3jbhqVS2nz+AvczkeYmHSUePDijfPmYSjdwp4a+ HREKl+iqCAXVMmkhwmPw3VoZ/ocytLwwZGWB9p2CPFU/sGz80HxZMJQCEDzDI= X-Received: by 2002:a05:6a20:3d85:b0:39b:989e:6d39 with SMTP id adf61e73a8af0-3a08d8a947dmr28481466637.35.1776877022097; Wed, 22 Apr 2026 09:57:02 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7976fa3604sm11908675a12.14.2026.04.22.09.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 09:57:01 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/6] iio: accel: mma8452: Use dev_err_probe() Date: Wed, 22 Apr 2026 22:26:41 +0530 Message-Id: <20260422165643.2148195-5-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260422165643.2148195-1-sanjayembedded@gmail.com> References: <20260422165643.2148195-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda dev_err_probe() makes error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 99f7763b84ac..d1ae2bf37409 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1563,8 +1563,7 @@ static int mma8452_probe(struct i2c_client *client) data->chip_info = i2c_get_match_data(client); if (!data->chip_info) - return dev_err_probe(dev, -ENODEV, - "unknown device model\n"); + return dev_err_probe(dev, -ENODEV, "unknown device model\n"); ret = iio_read_mount_matrix(dev, &data->orientation); if (ret) @@ -1581,14 +1580,12 @@ static int mma8452_probe(struct i2c_client *client) "failed to get VDDIO regulator!\n"); ret = regulator_enable(data->vdd_reg); - if (ret) { - dev_err(dev, "failed to enable VDD regulator!\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to enable VDD regulator!\n"); ret = regulator_enable(data->vddio_reg); if (ret) { - dev_err(dev, "failed to enable VDDIO regulator!\n"); + dev_err_probe(dev, ret, "failed to enable VDDIO regulator!\n"); goto disable_regulator_vdd; } -- 2.34.1