From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAC7A35F5E7 for ; Wed, 22 Apr 2026 20:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776890712; cv=none; b=ZoWnJ7sTTtoVNreM7mFrkGdNWQd5koZAMbCdKDoLqmYFBzR03BV4mqVnUMpG0BkWrsI8hYGOZz3W0ug3ddZnymbKXwhmCvwNDLYM9afWDHabQy1idOmilGoDRQExibzAUd7Bfz3BH4MWCR6cQNaC4oOSfedmRnkeMi1W8p8A2L4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776890712; c=relaxed/simple; bh=s0+TsPlrqsaVkN3IgA/+DIc155a6W7poP1XyfN7Kx7Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mNk6a3U4uONPvuxeCxHL9XHs5MmtqOSRX520coWYWqISg52pJS//KP0lj+86Pst3hbPabeBKRr6YuBjVeLwhXtCDeGS4ivQPJ4NFAZ5InWVlxyFgc3R3Tp7E5aVTP2Q7X5/H35slsHMhRP2oubUofrsBS6mDkcnbJu6AQ9U/IVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O9SmUYU8; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O9SmUYU8" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so42078135e9.3 for ; Wed, 22 Apr 2026 13:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776890709; x=1777495509; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WGmQa96Hwu5AyuQmms3tFUQ1vq0rZ84zqi0RkPO23JY=; b=O9SmUYU8s9RkGR7RqqrhTjJ/qrOqaYEvqdOHFTEPrcFx9etqgqOkMMGIwJ3oXzbtRO btbYBGB7zC7DNRxGqz4KVpKLG23CL8sPMCQc/VlcgUFPLLgDECpsrDF8uWsUEZddrdAc /o4vNT42K64urS0FOtawqaLvWr/CeCweSejI51dwRsECRh9rnKKJ5+pVsy61tfFrYz8t OBvLxF7YUnIsH/5QeTNYzFmpN43sTXybN6xiT1ANneR/aXj7wuNDLzEmSgb6T1GoA6l5 1up4Lxbe4o6YvDgmDRryvAs51gzGAzRES8ztLeD/5SIAEreCH/0wWPyqzjd7p6CHuvf7 vOyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776890709; x=1777495509; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WGmQa96Hwu5AyuQmms3tFUQ1vq0rZ84zqi0RkPO23JY=; b=Ej6bmRWGxbbcKy1tGHeF7xD4bsgCAhvlkvJL5MSPQPElU5z8dvD7G1Zlsv/XTY6wWE 6maMPsSmyB3KH53Nqz/b/8Aj5wD14QyK+wWcGvK3uhax7Q/gMgMgPAX6a7m/FGUA43wX rsvlyZ4rEaifVyA7Hv3G2bM36fRxgBx3+1t4UyxSYaa5rFS6VL0cCf3wpbzfxNewqTVv FUD2wpCeN0i8UxpgjoHTbx6m6yItPFRvGhMHTnCy4EL/dozagTreD8cad5aetDcMaXw/ xCWnw0TwR0zrOuDJQQKuXhwIMES9am+k4KRlNp33v2Z29Z2dr24G40MYvmRB/qZh65cz 16yA== X-Forwarded-Encrypted: i=1; AFNElJ9TLdFCEF/D2BN17q8FdadeeXmTNAJ4ui8R7ap6Xe13qGx8aBU7sPcpvxwUnBPArGOtSPDBaNYR4Czi9EQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyCT8f9dYDGoiLUVKapxb1/9M7Ylw/C3BKRVAK2zomVccWJLtB/ /Am/NZPOkjOsESSmY5PLyPt9iqpK+weN/V9gP1SB+VTCnDNgNRKL3+90 X-Gm-Gg: AeBDievWrD5kLLI6SkeMH0/6EkRHKOc3KLou7ykFIy5qXs2HCql+8sxn+9piaqoNV54 J4USvldzM5E3R23Mhz6OLC1tkD/TVRzGzE3GdDOPXhg8MQYtgWtT+EdxLk3sbBEncLP0VF0HKIO 5060b1uOyiO0lJEw+FPvzANIOXMM9XaGyTkGyTeO8xOguRc9qfI0jgZQxD3QCv4DEJwGKX7USTw lecd5lWv9Q3SQQyCloUy9nxOJw6OCOPwVU81Dxy54sePtnOSbkMvUdhCLcs0xdUOa51g6Yk9JiA 95rb9dMZo6nCbKmNrXlk9QK1M3wwznurASsB8IQvttszmrTSgm/g9apRncXz0pZIG/2T8Qs/p/n QGbkH18rG70ZdfnTgl68HUJGKfsM6KyBFpcYS3T1Zxs5KeM1nC+6RkV6CUtWBv/PGtFpVKuvWMw Ic9w14DVky53mwbdmc0KVQbchdWqI/dsLWAZvh6haVJTyYG7bkx8YAc1ZfGI1vMzxokLKwl6cec 5c= X-Received: by 2002:a05:600c:a105:b0:486:fb69:4960 with SMTP id 5b1f17b1804b1-488fb7786e4mr248879685e9.19.1776890708999; Wed, 22 Apr 2026 13:45:08 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7c0eacsm148798195e9.35.2026.04.22.13.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 13:45:08 -0700 (PDT) Date: Wed, 22 Apr 2026 21:45:07 +0100 From: David Laight To: "Shengzhuo Wei" Cc: "Richard Weinberger" , "Anton Ivanov" , "Johannes Berg" , "Dan Carpenter" , "Andrew Morton" , "Jeff Dike" , , Subject: Re: [PATCH] um: proc/exitcode: fix simple_strtol() out-of-bounds read Message-ID: <20260422214507.0078c8ba@pumpkin> In-Reply-To: <20260423-fix_exitcode-v1-1-7e4508913d68@cherr.cc> References: <20260423-fix_exitcode-v1-1-7e4508913d68@cherr.cc> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 23 Apr 2026 01:39:25 +0800 "Shengzhuo Wei" wrote: > The stack buffer 'buf' is declared as char[sizeof("nnnnn\0")] (7 bytes) > and the copy size is min(count, sizeof(buf)). When a user writes 7 or > more bytes, copy_from_user fills all 7 bytes without a NUL terminator. > The subsequent call to simple_strtol() expects a NUL-terminated string > and will read past the end of buf on the stack. You should probably also mention that write(, "123", 3) will lead to buf[3] being read - which is uninitialised stack. David > > write(2) should report the number of bytes consumed. Returning the original > count would claim success even when the input was truncated, so userspace > cannot detect it. > > Clamp the copy length to sizeof(buf)-1, add a terminator, and return the > consumed length. > > Fixes: 201f99f170df ("uml: check length in exitcode_proc_write()") > Fixes: e16f5350d4cf ("uml: get declaration of simple_strtoul") > Signed-off-by: Shengzhuo Wei > --- > arch/um/kernel/exitcode.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/um/kernel/exitcode.c b/arch/um/kernel/exitcode.c > index 43edc2aa57e4fbd4a3d24f96878c76f9f8fd4eaa..8de404ff21a213918c5351bc20a6e047bf1b93f5 100644 > --- a/arch/um/kernel/exitcode.c > +++ b/arch/um/kernel/exitcode.c > @@ -43,16 +43,17 @@ static ssize_t exitcode_proc_write(struct file *file, > size_t size; > int tmp; > > - size = min(count, sizeof(buf)); > + size = min(count, sizeof(buf) - 1); > if (copy_from_user(buf, buffer, size)) > return -EFAULT; > + buf[size] = '\0'; > > tmp = simple_strtol(buf, &end, 0); > if ((*end != '\0') && !isspace(*end)) > return -EINVAL; > > uml_exitcode = tmp; > - return count; > + return size; > } > > static const struct proc_ops exitcode_proc_ops = { > > --- > base-commit: 6596a02b207886e9e00bb0161c7fd59fea53c081 > change-id: 20260423-fix_exitcode-908061ece624 > > Best regards,