From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C39741D6DA9 for ; Wed, 22 Apr 2026 20:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776891286; cv=none; b=WZhseSBQ2f5SUsfer5gE8nWNMiGPLanD7YVzY712tppsU5vGXOE5VaM+hVA+/LPyMESiqkzfjTC+zublJpjixvycPnqKzCxaFs+WDNWln53t6EeVE4UZJ9wRs2zWC9ch1cCWnIIoMsXPfA8teqtZrgbs07eUTjUbd1tZKMTMi3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776891286; c=relaxed/simple; bh=774rQfM41qPtkyZjQgUrG4FNguFl9uLDh5jhcxkPVzk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SwXINNbhiF1WlxScQ0D+RJu63I09qq/I0deoYZGb55WWwEHJGuPrWQ/+friV7EpXdaBJBO1NHpN7NmeBl0gjcx9ur7/RWUUb5cCll5VsL5jtT7t8r4B4zkAjjIDBzbOfnf88qRuCulKyASTlxF0y6cAWb5V3sJCX0lyH61Hot2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=licbAtOO; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="licbAtOO" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43fe8bda8e9so3155301f8f.1 for ; Wed, 22 Apr 2026 13:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776891283; x=1777496083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BdbNxflSk7ifnlaOODr8r5GA8Z4c6VemJtceNGAv6Fw=; b=licbAtOOA6QmgIWhEB1fKKlmuHL1rHuloiIVE8O7YTlkabQmNoCrXgGslo69O/CHlY bbAhyJ/cdU+u9xTr28voB5esPch6fWY+fPfpl7oUqKL35peRaV11FeEUqeJbKd0VRKc2 NoQv/lukWho/4qIZmDJouSIWt3WaTeTmxcjLv8twAEbChtXze6nXggtcIlizO7FtxZOT 5ChVwQJqgX7qJmjsv0IFwQDFcz92x34tj5ROjUB0kqn2rtgp+GFFPLJfDYHdQ/oDHNZo 687NX/yIQljWwLMjJVH4KxBSD9/eHKUha+h6mC606LAke2QISaTlC3SM9eyPH452Kws0 937g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776891283; x=1777496083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BdbNxflSk7ifnlaOODr8r5GA8Z4c6VemJtceNGAv6Fw=; b=MNr4w3THMMLyXC+ZQLd/TTkZXcnRqDvs36DqVYreHE1x1k+i7Qn1sZWHwLUGpt5Ik8 Uf6q7HDQiZCH4r2pHamRwisysUlt8LXYX5QGN4UR/ru8g4rIb3o7BrJ9TTs1vxytzZK/ XWs+HFN0EtKgUnLlh9rg/i4XULKp74CgK7t564P30K1ml1Zq/HeIToroPFxd7e0niIeE OWgL5Tf0XdOTYPSGmk8ecdv0Kg/KXz2rp8Um0WqE2Sca2VLUEtda+bUhnL1SSYOqQnjc tg6g2ocjbdLmMtLWWbw8wfzFJ0hMq5dlMTq1LusiPK2JZP4xBKjtMYscNPEsFUg0BlCX CXsA== X-Forwarded-Encrypted: i=1; AFNElJ8Pq597XmRf30bAA3UcysOjQMPu+A6bUmYuWyuB0ZM25hLNPVdbFEiCeyPI0rklntjTpD+KdG9susdYUWA=@vger.kernel.org X-Gm-Message-State: AOJu0YxIxtG6hw9q2PpCywkZOuw2x9PbTZLsK4qFLobIooRg+XJ7b+3I F8SvBRLgv6/zNkLHsws4avn4dSc9SYAQ1hGQiOKlAhFcMFwGhBLhkhgu X-Gm-Gg: AeBDiesQgqyNLVxA+ZKJx//9PHDBcFcibz8aY1tV3oNfX6bjDMDhG3E3rhzC44bTnnN PP02+yB5OjsCpwg3so889k5PMR7Vi/1NMnf+PNNSUg7qvjrbyCRbHhRl7+bmWj0uMvmkponxr2U F1HNWuqg70ljw46PHFqdD9TK6dRCaZYFkuOHuHhRMHZJWcGbhTxrbdrIvYBt7sEJSP31L+tViPp jydHWy/DMHHeZ76VP1runbeh1bdMklmg/NwuaUu1wH20NeooOT/V2W63BIJLCtDqSbzrY9p3sJ7 KtqTLAhFaAojKNntZVguQEr+ezKjEJBNQZGD9jNjgi6SzA5YF4N+/IOdyaowXGEuyjDZP8fqX/F zKb390GYQT340kI6c9mdyCWRQEzU2udE0YQ/Y7MOCtyoDtoH6QPOURrvuwL/uoM6tdgPLJU3RTK NrB1wi9J1Cdl6+XWAYrRHxyDST/W+bAad7oGmub+M9rBtrve8h0mTpBGhK/G36+uTNhp8A7q5P0 uw= X-Received: by 2002:a05:6000:4203:b0:43d:242:b9bb with SMTP id ffacd0b85a97d-43fe3dc5c80mr36772655f8f.18.1776891283082; Wed, 22 Apr 2026 13:54:43 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e44f69sm50195066f8f.25.2026.04.22.13.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 13:54:42 -0700 (PDT) Date: Wed, 22 Apr 2026 21:54:41 +0100 From: David Laight To: Mauricio Faria de Oliveira Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/3] x86/asm, x86/boot: Expose inline memcmp Message-ID: <20260422215441.4204c142@pumpkin> In-Reply-To: <20260422-pvh-kasan-inline-v1-1-7e6194344c92@igalia.com> References: <20260422-pvh-kasan-inline-v1-0-7e6194344c92@igalia.com> <20260422-pvh-kasan-inline-v1-1-7e6194344c92@igalia.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 22 Apr 2026 17:07:45 -0300 Mauricio Faria de Oliveira wrote: > Move the inline memcmp function, currently only available to boot code > (boot/string.c), into the header with similar inline string functions > (include/asm/string.h) so it may be reused. This needs a comment/warning that it is incompatible with normal memcmp() because it only returns 0/1 not -1/0/1. Most callers don't care. David > > Add a _SETUP guard in string.h so not to include the 32/64-bit specific > string headers in boot/ code (16-bit, real mode) and avoid build errors. > > Signed-off-by: Mauricio Faria de Oliveira > --- > arch/x86/boot/string.c | 6 ++---- > arch/x86/include/asm/string.h | 11 +++++++++++ > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c > index b25c6a9303b7314d5caf5c9306239811705294fe..bbee78637b349e42e9281d8df50d89d48f4490b9 100644 > --- a/arch/x86/boot/string.c > +++ b/arch/x86/boot/string.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include "ctype.h" > #include "string.h" > > @@ -31,10 +32,7 @@ > > int memcmp(const void *s1, const void *s2, size_t len) > { > - bool diff; > - asm("repe cmpsb" > - : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); > - return diff; > + return __inline_memcmp(s1, s2, len); > } > > /* > diff --git a/arch/x86/include/asm/string.h b/arch/x86/include/asm/string.h > index 9cb5aae7fba9ffcf0f5af8f939d30467750ccaa9..736a6f6a31f0a68281b4f17415aba0fcd95dc228 100644 > --- a/arch/x86/include/asm/string.h > +++ b/arch/x86/include/asm/string.h > @@ -2,11 +2,13 @@ > #ifndef _ASM_X86_STRING_H > #define _ASM_X86_STRING_H > > +#ifndef _SETUP > #ifdef CONFIG_X86_32 > # include > #else > # include > #endif > +#endif > > static __always_inline void *__inline_memcpy(void *to, const void *from, size_t len) > { > @@ -29,4 +31,13 @@ static __always_inline void *__inline_memset(void *s, int v, size_t n) > return ret; > } > > +static __always_inline int __inline_memcmp(const void *s1, const void *s2, size_t len) > +{ > + bool diff; > + > + asm("repe cmpsb" > + : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); > + return diff; > +} > + > #endif /* _ASM_X86_STRING_H */ >