From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A05D382F0F for ; Thu, 23 Apr 2026 10:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939587; cv=none; b=Q6OT6ttmrZf7pcfjFvHxY7lkxxrPQRdf8V4r9GH6oaiakzqKtHkC+O95f+tRXL3WfE9r10ssYx0TqQNwwpyOcZyWFQK51vmUg9AwOMsm2AzNjehLMewSz9Ja3E0mvNs8d+sLucobyEK5tifNitO+oittWia/Ii+ALay8UmIZThQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939587; c=relaxed/simple; bh=Z8riGyhf3Bz4GzgecgLlN1izPrFfKBgKdgftTPMMNag=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ttW5Fa0KpFQoONl6z5gcwmYvwagsQelPa+/hmiLlBzO8Y1XLagjX11ify6bF3eo8KCkma0KkrfeHzZXpU0uLgtmc8DuqKfjc04k30ELRU14B3HG4Cors6cEKFOKCfsWQVwYzT7k0BdsPptUsfJbSg8KHfSCZ3v0eN8T8CnZrcG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I/md34P7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I/md34P7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 098F9C2BCB5; Thu, 23 Apr 2026 10:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776939587; bh=Z8riGyhf3Bz4GzgecgLlN1izPrFfKBgKdgftTPMMNag=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=I/md34P7N5U8/pvYGYXfRg7xgV0JpvhZCQopXZUVkQpxQydqqfu+Dvf67DKFvJVZv cc9P1EjbsNnuW8s9g5Ms8g+qgXTFdEiq2ooo00vSOJasPA1VD36DWZTX0TdqiBH8ix egCvLkQVdPCO/VGuYqbT1twAwMIpItprrGaaJufpAF7eHW5ZUOFI0hDB5swY66SAc0 XIs7SoL93fKWujVglmjCN2ceKhmGp2+wWGuqEgsPYhdO6P49dWYViXDpRqgY/FTj0Y ibChMQnRfvPMxwF8RMcY2hCZkM+8uJmovRo/WPbSuIrqXvarGxrHElxcyx56y53L15 87rD0A5D/S5yA== From: Maxime Ripard Date: Thu, 23 Apr 2026 12:18:40 +0200 Subject: [PATCH v2 27/28] drm/tidss: encoder: Implement atomic_sro_get_current_crtc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-drm-state-readout-v2-27-8549f87cb978@kernel.org> References: <20260423-drm-state-readout-v2-0-8549f87cb978@kernel.org> In-Reply-To: <20260423-drm-state-readout-v2-0-8549f87cb978@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen Cc: Devarsh Thakkar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2408; i=mripard@kernel.org; h=from:subject:message-id; bh=Z8riGyhf3Bz4GzgecgLlN1izPrFfKBgKdgftTPMMNag=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDJkvP372Xyuff6AzxpipQD5yQw7L5SilnRyrVwvPYlH/e SzLwyG8YyoLgzAng6yYIssTmbDTy9sXVznYr/wBM4eVCWQIAxenAEzEfRJjnY4MD3O34/W3ryXD 3t2dqZrEb1ecMKVY48bf66tPrKiUCeaKcNgsYWX6cAtT1F35K4KnGBu+X74kscND/eHq6rKYeM7 zv++tY7e9+Hbx9/VzG3fXHAizixScMcl29smexvq/tUabTuoCAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D The tidss driver doesn't really implement anything with encoders, it just relies on simple encoders, bridges and drm_bridge_connector. In order to figure out the CRTC -> connector association from the hardware state, we do need encoder support though, through the get_current_crtc callback. Since the tidss encoders are always connected to a single CRTC, we don't really need to read the hardware state though, we can simply return the one we know we are always connected to. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tidss/tidss_encoder.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c index a20d7826e3cc..7883f5ec6d41 100644 --- a/drivers/gpu/drm/tidss/tidss_encoder.c +++ b/drivers/gpu/drm/tidss/tidss_encoder.c @@ -92,10 +92,29 @@ static const struct drm_bridge_funcs tidss_bridge_funcs = { .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_sro_readout_state = tidss_readout_state, .atomic_sro_compare_state = drm_atomic_helper_bridge_compare_state, }; +static struct drm_crtc *tidss_encoder_get_current_crtc(struct drm_encoder *encoder) +{ + struct drm_crtc *crtc; + + WARN_ON(hweight32(encoder->possible_crtcs) > 1); + + drm_for_each_crtc(crtc, encoder->dev) { + if (encoder->possible_crtcs == (1 << drm_crtc_index(crtc))) + return crtc; + } + + return NULL; +} + +static const struct drm_encoder_funcs tidss_encoder_funcs = { + .atomic_sro_get_current_crtc = tidss_encoder_get_current_crtc, + .destroy = drm_encoder_cleanup, +}; + int tidss_encoder_create(struct tidss_device *tidss, struct drm_bridge *next_bridge, u32 encoder_type, u32 possible_crtcs) { struct tidss_encoder *t_enc; @@ -106,12 +125,13 @@ int tidss_encoder_create(struct tidss_device *tidss, t_enc = devm_drm_bridge_alloc(tidss->dev, struct tidss_encoder, bridge, &tidss_bridge_funcs); if (IS_ERR(t_enc)) return PTR_ERR(t_enc); - ret = drm_simple_encoder_init(&tidss->ddev, &t_enc->encoder, - encoder_type); + ret = drm_encoder_init(&tidss->ddev, &t_enc->encoder, + &tidss_encoder_funcs, + encoder_type, NULL); if (ret) return ret; t_enc->tidss = tidss; t_enc->next_bridge = next_bridge; -- 2.53.0