From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A950F39020C for ; Thu, 23 Apr 2026 10:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939530; cv=none; b=X6RJRKzHwJUrvGcq/3BlSX/T0mMpx3JTcKN0YKrfU2S0gd3YBYlZYZt1bU4wBns31XozxHrAKlaEFgbJpagsNNLE9OiSo8VoYdAFT+Y1xm6XbIZNmSnQstP2GOFAVPMnG/GMdYyoNbGq+tqw5NUMWeMaAANy7zxydyuc9f+wP2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939530; c=relaxed/simple; bh=O2jp6irC66I/YKsexCxHrYpHywSRWdtHqF1jtIfmIX4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q4eagQjIuLvrvSyPciOd5NwqTxBRbwrZ9kZLrvo/VFCmTY/Rt7PqSFlM2uH0KjU+vLMs8zEXetsnyd/+HhTjjkCn3uqLbIoW374OvmdNFiXUFTIovrLq6FYE94R2ZuselmvHr98kHVV6PEmtwnKB51K7njmrKOqWl8YsfSe8l3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WlowFePK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WlowFePK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE446C2BCB6; Thu, 23 Apr 2026 10:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776939530; bh=O2jp6irC66I/YKsexCxHrYpHywSRWdtHqF1jtIfmIX4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=WlowFePK7t+bJe6d8YglFkf4eB3adOhoArZgR8Al+Qa3paOKlEmEGrWTxKKRO9p9t fMlZubCMmGPODtcCTbFev8EhWlRBcogQDAbOR5a8SbYCJlgXBjkIftB1dNpfJ7sQCX 1XE+ich0FfgfkELrWYk/a5RFdHoOOPxeEIIHSG8Go3Ma0TRc4iBA308YyVuTFqChKs Hfzgn1a6XIShvzCRO0s0XXhLueWb6ZEJN1L1FDUWP9lcG3GbwFBTnEJMYK9dlusUOH xxodFt4LYpIqOnkx+CQbWLim5dftcaVl7yY0TEAVpaCjYEFO1br5t4YZYp8ua3I5tt RMgsYvebqNujA== From: Maxime Ripard Date: Thu, 23 Apr 2026 12:18:20 +0200 Subject: [PATCH v2 07/28] drm/bridge: Implement atomic_print_state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-drm-state-readout-v2-7-8549f87cb978@kernel.org> References: <20260423-drm-state-readout-v2-0-8549f87cb978@kernel.org> In-Reply-To: <20260423-drm-state-readout-v2-0-8549f87cb978@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen Cc: Devarsh Thakkar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Laurent Pinchart X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1977; i=mripard@kernel.org; h=from:subject:message-id; bh=O2jp6irC66I/YKsexCxHrYpHywSRWdtHqF1jtIfmIX4=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDJkvP76apS/3tH/FVZZ7cgeKP0xu2sqZxsj2/V7j7Rcv1 dU6BBkPdExlYRDmZJAVU2R5IhN2enn74ioH+5U/YOawMoEMYeDiFICJSAox1vC0337Wlab8jEfh tOeT2i08Sx9MnXpaWaruOEec3znhv3szu8+lqTp8SCnM9mVImr/3EmPDQt6Z3uZPC3ybojYzxP9 ssYwQfG/8b5LTme3zHpy9UjVHLL04vHRS0Ane9JYpTlX7zp0EAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Bridges have some fields in their state worth printing, but we don't provide an atomic_print_state implementation to show those fields. Provide one. Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_bridge.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 5b8e171afbe5..fba440bddcb3 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -506,14 +506,35 @@ drm_bridge_atomic_create_priv_state(struct drm_private_obj *obj) return ERR_CAST(state); return &state->base; } +static void +drm_bridge_atomic_print_priv_state(struct drm_printer *p, + const struct drm_private_state *s) +{ + const struct drm_bridge_state *state = drm_priv_to_bridge_state(s); + struct drm_bridge *bridge = drm_priv_to_bridge(s->obj); + + if (bridge->of_node) + drm_printf(p, "bridge: %ps (%pOFfc)\n", bridge->funcs, bridge->of_node); + else + drm_printf(p, "bridge: %ps\n", bridge->funcs); + + drm_printf(p, "\tinput bus configuration:"); + drm_printf(p, "\t\tcode: %04x", state->input_bus_cfg.format); + drm_printf(p, "\t\tflags: %08x", state->input_bus_cfg.flags); + drm_printf(p, "\toutput bus configuration:"); + drm_printf(p, "\t\tcode: %04x", state->output_bus_cfg.format); + drm_printf(p, "\t\tflags: %08x", state->output_bus_cfg.flags); +} + static const struct drm_private_state_funcs drm_bridge_priv_state_funcs = { .atomic_create_state = drm_bridge_atomic_create_priv_state, .atomic_duplicate_state = drm_bridge_atomic_duplicate_priv_state, .atomic_destroy_state = drm_bridge_atomic_destroy_priv_state, + .atomic_print_state = drm_bridge_atomic_print_priv_state, }; /** * drm_private_obj_is_bridge - check if a private object backs a bridge * @obj: private object to check -- 2.53.0