From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5C3738E124 for ; Thu, 23 Apr 2026 17:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776965030; cv=none; b=sfmJBXN5w3aoiYUmh/DIKql3djQP8efP7fT4OTUMttdemB3I6QlafYP4gZYr02MRuQusBtfXm7UlLNP1iNaGVO0joQXLE3UZxu0cRpOsROtGk/GaNJTnmvaYLGOfTfBobT4+9PfZxQGPsOkdOrT4nqQXJVcxPsKvcYH8G2EpVoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776965030; c=relaxed/simple; bh=utWF0d0OTuccjyhZepa4vlGkotpk1+a6M/3wp4m9N20=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uyX1Vh++EpWTkeSOxwPcuvEt1ev0AZ+4ckp55nkPQdxSox37J3RWNsFl+yjm6f0oHFEu/PCFVD/XRetGxau0j2BYUR0gsmImTUZP8/FA7S8f5CuM+rL87e6vmy3IFELJocuwsNlXeNqKIXDAsTnHYsRxVrF6Q0b0Q15NJ1k1lSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pmxabPHx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pmxabPHx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98BCFC2BCAF; Thu, 23 Apr 2026 17:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776965030; bh=utWF0d0OTuccjyhZepa4vlGkotpk1+a6M/3wp4m9N20=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=pmxabPHxcbHN0RlKvKSMpaq9ZoNTBviY0q5JpEZT4QOAqfPRJodQGKxXema5vnoff adiiBGOkPU9HizmPx3U173CKN6FnN6Gittu+j1l/0xWxRseYy1gTCsgJAGYSuU5JO5 xBlKIt4fLgQ/iXjGXc7kOGS3fOxfhDrRwCugxXjKyhSepnRqeuexY+1zL/UeKiDvyq XuUXBHoW/b4FoSIfzzfDouQSInZj4fLa+nvRHGtLLF1VJToF/v/I3UnDaeF6SoHy9z 45gjmLzOlRKIRhnkcSVWxuproHIwtM+rAo5n1oDDwAlj1DlY7DS/XVX99asLEqRIGs S19ptdQJ21ydg== From: Sudeep Holla Date: Thu, 23 Apr 2026 18:22:51 +0100 Subject: [PATCH 1/8] firmware: arm_ffa: Check for NULL FF-A ID table while driver registration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-ffa_fixes-v1-1-61189661affe@kernel.org> References: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> In-Reply-To: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jens Wiklander , Sudeep Holla X-Mailer: b4 0.15.2 The bus match callback assumes that every FF-A driver provides an id_table and dereferences it unconditionally. Enforce that contract at registration time so a buggy client driver cannot crash the bus during match. Fixes: e781858488b9 ("firmware: arm_ffa: Add initial FFA bus support for device enumeration") Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_ffa/bus.c b/drivers/firmware/arm_ffa/bus.c index 9576862d89c4..601c3418e0d9 100644 --- a/drivers/firmware/arm_ffa/bus.c +++ b/drivers/firmware/arm_ffa/bus.c @@ -26,6 +26,8 @@ static int ffa_device_match(struct device *dev, const struct device_driver *drv) id_table = to_ffa_driver(drv)->id_table; ffa_dev = to_ffa_dev(dev); + if (!id_table) + return 0; while (!uuid_is_null(&id_table->uuid)) { /* @@ -123,7 +125,7 @@ int ffa_driver_register(struct ffa_driver *driver, struct module *owner, { int ret; - if (!driver->probe) + if (!driver->probe || !driver->id_table) return -EINVAL; driver->driver.bus = &ffa_bus_type; -- 2.43.0