From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FAA53A7859 for ; Thu, 23 Apr 2026 17:23:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776965031; cv=none; b=oc2/HBIPvWcc4dMDwwqvhJrY8Q4NXUVcVrV7J1EHnOlCTDiR7ubTAi40Dq91PFFa3bOKxMsa46TZG3ZCf4TtNt4zBPD83bAWrTLK+M4jABuSc7mn/q5iAJbPQZrrEIONSHdFcAq8eTEMm8CY6FqubT/VPlKLk4WJYK+I6QIDa48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776965031; c=relaxed/simple; bh=c4BcYMZ0KWMorH09+B5vNrAhFQ4rDIDYqWvY5VR5Gws=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r1AdVUjEUjQ4IE7+OKJ4qp04Fbp1HXw7ElDE6y4JIUOsrXDAxWczlffHAv83nPd0Ne1fKuDbUKj0hSeB/QYbsF1mCs5zFEVo0h7POv4Earh2ix+Uv6MYxFEMIncYzTO6lJ4x8/HigHFM86jvvXY/UwFjADXEqSvfhGyR9+TYvqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TJyq/Udb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TJyq/Udb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7DADC2BCB3; Thu, 23 Apr 2026 17:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776965031; bh=c4BcYMZ0KWMorH09+B5vNrAhFQ4rDIDYqWvY5VR5Gws=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TJyq/UdbIn7Ylv3yTN9y3bgSYNuxU6WqCRX/Hj6zPFxILEdXtEzjPWvDecb9bZF8x FkdCJrI+6o6qd7o7X2TIHCrcPEXbDrPpJes96F8ISs8BcmC1Yiyqu0Sk4A2XG87A7y ExFX0Q8BdDvdSL67amtyvJ8sAOH7opgk6uRa2x8N1glwFFoIjrZ2grq4ZnohbaPB51 vsYtS6EK3uASo4bnPjsg+sy1Gc9SUXaPwAqrA03fsVRbxJidCYg+wGefdV53d7X18f 19Re5W+H0HPN8ooi03kRDRkqicP5raw5jCLsX8vd3fItdvTKEE/vxFSBzG8Sc3hIj/ Xp3F7uvNQig2Q== From: Sudeep Holla Date: Thu, 23 Apr 2026 18:22:52 +0100 Subject: [PATCH 2/8] firmware: arm_ffa: Skip free_pages on RX buffer alloc failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-ffa_fixes-v1-2-61189661affe@kernel.org> References: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> In-Reply-To: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jens Wiklander , Sudeep Holla X-Mailer: b4 0.15.2 If the RX buffer allocation fails in ffa_init(), the error path jumps to free_pages even though no buffer has been allocated yet. Route that case directly to free_drv_info so the cleanup path is only used after at least one RX/TX buffer allocation has succeeded. Fixes: 3bbfe9871005 ("firmware: arm_ffa: Add initial Arm FFA driver support") Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index eb2782848283..e6a051b20cb7 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -2067,7 +2067,7 @@ static int __init ffa_init(void) drv_info->rx_buffer = alloc_pages_exact(rxtx_bufsz, GFP_KERNEL); if (!drv_info->rx_buffer) { ret = -ENOMEM; - goto free_pages; + goto free_drv_info; } drv_info->tx_buffer = alloc_pages_exact(rxtx_bufsz, GFP_KERNEL); -- 2.43.0