From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAEFE3A9D93 for ; Thu, 23 Apr 2026 17:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776965034; cv=none; b=Q7/cuavVruVpzCwMoe+IwHCvCvhA2EHd5A56ivGLZpvRskvysk5tr6ks7SC02F/kwlsti0D7PmGwB68ohbdjRIt3/VlThvKZpoOjSWBnn1ZeD5X9FIdAyCBg5Fvbit1I2J7434KY0OTyP9Ypsm0vlciSb4XCzTSRYc8RwxA0xIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776965034; c=relaxed/simple; bh=4GMGB4p8iCuyXlrORu3AvP0h9ZKS32L0djQtHAsgD8M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lWQoqne7zOPtNpzNSdiUHMwTZQkOPIKTsYj/tkNdxzcyHBLeGz2mw2KapNHwaBPEKhv1X1HFgN8SkfSAhtMqBCyPTpKmI5ZzmQIfoEFHsiqVwbGI2XULPERKUkhwZ3d6xlXSt/1SbjFLjvOSK29PDBZ5pqgkX5iei1AJSCaWHkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NOiwObeH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NOiwObeH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0666CC2BCC4; Thu, 23 Apr 2026 17:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776965034; bh=4GMGB4p8iCuyXlrORu3AvP0h9ZKS32L0djQtHAsgD8M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NOiwObeHUNMF+zIV4jjQLsGimaaOae+Wi33QJik/ayvcadfDcVWlGJVjECsvlQ0zH yoX/96Ex9Go05nHTEA8Avsf4smU1UZBJcU/tLX2XbQJ0g+D01TFV/Oh7p0zJnV493M l+VUHX2KzTkQyuZ2OdjHAJhfikzYwR2R0MU/ZNjKeun+fCtN47lZRp/n+C2VoO11MO Q8PHCE/MV27vmYDZdIkQxhWj28aSpsw3MGxPrunxGTk8Izhci1tBJmhukMbdNTOcev VG4CSkg/1Tp4eRxIT6NvYBX060pkaPgzmaAE8aTqetkOEEhm5M6zjvd/8J3jamZSeg v8rp3Mvs9CP7w== From: Sudeep Holla Date: Thu, 23 Apr 2026 18:22:55 +0100 Subject: [PATCH 5/8] firmware: arm_ffa: Validate framework notification payload bounds Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-ffa_fixes-v1-5-61189661affe@kernel.org> References: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> In-Reply-To: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jens Wiklander , Sudeep Holla X-Mailer: b4 0.15.2 Framework notification callbacks copy an indirect message payload out of the shared Rx buffer. Validate the reported offset and size before kmemdup() so malformed firmware data cannot drive an out-of-bounds read or an oversized allocation. Fixes: 285a5ea0f542 ("firmware: arm_ffa: Add support for handling framework notifications") Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 764cb1226182..0e030f377985 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -1469,6 +1469,7 @@ static void handle_fwk_notif_callbacks(u32 bitmap) int notify_id = 0, target; struct ffa_indirect_msg_hdr *msg; struct notifier_cb_info *cb_info = NULL; + size_t min_offset = offsetof(struct ffa_indirect_msg_hdr, uuid); /* Only one framework notification defined and supported for now */ if (!(bitmap & FRAMEWORK_NOTIFY_RX_BUFFER_FULL)) @@ -1476,6 +1477,13 @@ static void handle_fwk_notif_callbacks(u32 bitmap) scoped_guard(mutex, &drv_info->rx_lock) { msg = drv_info->rx_buffer; + if ((msg->offset != min_offset && msg->offset < sizeof(*msg)) || + msg->offset > drv_info->rxtx_bufsz || + msg->size > drv_info->rxtx_bufsz - msg->offset) { + pr_err("invalid framework notification message\n"); + goto release_rx; + } + buf = kmemdup((void *)msg + msg->offset, msg->size, GFP_KERNEL); if (!buf) goto release_rx; -- 2.43.0