From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB71A3A75B2 for ; Thu, 23 Apr 2026 17:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776965037; cv=none; b=dxFWbLlZL0THZVu5qdJlxoNEIAMzHdKJbaom2YAZmU+og/5QtfIHFHWZ/En5y6G3Rsba5CM1fYWqlA5/3gSdCKn1mJa4p8A+V6xMSYsxG1a4U+OYeJ1/QS54VisEoazr+WWB5nF8o8oQRX/Q74tdey96SYNfhnt8pEE9dRkM6Lw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776965037; c=relaxed/simple; bh=V+0omjvHArZDeRZA0oOFMICKk6VUNuVS78dDmsvofzM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fSHrbw5lh3JymgM5wIEhKzX9UgqTkBMQA2uXmZxy/KWmBIIhy9/CcHt0O6QcuH30hEfyKiPDjBXSAwaQHGjzlIGsT0N3ZXOEUqb4w3m2PYvBRhAuCygPRAXn25Hkq4TLg7AIPhPyjYLYJC/G/BVmL9rlCT1LP4nJ7hjwTuRp4T4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LS3egZBg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LS3egZBg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2956EC2BCB6; Thu, 23 Apr 2026 17:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776965036; bh=V+0omjvHArZDeRZA0oOFMICKk6VUNuVS78dDmsvofzM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LS3egZBgTB5OFnBUaH/MP9/lajAboFFr9M6afpMNDKmj6x3a69rDKhBEL7/KoSppl g1v72wT4F+wWvhc4DcArQ0hL8xbIsdjYFpG8XSJDGsXdEIZ9L/33rexytC2FdKbSSO 0/dTAQO5uK3g+aDE3TmC5ufaL4FHw/Z5gS2ZQqMpwkoKNopkbPV5So7M6Dhl8Yo0zt ezGkA6x0DVRZCQvFFueFqVcALjNh4gTyzInxioor+n7z3REJwavyDDnjWpUVT5ymro LTRWaKWtImzTg7+XXQxUG4oK1hmFAPBym/F/5DEkVO0l72KM4ihsYn5RS7dyB1fp4e jcaZzJd6luFYg== From: Sudeep Holla Date: Thu, 23 Apr 2026 18:22:57 +0100 Subject: [PATCH 7/8] firmware: arm_ffa: Fix sched-recv callback partition lookup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-ffa_fixes-v1-7-61189661affe@kernel.org> References: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> In-Reply-To: <20260423-ffa_fixes-v1-0-61189661affe@kernel.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jens Wiklander , Sudeep Holla X-Mailer: b4 0.15.2 ffa_sched_recv_cb_update() used list_for_each_entry_safe() to search for a matching partition and then tested the iterator against NULL. That is not a valid end-of-list check for circular lists and can fall through with an invalid pointer. Use a normal iterator and detect the not-found case correctly before touching the partition state. Fixes: be61da938576 ("firmware: arm_ffa: Allow multiple UUIDs per partition to register SRI callback") Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 4edb88079bac..40ade6edcf33 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -1190,7 +1190,7 @@ static int ffa_sched_recv_cb_update(struct ffa_device *dev, ffa_sched_recv_cb callback, void *cb_data, bool is_registration) { - struct ffa_dev_part_info *partition = NULL, *tmp; + struct ffa_dev_part_info *partition = NULL; struct list_head *phead; bool cb_valid; @@ -1203,11 +1203,11 @@ ffa_sched_recv_cb_update(struct ffa_device *dev, ffa_sched_recv_cb callback, return -EINVAL; } - list_for_each_entry_safe(partition, tmp, phead, node) + list_for_each_entry(partition, phead, node) if (partition->dev == dev) break; - if (!partition) { + if (&partition->node == phead) { pr_err("%s: No such partition ID 0x%x\n", __func__, dev->vm_id); return -EINVAL; } -- 2.43.0