From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61D6372ED7 for ; Thu, 23 Apr 2026 12:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945639; cv=none; b=lQemGpUf+ijKspN8QlG+JgKpvljAL/3nyCjLN4mjgjrtEtOcE02C81HPM9FAQpmOySxEqKz7zXkCMq32f7D23eKX7wcwWkjva8YMlohxl2bopEtLCPGqupKh9THFmr5oBVtxYTA8ZCVSK2s9WmlQeVb0WqoHQhI/l+pf3Fb78fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945639; c=relaxed/simple; bh=oL8lY7kTuiceRDZRaGs24VyCt20j8FzRSm6Nt5r9xZQ=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=e4viw02z4HCZL5hrchERA0xn/c3UJu9oEZrsdvwb++3s1H0T8QayKd6uXGUCcwbm4yIAYhw1P7C34s3JJOJEKucqK26Si/nOHPuzmCWkv3djQWwBJxIMePBslyiOJcLJrbrLfjbtyGEXf8dKPzVjM+2ys2HhhROL6PbJQOyfBvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WDpAuxkS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OPv0lM2C; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WDpAuxkS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OPv0lM2C" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uFRl3044112 for ; Thu, 23 Apr 2026 12:00:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=eIrHtygjWg6Sl2zjvdxf1O /+BVTjvrWFBlUr1RH7v3A=; b=WDpAuxkSGIhJqfPeId+thTzthAEyrFT1piVRAR pbo2u1NtaTDet2pk1VzY8xykbV1XIcOD6KxR78UbhPUb8jKbN85+A/RjTLykRUn2 Jm3TC2QjjTa/r0N8qXoFICA39Vy4obtJWy6FrY12JqqKpQ7l4ZBVWAfGFtjtJEC3 R6kzJZK6itCfaI3iwRzSWNB43mUHf5wvR3EtXZRctXhdOYGTSsfm/TP7ehcUSDjo sx8xDUJYFa6HNfn7tOTej1yGf6/b3TQp5VU4wzDfar6ve+LHQe1qdm4B8mRiF8aF 40mnxHJ1uI1xeEAeQeAMOdA8Pe+U67lqI251Zu2Ciz/BBHNA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1jh3ru4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:00:36 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2aad5fec175so92497665ad.2 for ; Thu, 23 Apr 2026 05:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945635; x=1777550435; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=eIrHtygjWg6Sl2zjvdxf1O/+BVTjvrWFBlUr1RH7v3A=; b=OPv0lM2CaYnAsNm1rWvW/LDD8hj6lqSH3Q79GBswt2yD0PRC+dWN2xqFLw+pJUWMeB YS5Y7SPIg+XNsMmlFPJwSYspq4VU9Y2aTzhKgl6Qg50+iqHatn+ijjSGCHYVUnAAHedA 1tn0AjczUbepWVVICDnQ2vxQCsD8NwFXJuEbUYoLGTcgkiC9HEmwfmOtmuVprNxO0Kbz /TyjDc6raniZH5gXTbRYdH4mlSAgcDHlHjlcJSkJKGVwzIrq6qHa/s2XxikzmDYd4gqW p8zCH7c7nmnChd2g67S26ffe68CzK2G1WcT8EIxircPkV/4oanSZc7dhenxVmdZBEPHw ajMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945635; x=1777550435; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eIrHtygjWg6Sl2zjvdxf1O/+BVTjvrWFBlUr1RH7v3A=; b=QORK5OvVdLfvZUDAyzufgdpqzUJ3NOUyNPni0CPRnfw5YTdVxkHB61KwzSWmfIw/hC Ef7lfDw61NaDLnU6hEvlKZpkoCmp2oV0L1Iqa1ZeiViExrxWF3BjbtqI7mkQoxcImei3 TYsGSHf7tEftEdPooYkUSeB70Vr+8jsINmbhr47BK5/zmLRVfBdz4Uq7Z/UiQ5+uoSHr LbPEKajF4brLkEqMl30oXamJkTVYpZHwgq63HJHGofZBwlDdfQXGBK2X0EkFfVOxdDgB u7CgguCYDX8+KFADrFSgk5bZKi43wr1oa+bB5FTh2kaPOSo498yYXs1UNOcsQ1maf9dV A3Uw== X-Forwarded-Encrypted: i=1; AFNElJ/yOucErcOvKZ8yRHQkCyDALOZsqzO3og8kFmM/UN5aH1Qca+G//kvvB6U3Ux2A6WCJfZ50LbaclAZRByM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyert6X55vlJE0xWc5pMfuOYWEwA9UqMAfD191+Z7ZCFMD6Xd67 lGXTDhzKpvwD4Ui/63mneMJfeZDMmf/o+lpqDVzhpOEo6TpfN/qxG7NX3I50TKhXOY9b2DMJoIp jzzKdj1Un9rYgxN6nRWvNNl4ySxTP3/j/eXmvuMueFWkHZ0a1PCYvdt+UItScID7GEPc= X-Gm-Gg: AeBDieuBnHQzOkdapKj6VPdn/LmF63Ie5j3SF699NUAD0Cw9z55MSFlaUUI4O6HHZ7b E9G+IkX4WgdTlNNYOqDpQcyY9PbO6+HIZtWCqpTI4gkg06Ps2qubuq+3EWP4+bXDHFIZqTZaAf2 f69RHCRFxg0ZM+k3+yk4NBzOzXNzFkpHwW3ULBgegLNHK0J4L+iZ+P3SPiiCp/K8dWt4N/fogoM smlaWwAReXA8xvHIp/xKMIDlHJ4Pj8euJBp0AlX5hkPczXouiY960mY43+niM2JkrJeS/Yhxcuk /6mAqfXBVXV+fTdUpbJAt1xIUPYpJGPsQALpFLVA9uMry3P0avcbeRpkn4GosrLeJ5oM5jrEr/G 9gsILA+vfh3rP4qc+75m73x5xvJzjY9mrapZjgcXXvgEZiug7OrJGOZt9MqpDwnN0TOgCRQ== X-Received: by 2002:a17:902:6bc7:b0:2b4:5ddf:24f with SMTP id d9443c01a7336-2b5f9ed21f1mr207067835ad.10.1776945635029; Thu, 23 Apr 2026 05:00:35 -0700 (PDT) X-Received: by 2002:a17:902:6bc7:b0:2b4:5ddf:24f with SMTP id d9443c01a7336-2b5f9ed21f1mr207065705ad.10.1776945632497; Thu, 23 Apr 2026 05:00:32 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:32 -0700 (PDT) From: Dikshita Agarwal Subject: [PATCH v2 0/7] media: qcom: iris: miscellaneous code-quality fixes Date: Thu, 23 Apr 2026 17:30:04 +0530 Message-Id: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAMQJ6mkC/3WNQQqDMBBFryKzbiQZVLSr3qO4kGSsA42xGRtax Ls3FbrsZuD9z3+zgVBkEjgXG0RKLBzmDHgqwE7DfCPFLjOgxkZXqBVHFmWDy4VfYkjkaV6V6Sr djabBurWQt0ukkV+H99pnnljWEN/Hm2S+6c+If4zJKK1aMrWuWkSD7hJEysdzuNvgfZkP9Pu+f wA2wVV1wQAAAA== X-Change-ID: 20260420-iris-code-improvement-19409f16258c To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=1700; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=oL8lY7kTuiceRDZRaGs24VyCt20j8FzRSm6Nt5r9xZQ=; b=6gcZwThJ9xJ7vHMnVnorb//NKP8y5g/L8dZxIsyZx7HcS+EU8+ld2iR3icdx5/IU3L6jhzKKc 8It0pNiEGTVAAPuUlA1iKeBBNnsCgntrNRnNRbttQDXbM1kkmmjQt1D X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX5dMflFATXWlq ZB8wCo1HrKVY5pUbO1CkE1vyhSaqmvqJQgTHb64MFpfKHdX9nTzKsd04IQyL60cvpKnuizJ+Ray ZYVqkA73kYDLxCdQU777FbYHZJl3bUlh/lBMXGzWr4niLCmCpv5on0zZkWxno61fCye8B9tzG1D Z4Q91oW2lgsprOp2wTH4MNpHyPZ9icFMjgcDh22ZF8Jfu1y4K+SFxqom52A2SG6IPKqTc13JxwT mfDnw7rhQRp5R4Ht7KooO9x4RTB17xfkcTGfyZ7kk5tg/z7QmpAuaoc5wOJyoxawoO2j+UPHYhZ Y/H4GZlOlKB38WUD5As+L54IWivhZDo8O9+FK668VSm7YDNoztydgRZynY5xyaPx+yvJCN7Rb7p zRnHeHczbMAylkvpuo0xz304XVuZJXTw5i7zLnnvlD0TZRpYYeZhhss1y5ndpK7R6TcUyHMk4O8 drMor+ExBS/k/5d7H3g== X-Authority-Analysis: v=2.4 cv=OeyoyBTY c=1 sm=1 tr=0 ts=69ea09e4 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Lb5j-gmOE-iAMMu9PAMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: 4cup-quanoAKs1R1IQZ9dZY1o-CyoKcn X-Proofpoint-ORIG-GUID: 4cup-quanoAKs1R1IQZ9dZY1o-CyoKcn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 This series addresses a set of independent code-quality issues found during review of the Qualcomm iris video driver. No functional changes are intended. Signed-off-by: Dikshita Agarwal --- Changes in v2: - Updated variables names for iris_get_int_buf_tbl helper (Bryan) - Removed un-necessary fixes tags (Bryan, Konrad) - Addressed other comments (Bryan, Konrad) - Link to v1: https://lore.kernel.org/r/20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com --- Dikshita Agarwal (7): media: qcom: iris: Centralize internal buffer table selection media: qcom: iris: fix state-change debug log printing stale value media: qcom: iris: Fix bitmask test in iris_allow_cmd() media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec() media: qcom: iris: Make iris_destroy_internal_buffer() return void drivers/media/platform/qcom/iris/iris_buffer.c | 123 +++++---------------- drivers/media/platform/qcom/iris/iris_buffer.h | 2 +- .../platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- .../platform/qcom/iris/iris_hfi_gen2_command.c | 7 +- .../platform/qcom/iris/iris_hfi_gen2_response.c | 4 +- drivers/media/platform/qcom/iris/iris_state.c | 4 +- 6 files changed, 40 insertions(+), 102 deletions(-) --- base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9 change-id: 20260420-iris-code-improvement-19409f16258c Best regards, -- Dikshita Agarwal