From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14EA73E92A9 for ; Thu, 23 Apr 2026 12:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945646; cv=none; b=ryvYYKS9kBBhuHtp147HqB1/7URvQ0f/sIsOlo5mkefFJGN9MpupmPDpP9jslwClOFvZowuir/iSRNMpmPuvHEODcXG2jb5XnPVIsvhTdRaxFCZn/2WRMzw7VIRrTMny3NhY8aCMOkXnjfXbg3ZgnnX8uFMJ6Bt784XZA1xfSHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945646; c=relaxed/simple; bh=i29lXDR220N9S/ZCltewSH2m1udYLebrd2wvWU1dcKI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q/61lHRqjVn1qoUZmPDldkh82wY7tDYGJrS2LpVpQY+9k/J9MlSaCSA00HDI+qsdj+jaD1Dw7Jav/NRq/K4O2Pj4GwDFEu6x2IOL1PvYofuNQ9n2HH+IYzEo55uy9lGzfYhDbJ97SWtX/DHmc+Un0Y/Fhj2JI12WkO9WvP/WSRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oopMWBFN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aXfB8S06; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oopMWBFN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aXfB8S06" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8u2nd366192 for ; Thu, 23 Apr 2026 12:00:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b2aLu8tVOEk23kPdNH5kca74rbgoKNO8p6b0S6AIX50=; b=oopMWBFNUqDHxJ1f 8s0BBoh7oQ2oUzN57gQW8Cl5ZLn7tiK8UIqUTppahGzx3BX/pudEpQ8YpdWNeNfy 9uARNbs3BpSPu23gB3ummYCXvAe6qvIX04fm9XRSEsUwkIQFPIFRL37sP1bdHhGl R9FuPxP0aMR46mdkGXkyvnmeyBvmTtyLm5VFZ0X1QCaiUFk0M3WM746Y5sAKHhDY 8jTi5cvXjibGCyFhtnYK9CO0l9ONFaako8fB0p48xdAmd+DCU3pJykGADlvsmvFL v35EyrbHwhwt3sPsfcgBn81aeJ6OHfmVmyAl2oXhkDEeIjaFjRq1duhFQo9NMUk/ IYu/bQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq35rbbur-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:00:43 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2adc527eaf5so52463035ad.0 for ; Thu, 23 Apr 2026 05:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945642; x=1777550442; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b2aLu8tVOEk23kPdNH5kca74rbgoKNO8p6b0S6AIX50=; b=aXfB8S06sdtr6af5IopjaRjbnIfmg5LEpb5X5QiLlrvR4SlLlbNeB/sy4ER8MEx7Vn cvbx1QodEObNBOMXXkmVt50g6A9xihMV1L5kAoZziW264xF4BsOw6mi0RDlutxSfH2pR TW53hSLoAeVwmD6kjcklrXqsyH3n5RS8PGI0HCsV6HXX2CiteiXlkSzraQ8I4ZxCoCXq I2CkIEvLUIjvt7V3gUO/eYuHg4heqgA0iaQI0gWTtR9bY/e4I8WwMqyh0L50O2yczWl2 hQwj/lGOlFIpx3ar/MdIDX4clhV+1CICYk18HfileZeLVB6LBvIrdftojwkJxD7ptZG2 U6KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945642; x=1777550442; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=b2aLu8tVOEk23kPdNH5kca74rbgoKNO8p6b0S6AIX50=; b=EhZlERI5ikawD9PLmcHve6TATfFsz5CgwB+zmAjH0EiuPMQcV4YRRWSR8mmZ5c+/n5 EyRrpENMr1s0JHiF6GtvELlyZiJSr2A9WbXxBAWTwM0lQq+qwKO4gBC2uf3o7PmTEaFK zog+Uxd9MFc867G5By920L8Zgb8CcGud2CC1yQRaqWC3sZwjuqp81GApQr+B4zM9BvJX C4kF/1UiykRioP/8Am2QNbepCp3ndhiCyG6yXxGTfptgFuZMJnOgrjnhN7CVOPSqyG6g fcrmEH8jA3I2E2F65dbsWIOOR2/t9JVsYjmDRpvfqCdEOw+vzmEa4SmJD57bU7nPxlfu dJ6g== X-Forwarded-Encrypted: i=1; AFNElJ8uNUkoteLR9DzM+kmCJf15g7JXvtbyQQZVgDCrfmOd//IVUkh97Mpnf7pS8LduM4Jh5HWQGIiCm3C8pvk=@vger.kernel.org X-Gm-Message-State: AOJu0YyB/5mJAvbj2ij5+5DBZx01C2VPS6IsBZxiGGhNM/exdyoE7e01 NyqtBrAzdB7qQyl2/zt+W/YM+PT6e1d/N+WO/Dg8B30WCiQ6GJMmxjzQ8fIVOAs8k7pod/XwfV8 0o1T9Hw8mhWrUPKbql/7TEIn/zyPDtpfa6gac1XnwVEMMIZcrsm1CD3tmDi3j2b4NtVs= X-Gm-Gg: AeBDieuL8SpsKvP8TWpFH+XfWDxC3tXThmDMZ2DVytyOUiw6oSV/snCgJ9mLuMZwaux N0rITya8uOFfC0DvsL+IomC2srTsGPUj9NWGsQm5hZ6pMYpa8sXiDVQTdXMoHCSVACJY8LZmk9i 90XV7fcn53YqJuPZZrGZkQ71Tfpey27CzAs3DRLwBzHuvEjA4fUyEy/iobgwhTL6pP8kbtg13G3 dhDKOVCa+ZNkvnCjLUMGIbD2J13nc6m3X8y/K+sZZN4u8ed6buiaBC3fnhYU8uwpH7iwDYDNMf1 ohzAhomUZ2G6R29qadY14V8PDW5S/jmn5KU2YtCJswdgxDFVkpGjE3ET+Td/RkekDwC+HZMoFGy hT8gT8bGOU/bYFgVjRoxIsXQ8+o3DO1at6ZGSnGtNI3sJ5YcOEBPSbFuedG1lDpv+jOW+Bw== X-Received: by 2002:a17:903:1b6f:b0:2b2:4cd2:e16c with SMTP id d9443c01a7336-2b5f9f3c58amr256862115ad.20.1776945642436; Thu, 23 Apr 2026 05:00:42 -0700 (PDT) X-Received: by 2002:a17:903:1b6f:b0:2b2:4cd2:e16c with SMTP id d9443c01a7336-2b5f9f3c58amr256861585ad.20.1776945641792; Thu, 23 Apr 2026 05:00:41 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:41 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:06 +0530 Subject: [PATCH v2 2/7] media: qcom: iris: fix state-change debug log printing stale value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260423-iris-code-improvement-v2-2-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=1339; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=i29lXDR220N9S/ZCltewSH2m1udYLebrd2wvWU1dcKI=; b=xeE+GZHhbHPYXGZ//YHmYFmemxBp85msmf6bNdSFq+mGc775eeXFdc8EWaFwwrGuU+8PW8+AD M/Mxj15Vd/iBIYFYMzdZWoX1K90Lp3POzb6/M6QHD2vAM7VGuVVHeuK X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX788EbUaVO8t2 Acf/LBIrQP1DNyLCoZFtbpEBGPPYPa1Od12/auNOfV6iw9JyEuMZG8O3hkyy6d8jLuqRBaDsaui otPobG+yX6dt7MAl+kR9/UAQbkwJMZnFzBmf1XD8JTcqaZXpUGaiFFn8o1kcRjT3JoCovFRqnkG whxCwSvUPxAP7Bxn8/AsM2u5E6p+AVyWN22e0SzjiRfcdAfCxlQqSbDeVNwYC+VTzIL5X+qx2Sp oEdFrHMCy/MK8xnI3tGK9cy1nRq4IQ7tFWNAsfzB2saa3dIazay4PhwSiGQVXewDmArgIpcidyi qZLOYobz867YHbuyc0EIkVGYauc1WukE861d9xXAxiVB7BG2TyY1H0T/gfHQSsXoMJYGbzoVzV+ xdFzCKuoJGM5Fe0KRlAQoniPczNmPDSWtvAbFIaZtZObiZIioVO06IA+53kz//nrtfuGYsHDawP U4suEGIJNJUG3TQQfMQ== X-Proofpoint-ORIG-GUID: m9FAU3w-zYqhfTCBmWwJVynXxzaFaObG X-Proofpoint-GUID: m9FAU3w-zYqhfTCBmWwJVynXxzaFaObG X-Authority-Analysis: v=2.4 cv=f5J4wuyM c=1 sm=1 tr=0 ts=69ea09eb cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=xFg6UwmA3-Dp8VzUGb0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 The state‑change debug log in iris_inst_change_state() always prints the same value for the old and new state, rendering it useless for debugging. This happens because the state is updated before the log is emitted. Log the transition before updating the state so the previous value is preserved, consistent with the existing sub‑state handling. Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c index d14472414750dc7edc4834f32a51f2c5adc3762e..e991f34916ec6e74f3d2cf98bd61b8b1e12a3ca8 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst, return -EINVAL; change_state: - inst->state = request_state; dev_dbg(inst->core->dev, "state changed from %x to %x\n", inst->state, request_state); + inst->state = request_state; return 0; } -- 2.34.1