From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 821883EBF37 for ; Thu, 23 Apr 2026 12:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945650; cv=none; b=u1QY82gqRnLy6H03XwOxvz4jglPjKKgtT1Tz3MshypKRw/7sF3nvImtgnkAQmFpMpuKKuTq5dYhUxGBe5IZO4xNJRiifbw0F8ASJjgdiW836O0iswuM2XOkll8m3zpTvMF/ER6Uhq1rBB41FzrmcW+PQdhOvJ69C7onLoziF2a0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945650; c=relaxed/simple; bh=YmQXvtkYvIze5TqdErB6gc5at7BcNjGJMakZ7uOJLvU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BhXoQuWZjovKe47Tcid/57g3BmrRoYMSqXQeSqrk3jaHit+Bd/RAl/bjLUasj/e1dzcGUZtYQ6spo1CNC+2nZudRdRG+BXDdOZ1YLVGfNztusurGBVIvwuKZHSr6aQQQzDgwnoi2CcAB8ZFSjYO59jBp9QcJQhWNlNAaHGwURi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UDMbyINx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JTnS2v8p; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UDMbyINx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JTnS2v8p" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uEP53044072 for ; Thu, 23 Apr 2026 12:00:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R8N1jbkdytVOL6T6kzcN2pMzXZVTuqMNODxZcTrhm10=; b=UDMbyINxPeKxhxPJ 8zWcK6eiU9XewZV4cKRGdj5Y2heZwa9MLKo8tx7pPXJjKi7vVRPdNQYNDvOVE4as fWnij5yUeW4XMv/u/Buiw4cNI55dWYUiN2wr9Qya4agR1QkmY4NnnNpnMBJ3DWft D5QEz6LV+74dRcSFu7giAOWXWE8qx4L98FIzMYmFr+Rtwj4jesJblMF52Zf3IiXx i0uB63dunLAFzjU5F3xjBCkx21Tp4teEUqLL6ELzhqpYWWIZyYrbFqgJvFvdkb8Z WFmMpdQ4y0/7LQrty9TO0YKM5DTbS89o8Mik0OPklC8AfGksx4qz2sjxZMK1AZMf WDK/hA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1jh3rva-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:00:48 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b4654f9bb6so69230585ad.2 for ; Thu, 23 Apr 2026 05:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945647; x=1777550447; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=R8N1jbkdytVOL6T6kzcN2pMzXZVTuqMNODxZcTrhm10=; b=JTnS2v8pWLI9OUdSmM2ECqOA5Vt5bL9+q3JApodDs7/8LJyXkHNo7Z5YZ1Zy9lgzp6 vyypNf8BjaDViYpMl4zntvhhO2Y26pDjxfm8xEykGXG8QuLTv3TA7sNgKkRU18H5QSQs yI5q0tANqRggiQuko+ywF9v9qBfzYlyYBuhwH49J7oiT7KBhffCkJ/5KexX1rGYS2l09 LWUp3iZ+zsIyqSjFF41RIFwjBHgVMXSicFqLt1yUrHWiv+sz4mF1QXrwUGuIZZ88qocl sdt4g8YGc0sM9j+yoSiBs2BMlGGreWvSnNbHlJppUS9LWhmaITYL1Haa3WNm9rl1XqW9 yKGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945647; x=1777550447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R8N1jbkdytVOL6T6kzcN2pMzXZVTuqMNODxZcTrhm10=; b=PZiaM8NmMuLOYGH/Erqz8+f7utgWVj3Uf7ZQSnYlsHcVZs/gmfEq9ngbhIo+svPHvS oDlY0QmeLLJNGgAr/bnMhsmCMSbEVSu7AjURav7+p+WkFyKEq19pk1bx+vWMlxIE+K0l XfrDT6NDtQfUJHDqgItckBb8yqmLR34CfjpM3WR7w1dV/qJq5i/KBrKSCVNi+lwDC1KR a3JUNNEqxZTxlG14R7XBLq70ujIcPRLyDtuhTyKxcRj/lUvMRnc0+H57USsyA0RZpgQy /YXeHfOkZH+EpKv0oomAr6YPAr05m1lZTiM2sBXbIJsc8QOBjmhfxPvhPrnYcoMKjllk g/Hg== X-Forwarded-Encrypted: i=1; AFNElJ/Yjnb0rwst2OoXoBoP/vMKnpTuLVAFg1JbTewNITYNhXARC7hb1BfiYtTRqzdDRwdZD2m1IciiphQftY8=@vger.kernel.org X-Gm-Message-State: AOJu0YxigPquQ2klkzVxzFPXu+9LUOlpW9kEWDZsmue5pj1t17d1hEIX ZsgtWCLowvH5W/Tod9ugTkIqc7Cif1YY6inqx203S/QtdNXdOH486WeQuTyDyEg1NamJLBZiXsB NNHV6DKbx7y6WkBgiQCKHKO8nc0KmO7eKnXRJHeEJCLvtfwkPgjGOss/W05AJXxuqHDo= X-Gm-Gg: AeBDievv6YJO5voby3zHWgInmye6TK65Ge1M/E2/S46nAI1M0iTT4lTSYwtrHGwYyJN Q0BkEmhgxNuP6RMPjZ3blVePNm6w91dg1GYv+8qtOodMEZK93SJbWi1dGnlS7DlP6bBQXogxwjq +7NB5e3nPgw//8AHoju6wbOTBrC9ZfC+32If+LXao8s5Kmd1y2mBXcWxFh4QFMyyk7xC4lukghW IlO1NFZpTaoGsg2tAVkeixEwOCrRCCBIWa3GiBtDu190rbwXDX9UUZb93GURmOWyB3HB/ke/NBr zg5uckL6mFEQAoB/Jd9L0OWTMvzLp4Bj0GFViTgxa6IHNDCA4eHonl8fsMklQPx94V1vG7mxSFV /KgJGXSy9erESrJeCSfu3ibizgaCce2JIMZr1WTI1xNDH81ywgX2yK7WPIRkmIjMvZBz3TA== X-Received: by 2002:a17:903:b8f:b0:2b2:5857:583e with SMTP id d9443c01a7336-2b5f9fc0641mr279156765ad.31.1776945647182; Thu, 23 Apr 2026 05:00:47 -0700 (PDT) X-Received: by 2002:a17:903:b8f:b0:2b2:5857:583e with SMTP id d9443c01a7336-2b5f9fc0641mr279156065ad.31.1776945646343; Thu, 23 Apr 2026 05:00:46 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:45 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:07 +0530 Subject: [PATCH v2 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260423-iris-code-improvement-v2-3-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=1245; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=YmQXvtkYvIze5TqdErB6gc5at7BcNjGJMakZ7uOJLvU=; b=CicWEKM32YbJeZj+8rDmclj4jgAMm2g2Xo00NlYwdv1tBeeNIwPsJ3PubdoF/sp2WdCF/ufXi jwKsVsGl7vmDJ2kHFB58jS90/aSacL9BuxKJ7RuYxx2jMDGvSAYPwTB X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX1DcDVik593cw INBm1ydlpWznNYRr6OrjEKWflx3bh70v7JKWcRaTTGBeBsAKfGkupMbt8qgjbvlHFb677N5f2yf q/+v5hXF5isCCY42Bghxfcw//ivUW9ULJiLRxAKz8LvyhFuxvKI89xmSIzCgjlcR6s2ugZGIuqm lvuxVuQnhXvDUff1To0/avDdX/QvfVrM+7I4qzv2+SLWBAZJfidsT5+HvvT97FDeZD73KOUBOxr cKS3mgxWp2K9FGlrwhDNHJDcDo5so6i5Gxt0+iblulegOJyUqJYEX+tw44VWdwXh1G9wHY9U4cp dtZExRxXiKPLsGl+thBmTeV2phIbw1oLsKpN9K9EgIHahBHK/1RCQiQ5xakNIF4hErr5rHdJTt1 s83yWojdUGtTeyE4rCA/WkKEWHcRr8HFam53Da+Nun2V7jS8aoHLMqgIz/n5UZHVTb5FCTJARpX Bio5uhu9cOh1bqJ+28A== X-Authority-Analysis: v=2.4 cv=OeyoyBTY c=1 sm=1 tr=0 ts=69ea09f0 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=cLE5npzMka_F6uTWaO8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: YDR3WA2z9kZ9FSgt0Q5EiMzMN98PIZwQ X-Proofpoint-ORIG-GUID: YDR3WA2z9kZ9FSgt0Q5EiMzMN98PIZwQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 iris_allow_cmd() incorrectly checks a sub‑state flag using a logical equality comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c index e991f34916ec6e74f3d2cf98bd61b8b1e12a3ca8..5552725c614ea2e336e254898270302fafa646c3 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd == V4L2_DEC_CMD_STOP || cmd == V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state != IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } -- 2.34.1