From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97D4B3BD25A for ; Thu, 23 Apr 2026 12:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945672; cv=none; b=hcZXmza593XpXYfcurInfDkiwmSSYOwDT8IHRDWM0S7jfBqGFmERiN9ZDQyDApHPOgS3kmAovw3GC7Y4k16fsHHZYflTCD09CQTK6Hma10pl/ldsVjDZCFNeAnaNv6o5jomafWq+9yESo0bSHpAnVIMdnGVRbl9B/aXPD3wteoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945672; c=relaxed/simple; bh=LYwZO2ou7DHYoL0tkPw/Y4um6kGHBm+U1RyH6lTuf80=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QuIV5PPhj/Hp01kVskb7XIUcm6lsGhvItS4yjlYMJFqiY2ErNuvKOTVaM41LGW0HUWZgcDcfCKKpTv2W5hBFkpqkIEsgT7WFIVdsbCP9dURxd9T+qQXIBUKcsYACd8Ozdz3hAHjdaIlNbn9pAqf9E4Hf79iGVHss8AAFRf52HB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PlsvOcNe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BBtZeE/7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PlsvOcNe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BBtZeE/7" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N94gQh2319297 for ; Thu, 23 Apr 2026 12:01:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hWNO4fG1aSCsYkc2wD8k8eSJ2NDKUAaIuJR5mkEx0AQ=; b=PlsvOcNeaEt6+Dfn heTGZZ/VEa7JQbMn3n9B1NLOrNkNknje4NDKuUEbpHpZh3myvSVAtpq5RfLXi2oC qkxp7gi+yzlUbxKLwgjrvXDKkcCSAkhIDf1Pi0zuckniZeZ6Pk3lxRx8lQLNAPYK oPo/hbnBB7F3u1gnnlZoqGPVKeNJvA9/OUc+PlC529DwJo2D/gsKE56CRY+e22o5 4cMw8Lg9cD/RDpbirtkJvwZIMFNGfYqhMI1EQ80bQ0RkME8A3IGOwooCuthaJods RAaN1S/ueSOcnEJrHa1qFuQc9xGyfpXSplma5QBAffCGNZU5aeA14aU2VzbkZJz1 Bz+lRQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqgfsrq4p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:01:10 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b24e9b4d82so68146235ad.1 for ; Thu, 23 Apr 2026 05:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945670; x=1777550470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hWNO4fG1aSCsYkc2wD8k8eSJ2NDKUAaIuJR5mkEx0AQ=; b=BBtZeE/70lBkFNzFPxaeuoK9qsyYcrA9F9nMffWSyCssQv1D5rfc3hQfvh6dqQLZGx L6bytkBFwsClCGpDSx5OODUd8+RwPv9Q/8l/T1H/M0vYq/1cdBAcX0zi6Or0QO/Rd+sf cZPh4I2BwxUdLZFNCVeIZXaRc/PJizkE2odyM/E/qJXyVJ9Niaq7q8+i5+hDPSxZY5BI OTw7hbC3tI1ABbWIUtA+2Gqp1AicrCRtFHgUnwQTL/Hy1BOdXOL3Dcb7LGbLbEuAEVjp 6eog6aW+fVQ4v1I7vXhBOJ7wzbqfalCCl7p9z5cYxCaxnI6n5QLCknZOxreONsi9nBYA IlOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945670; x=1777550470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hWNO4fG1aSCsYkc2wD8k8eSJ2NDKUAaIuJR5mkEx0AQ=; b=tVYnTRuIVGoLqG3HU+JH5uouFZKcwlaY4TCZlTyAqInXt9rIT+NROCSWT6QAt1qg6G b3M2/040GVICzz/nFjTRc9ArWnOIXME2kfXLsxdC3vBMz5y4pLhnpnNrvuKsjRGl8QUC q7+6lBi7Bg8hscV0wPXr5pijeRZWtCOrpLpNtm8Zdi+UXnMo56qIt32jrBKQ6SD4ZV3o NJ2DmxrP2gytf0s7VwosPFDgQ0s1sKLh+lHl98NBkINPb6tl3nr68PcwbUktu8zuzUjU coW/PHsakYBnF7FwsyBP/E3p+dsKyrTzEQeYXO7+dYhl5+mXrj/jp3S8LDhbeMSRSLVO zO8g== X-Forwarded-Encrypted: i=1; AFNElJ9ZxhfHq7oKejWVq2YNORyB+SbcprF3nuBMMOb/1OozeTGwOQQBb3yTp8tT9+C1oIet9vNUnZLzKX+QPb0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6wbLrUBRRvC6FgUjtUG5OV/12sBNcTMwMFR+OReTCUgI9umbU zGzRvECp0Rg1aSaesaJ6uF7P9UnLAfD7UhWdyGjhWY8wFowDOviNtncRVDMYx8f5osMXipDSMvV IGR1GLwcSU0ROxZtJbJjzZE/eIqUuiEhIjP7BX8/s3RTGUfVA34CbxG7EePScxH0gqwY= X-Gm-Gg: AeBDietfO2G6LwYuK+n1V5QSN4Lxr1Br01LacH/SJqbBFyPnWbti1W7/NVCBHMjJ1lH RYkEc8J0egQBUSLZl0HsmORuKxi1lEzm1nsX5714aYTscV9FgI4LBAV3Y7Unqcc9iN2SpHvyaPF SmZEhwI+9ocXYPdvZBdAJz4BWWIMDMfNezBUtsOGVO8ipRBLXiOtCjQKLRRL7a1y2mtpgcPAClV dAmuip+XR9vR6BEvBDqUlhvP0Vau9+C3qA+VbMx8Yt9YJ7jCQN5mxUSDzaJBkgmK46YmGFTQFOM Aioo4Z23OTls+EjIi6jmcJvJG0CqpkEUOs6ceIXTWTVXK9PXDDWtgtvOSdksulb/Xeycch1tIct PNoNjx70w8F7kfyWc+vWcfKz8F/J8uPdemX5NaBAcZfxsbeSPSUWK4QJw9kyW9VHbPgdEnA== X-Received: by 2002:a17:903:1b2b:b0:2b4:6529:7b9e with SMTP id d9443c01a7336-2b5f9e145a1mr234983095ad.12.1776945666119; Thu, 23 Apr 2026 05:01:06 -0700 (PDT) X-Received: by 2002:a17:903:1b2b:b0:2b4:6529:7b9e with SMTP id d9443c01a7336-2b5f9e145a1mr234982205ad.12.1776945665189; Thu, 23 Apr 2026 05:01:05 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:01:04 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:11 +0530 Subject: [PATCH v2 7/7] media: qcom: iris: Make iris_destroy_internal_buffer() return void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-iris-code-improvement-v2-7-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=5224; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=LYwZO2ou7DHYoL0tkPw/Y4um6kGHBm+U1RyH6lTuf80=; b=qzoPRQI/vaFBWmkZPwEdPm0gCzC09Q59QxumJrDtGj3tXtxfoNmW5MbOElbqB9qLWbvXmRhB5 zwldabj57WUAfkuajHVH7IrxR/TrOtu0m4OCRLqOYkcW21gFhOBEAhb X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: QckH17aKaHUkyBrje1vJ-SBfr1MWyIXe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX65XC1lCs2I4M LRZjQc85Gj9Bmgt4HFKLPb19YfeYjoQGMVVmVWGHiTDHJ/H7p0Hekwwqg6+uvyrQadVXAOvSc9w /R7wP4LrJmHc4cQX/VeIsgDvYyYu/5zxhnP9OaelpC/1V5tA3jQcELVoQYVC4Z+IfM6hMGzqxty 4QvuwqI+FLst2OnsfdfrBpUwPGc0xvZoRpV++Sd65y0e319ztiM8E4ZFPJ55NfBCLWd478SaZKd pZFzi9mWFL8YNljE7jgfZPNkbfmsEeo9V4odTJh685+1gNl1Lctat2dqqiBNyUQl4juNOW0bqus gVitoZ59a1DAK4iSS3Dji4W93rS1c2U7wiDqmZRuM5ss/6em4sXaMvwSWu/6cqiHURd4BJUpvGJ 9hAaUSYG45jv/KccldidbQqsGas3juo8yQ7wBr/2Kt9e87lYamExFRiFWatOcRc9HxXc+qwNd+y JafKDD2QXf1H5qIDQqg== X-Authority-Analysis: v=2.4 cv=AvbeGu9P c=1 sm=1 tr=0 ts=69ea0a06 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=CWBAsx5YQZKXPYp8bPkA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: QckH17aKaHUkyBrje1vJ-SBfr1MWyIXe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 iris_destroy_internal_buffer() is guaranteed to succeed and never reports an error. Returning an int is misleading and forces callers to handle a meaningless status value. Convert it to return void to match its behavior and simplify callers. Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_buffer.c | 16 ++++------------ drivers/media/platform/qcom/iris/iris_buffer.h | 2 +- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 4 +++- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c index 5b31c511da6e735943e2561683016cb9414d760c..390a48d8cf788e17760f901a6a073c5b9e5a9dc9 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -455,7 +455,7 @@ int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane) return 0; } -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffer *buffer) +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffer *buffer) { struct iris_core *core = inst->core; @@ -463,8 +463,6 @@ int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffer *buf dma_free_attrs(core->dev, buffer->buffer_size, buffer->kvaddr, buffer->device_addr, buffer->dma_attrs); kfree(buffer); - - return 0; } static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane, bool force) @@ -473,7 +471,6 @@ static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane, bool struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; - int ret; iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); @@ -488,9 +485,7 @@ static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane, bool if (!force && buf->attr & BUF_ATTR_QUEUED) continue; - ret = iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; + iris_destroy_internal_buffer(inst, buf); } } @@ -500,11 +495,8 @@ static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane, bool else buffers = &inst->buffers[BUF_ARP]; - list_for_each_entry_safe(buf, next, &buffers->list, list) { - ret = iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; - } + list_for_each_entry_safe(buf, next, &buffers->list, list) + iris_destroy_internal_buffer(inst, buf); } return 0; diff --git a/drivers/media/platform/qcom/iris/iris_buffer.h b/drivers/media/platform/qcom/iris/iris_buffer.h index 75bb767761824c4c02e0df9b765896cc093be333..ab8e5d953101a786ade20540ee3c3ed226160cbe 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.h +++ b/drivers/media/platform/qcom/iris/iris_buffer.h @@ -112,7 +112,7 @@ void iris_get_internal_buffers(struct iris_inst *inst, u32 plane); int iris_create_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_deferred_buffers(struct iris_inst *inst, enum iris_buffer_type buffer_type); -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffer *buffer); +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffer *buffer); int iris_destroy_all_internal_buffers(struct iris_inst *inst, u32 plane); int iris_destroy_dequeued_internal_buffers(struct iris_inst *inst, u32 plane); int iris_alloc_and_queue_persist_bufs(struct iris_inst *inst, enum iris_buffer_type buf_type); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c index e42d17653c2c37f526e6b26c6e29cc45ae29a747..d1114e5ce7788c5e803ac7aec505a6115997eb27 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -442,7 +442,7 @@ static int iris_hfi_gen1_session_unset_buffers(struct iris_inst *inst, struct ir ret = iris_wait_for_session_response(inst, false); if (!ret) - ret = iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); exit: kfree(pkt); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c index 8e19f61bbbf9e427f658471b4502bedb1ad5f616..f5c342f4c926a68b2017006a3c1cfbb251605ae0 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c @@ -447,7 +447,9 @@ static int iris_hfi_gen2_handle_release_internal_buffer(struct iris_inst *inst, buf->attr &= ~BUF_ATTR_QUEUED; - return iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); + + return 0; } static int iris_hfi_gen2_handle_session_stop(struct iris_inst *inst, -- 2.34.1