public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: YangWencheng <east.moutain.yang@gmail.com>
To: dave.hansen@linux.intel.com, srutherford@google.com
Cc: YangWencheng <east.moutain.yang@gmail.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Pankaj Gupta <pankaj.gupta@amd.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] x86/sev: Fix potential sign extension in amd_enc_status_change_finish()
Date: Thu, 23 Apr 2026 10:10:33 +0800	[thread overview]
Message-ID: <20260423021033.147975-1-east.moutain.yang@gmail.com> (raw)

When npages (int) is left-shifted by PAGE_SHIFT to calculate the size
in bytes, the operation is performed on a signed integer. If npages is
large enough, this can cause:

  1. Signed integer overflow (undefined behavior per C standard)
  2. Sign extension when the result is promoted to unsigned long for
     the enc_dec_hypercall() parameter

Cast npages to unsigned long before the shift to ensure:
  - The shift operation uses unsigned arithmetic
  - No sign extension occurs during parameter promotion
  - Correct size calculation for large page counts (>2^19 pages on 32-bit)

This is a defensive fix; in practice, npages values are typically small,
but the cast ensures correctness for edge cases and silences potential
compiler warnings with -Wshift-overflow or -Wsign-conversion.

Fixes: ac3f9c9f1b37 (x86/sev: Make enc_dec_hypercall() accept a size instead of npages)
Signed-off-by: YangWencheng <east.moutain.yang@gmail.com>
---
 arch/x86/mm/mem_encrypt_amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c
index 2f8c32173972..8134fb731a21 100644
--- a/arch/x86/mm/mem_encrypt_amd.c
+++ b/arch/x86/mm/mem_encrypt_amd.c
@@ -306,7 +306,7 @@ static int amd_enc_status_change_finish(unsigned long vaddr, int npages, bool en
 		snp_set_memory_private(vaddr, npages);
 
 	if (!cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
-		enc_dec_hypercall(vaddr, npages << PAGE_SHIFT, enc);
+		enc_dec_hypercall(vaddr, (unsigned long)npages << PAGE_SHIFT, enc);
 
 	return 0;
 }
-- 
2.43.0


             reply	other threads:[~2026-04-23  2:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23  2:10 YangWencheng [this message]
2026-04-23 17:07 ` [PATCH 1/1] x86/sev: Fix potential sign extension in amd_enc_status_change_finish() Dave Hansen
2026-04-27  2:39   ` Wencheng Yang
  -- strict thread matches above, loose matches on Subject: below --
2026-04-19 10:03 YangWencheng
2026-04-19  9:37 YangWencheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260423021033.147975-1-east.moutain.yang@gmail.com \
    --to=east.moutain.yang@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pankaj.gupta@amd.com \
    --cc=peterz@infradead.org \
    --cc=srutherford@google.com \
    --cc=tglx@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox