From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B51E3E5EFA for ; Thu, 23 Apr 2026 09:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776938286; cv=none; b=MEseAeaYkDDIssuZ5qH3Jdh69MKOs0XGJIvGPAae4mUywoOwDY1ZbhNz25n7yHHs6wua3aYQq/zyyOgCXeeNgv0OXYkGQfJCuU5e75OC/zDHS9ZbfYfxxmxFuWgfx0Xaj74oTY/Nba2mNYG7DOvxu9A5eGUAuVobLqg7vL1O3hg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776938286; c=relaxed/simple; bh=4i2Pu3zqHhqY1LVrkEfbhdWbJY1ci5ulbDDwmXTHKi0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qo47+p5IdcOL0MqYN19zHblNI1SziVKD76eLLtETU4njBpbGrmT6LhBdspyluv9rAtIarqJZw26uGSaIPUGvdGCOg0WW+6UMmskZlSJ4whwZ7MTACcGrIYvBEoECZwAMUbjr74axRmAdpPPnzUk9yt0R/G/HAPIe7UautI/mQPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jk05PlEY; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jk05PlEY" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-83178c0f29cso186598b3a.0 for ; Thu, 23 Apr 2026 02:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776938284; x=1777543084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NxBjZOu7EvKRw2hJBLsj/m/4rWdIwz7qwQtkDCYo8So=; b=Jk05PlEY7DuwimoxqJ8MNy4SY0nbzTNJvlf6+BLLYYGJyxcc7tjYU0sFI7pIMcuCjP PHuDwn+6TwgZI9moCnQYS7FyWG4ch8FvLhn1RZtCLoSXUCybAIy8pIm3D7TeJ7yo1dgT js+XMDnSHtT2/S+MY2gHaZZ7tR6HTGBk/j+/+F+74lJcBig0qFVAm9rWewLXkUxc+64E VkXLac/UPcvbK14rqXWF+LHGF8icO9XXqRGZr0RLWbNpn5mI7NRLjA3VAGK4r5BcZJzc nniJzepkjmd00Nc16BQP5TWqTbr6KHic6pYWLXbb00d1a+IfrafObtQf1it0iYl5M5n3 5g6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776938284; x=1777543084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NxBjZOu7EvKRw2hJBLsj/m/4rWdIwz7qwQtkDCYo8So=; b=iVKo0gC8P79Y4VF2pReoTaoHE1qmza6t2Yq2tjO43EZ5rL4e+GbJPeqxONgGsLtSHl 2C73OLCGj387WcdmO8ltbFzg/UkvXl8O8/M6TN3+uOhYrUm8oHehuGt7YKhHv/k/DGK5 XB040Cwj8ID/S6LSjLS31jS9iMKQT7RSIYQeSCMqL7iuP30uOS/htQms+H55pcvkcfko /WXKVa5X2qpaE9UKYhPkLRtJ3iMxEucRZIMeF8A8LzQKmVH04Eb1PfsX1qafmdqkTX1d sjKgmkRddU5m1Bj6i9UYOhHNZpkdTnzbg/CEbeAb7ZAvDoJOraoOP2RJn/5fGJOa4OK1 QfPQ== X-Forwarded-Encrypted: i=1; AFNElJ9GbxReLdFeBEc2Ahd9N6sdidDPdCdTsyJCHNU9wBpRq3zKFm/ISabwqUBqJIC3ekjclq0Od7ex+38jRdY=@vger.kernel.org X-Gm-Message-State: AOJu0YylsF3BXkq+vEiocJBCZZJq41qYp/vCX8Z7Vo91CmKZBwqvSDFU gEedCEWvB6UDoifRUzFDa/nTKBYEusKrwU08mnMIoKlAqq5O5BFkm3JCbi317RYnEwU= X-Gm-Gg: AeBDievXhjQO4BwQQ5/ZXcr36QOld2qN4F5WQUnKVx5pz9qfR++4Tx6kQ7eQopv6Xil 90QgzrM6cJQ2VBG7WObcva5hD3Yw37qCuXyXaxoVr4FpPV/c/VJ0tXeFUHCjBeMh261XI4x76xY y13NzggWsU35/4XxKIlB5xeIh6dEgu0uWByi0EgztECAcyYikiPy2LZ8lUrBRb+v2Nh4+X50fGL acKjvJ4H1fO+N+RgQ1ryTxtpgVF2KqCGGKXa2mFTAg5sC8/Yp57BYngcqNJeASUB+8m1SdO2e3E LhwUKFSICPcBYci2FGp05WphTpZBCA4+1Vbl0z560r54LBi8a0TbzG9MtZZK6gY7+RG7tY2EjX6 Ux0r6N2/X56kdOmLjNMqcc6LANw33W0nO1OyQCsO1C7FoUDw7pbQDbaua0wtwww2pyAXMj3qwG/ bZ1s2zGuxJ+uJJViirI0Lj7aCsgjVC1S1mnCjjyHzKMutWAG8v4BVv X-Received: by 2002:a05:6a00:2341:b0:82f:6b64:1b0d with SMTP id d2e1a72fcca58-82f8c83446bmr29344689b3a.17.1776938284480; Thu, 23 Apr 2026 02:58:04 -0700 (PDT) Received: from teatimelab.tailcd024.ts.net ([148.135.103.3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e981a0asm20542313b3a.3.2026.04.23.02.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 02:58:04 -0700 (PDT) From: Qi Tang To: Paolo Abeni Cc: "David S . Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ipv6: validate extension header length before copying to cmsg Date: Thu, 23 Apr 2026 17:57:53 +0800 Message-ID: <20260423095753.3648669-1-tpluszz77@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <01e90b44-88c8-4e29-86db-b9258d8271b2@redhat.com> References: <01e90b44-88c8-4e29-86db-b9258d8271b2@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, Apr 23, 2026, Paolo Abeni wrote: > The patch looks functionally correct to me, but the above 3 statements > are repeated multiple times. You can put them in a local helper and > avoud a lot of duplicate code. I actually considered that first, but went with per-site replication in v1 to keep the diff minimal for backporting. A local helper is definitely the better approach though. Will do that for v2. > The packet is corrupted, allowing processing of later rxopt requires the > IMHO not nice empty label. I think it would be better just returning > from this function. Makes sense. Will return directly in v2. Thanks for the review. Qi