From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC36B37B028 for ; Thu, 23 Apr 2026 10:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939207; cv=none; b=tbUAk92yHtzfCJ5FZD4RbREbYWWOMCAIKfOBMKNmISYHbkC+6FO151WCsUQOp/ngNtMPlmj/SIQm2GPo3wCOCr6MyHNau6ge96axpGF2TPuSLfFEhRURv6xm5YiOKj81M5f5+VPCzykT3iGEYPQ0TdH6obUKcz8jnXinVXcxl68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939207; c=relaxed/simple; bh=EZFMmfcPHnnPRRl1qIvsTma60zQYclkMF5a2PdQBHRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ADMoTUD/LqCZCINdYN/12Qe2c8N8YyOR2t4BBXqVbdx1aPT8QwDNkwueZeVtYwdEAPnmpe5BFKgItZ5eus7El9GvsPzDui+y58Rbdr/3CS2D/MGBK848jQav997iczQQ6qe+S7Zg0d7d4DFTZEW3ObQiYqj2kR3DJY7P5RBY9ow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gGJFdFHJ; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gGJFdFHJ" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43cfde3c3f3so6644515f8f.3 for ; Thu, 23 Apr 2026 03:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776939203; x=1777544003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NQFI/pBHIyp1CLRqL7clSduoa3aCGTrnoSWGD/QtaJY=; b=gGJFdFHJGTABVl82ALeMDHt5TxDouVE5CsmtRQflA1HEzSrUCq05/VmrZC1vJZyCGK yamPgjg6RDySzwN9qerkeaxO4jHc8Z51S9qFhMANYtT+XjmL9eNmu8EN5apyBMdCzydK xoD5tei3qrWMKOv0hQBtKLEdpzTULVSIoTON0xGJMkEnI1RqHGokLiM9vIfybHDbf10D v2meImDZCiAKTpdU2n3o4DBlhCNBrAR8UfnC/kKg+IKaBH50Xn5oxZ4lOSLy81SQRSYk eDabX4dBuvzGgSDKjtxy1F8pkrLJSVgQsnR2afUCpsJY0sPDeVP6U0Udhl75wCybblVz u8MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776939203; x=1777544003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NQFI/pBHIyp1CLRqL7clSduoa3aCGTrnoSWGD/QtaJY=; b=LEGb1dM3bWdPO0mMrcO+o3idOpdgN4b44t0mmpoqPdE1LobPHTgfkHtLH2/GBmba/Z r2z5se50oZMpWhOJ8+thNGEK98TJO0S7ax6ozy68GXHH6cFsQHOSgfPK2BSjOt1tjtFD EVEPj6IJclkblI4j8upxvSh3RGC5F6YG4g9WNU8C3xAjbPbw6J3mOxs/IrMYBcq1THgL oKbiP4Jq0kHOtI7CXkfkje7J2qWZdCMBXyFhn/MpTBadIjJgPcmPDCMEnD+tXqtBW+rG wKtP5IjonTQ+315JjLRcIL8YqIk2HSpnQx41jamS0KLu4fkSnv7nnvGeoKjOrrWIXnvu kKyg== X-Forwarded-Encrypted: i=1; AFNElJ+rmacA4m2sVzQBm1lJUYIXc9WEoW88QIz10ZpfuecMq04DLgAf8kjaHVzgMomsmHIftz0pwDbpMbc8JLw=@vger.kernel.org X-Gm-Message-State: AOJu0YzCnmwXOUSEC5I80imYCLQkrllvrucSSYKGaipZHmh2pN6dANY0 RxyIWVsLgGSO6l7GI5WSYjNcgrV01ewCy5GYiPcSant/I4SdGwuI4dVK X-Gm-Gg: AeBDieufnJjn3kcMt5kr/DDS+0WomY2aETGP/mGE0boRoUHii/A8lIVZCrKcI34ClVa QPnHsT7fq0ITLlL4j02b5PIUoBgguHmi6ak0uypOkJs8MQMIWTOS7/Lb5YmZVX4KvlAwykV7l2k lY+pBrASO1Q15Gg+IAagsTli2OLYwZvZtnWS/wpuBisjOpBJ6FaBFOFgSERzq51veUcPSj8Bbf1 8iwRD8sWQIfTKa34uhh/DuplVh9WBpwx6T8UE4uLhnz9m1ZKU1iaemIrbI/W9nW2CG5qG7ypk3W ajPW2aq3RA3+Zd/czhHYbOM5+pv4CmiFaLsZdbnFx9zp5ch/7rjNCBddTL7yViYz99R9o10UjMf LT4WSrUP9cyoMSb0mrBw1RxpqREf35BWUNgXy86hZdVouYzjEThIkgtZBtGPBE2Jk5wo+AqfRzq TiBeASBX3gx/BVHyAlPYdDcSQtCNXoJSboSMNnP9mLO+FS X-Received: by 2002:a5d:5d88:0:b0:43d:73de:abd3 with SMTP id ffacd0b85a97d-43fe3e0bdd8mr40038135f8f.30.1776939203126; Thu, 23 Apr 2026 03:13:23 -0700 (PDT) Received: from yocto.. ([2a02:3037:60e:ee7d:34af:34c4:890b:2c47]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d525sm49741217f8f.31.2026.04.23.03.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:13:22 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fnnas.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Abd-Alrhman Masalkhi Subject: [PATCH 1/3] md/raid1: replace wait loop with wait_event_idle() in raid1_write_request() Date: Thu, 23 Apr 2026 12:13:01 +0200 Message-ID: <20260423101303.48196-2-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260423101303.48196-1-abd.masalkhi@gmail.com> References: <20260423101303.48196-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The wait loop is equivalent to wait_event_idle() and can be simplified by usaing it for improving readability. Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/raid1.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index cc9914bd15c1..b549be9174bb 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1488,21 +1488,14 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio, mddev->cluster_ops->area_resyncing(mddev, WRITE, bio->bi_iter.bi_sector, bio_end_sector(bio))) { - DEFINE_WAIT(w); if (bio->bi_opf & REQ_NOWAIT) { bio_wouldblock_error(bio); return; } - for (;;) { - prepare_to_wait(&conf->wait_barrier, - &w, TASK_IDLE); - if (!mddev->cluster_ops->area_resyncing(mddev, WRITE, - bio->bi_iter.bi_sector, - bio_end_sector(bio))) - break; - schedule(); - } - finish_wait(&conf->wait_barrier, &w); + wait_event_idle(conf->wait_barrier, + !mddev->cluster_ops->area_resyncing(mddev, WRITE, + bio->bi_iter.bi_sector, + bio_end_sector(bio))); } /* -- 2.43.0