From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D302C385519 for ; Thu, 23 Apr 2026 16:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776960799; cv=none; b=kwBVVtsZuK/Fnq3KY00R8/3FT6zw4zf391wMqB8VbIbbpWlLUXvwHG/wyaLKMZ6XbZgfuWcS/G7Q3GeCBVM+kgqsHjiE6Q4082FWhZsa5AiiNUwl2U5F9+9fVm9d75JRojQMwEeiWhAj3+jHCqpdfO1R8EXxtLEMpNt7oaq8IdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776960799; c=relaxed/simple; bh=fKB6gCyOLYLrhwAUsqBd+g5sVfW+71hhyWakIaqB8Vw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=omciyZAh6cwRv1REbbtqT6SGhpo+XheJ4X+pbdNPBHEKACPL4tnOzEKAKyoc504I58YMhuEFvqs2nZWxNxmwVH4j8wP/efAYdpFeeNMHY5+Jh14D9rU4AeRRyqmYuxfVeYeKVUqzmgyShAmqfzyMJ4ClCDL5oO4ULFuFL2Nhoi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h8Xfq2li; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z//OpV5u; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h8Xfq2li"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z//OpV5u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776960796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BPpcyNNw5A670ehN8KSLpk7tEoT3MHJiCv2Fb9unNrI=; b=h8Xfq2liX4Xok7NL4MrP11tHYLoduTroi1Rw5cFy50R3Uaot6fyuxYnrUUTel+E/6eRSRS 7oZKHpjXuLwV70WFoWw6D0XA8wMhqseY0FJ4i3HhqFD5pLjpuwV1XB2Wkzrwq1J9tsNjls IfAFVYEaoV6gNu9T9UGS1qyfvdmeVPI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-BD8pHthfOXqarQtpHxMtDA-1; Thu, 23 Apr 2026 12:13:12 -0400 X-MC-Unique: BD8pHthfOXqarQtpHxMtDA-1 X-Mimecast-MFC-AGG-ID: BD8pHthfOXqarQtpHxMtDA_1776960791 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48a55de6fb0so30257875e9.3 for ; Thu, 23 Apr 2026 09:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776960791; x=1777565591; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BPpcyNNw5A670ehN8KSLpk7tEoT3MHJiCv2Fb9unNrI=; b=Z//OpV5ul8B0izuI4FoJqtTgeB1AiLoZdrmCkLQxbTJ8Wb8pzg+wI5tRRXIe4x27Gk 2sdEkWU71jw5CqtcynvlgvckWFx1awofT0Aelm9PRYFYwAl3sLc/Z0UX9YfuNMRzJvw6 1Gz3QPNb5dD6g5kU9RGRh94Q8K27kYx9DpDkIsF0deDU5341sRecvXNiV5ulZRANaG1b kSBP6W7z5OuQadOrG3q7Q9mfxkkj0zvOHd9Hbol4LH9f99RgnviFzWz5DTxH23IR5KRi xsKu8W6w7in2u8iYeNmLCPcmYU5wmjJjFCvn+WlUAOsj826W73JpfsNwV86lyutPEJet ujtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776960791; x=1777565591; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BPpcyNNw5A670ehN8KSLpk7tEoT3MHJiCv2Fb9unNrI=; b=c9NuBUl1zEpcGYM4L6xBOHHarnZueF0wk8Rho8vJ+H880rCNwyjcQffioWLkOBb/4J TQZWmxvu00CMppd3RecrB4vFG3UB3/Bbn3eOPqJ6g3J5ntpzXxvby+y7yEFqFsuz43hO aQSMfHUOwLIVsn0QEbgFOr75yIEMmtHDS0ZCLhAeBHscDdJueO14KEbw/skBPOSCA23F iM5QhLA36ZrjmVf4pYKIW6H37wwbhsHCG6LZN3Jf0qcRDR59ydS8azeSPtURh3o/GGNO Bun+zT9rRbjxo6TN5VsQxJpj3tDlTN9D2rIB50KhZ34cByeIPT/O3kJA+9483J4Bs77H hJTg== X-Forwarded-Encrypted: i=1; AFNElJ86YEG37KlDXqZRhJyDCnhPApMK5W/+EBT89VMnkrpIM5xj5/uxZ6hAKZIZliGCGAj0ZbUoZZaOq28xvVs=@vger.kernel.org X-Gm-Message-State: AOJu0YyYUPAdRwBVa4TXa7ppWyrVTANZfssu3CmBJU+/zeaDMDhNU1qE JWcpTcGz41DExWzEiwUAIqYh77Cc41EghdoZFivbsehze4zB3Q6RbMI+85wAn+rhlcRaDCir8rr PCfWvqBHVUxX0J0QOwqO24IEHrCbJY9ORsIBijX8EbYJAhikicNa3OgkJaDhD2rP58w== X-Gm-Gg: AeBDievxv+G47WCj1j6hGjrLu0yIXm0vMHaDIuUNO+SEayLx6UNSZ00IQiwJiKpqY70 cDr37vD96cg84kji5+fU5CaeGC+hbtC2fL6KVN8eTxS5ALYil1Nzmp75+AmN+BqjmGLtL1FFIGt 5wVE0YWWQvn+0wfRG9wzUGglLu/520WPWF34ERW+DpcgaH0MBJJIe5J5AKeslA9t68bB6QLeQFw oY0ALAW/uDF4r4VhmFXGxZCDjuT1kRzIQwfqeXW2zjK2tKnHGf+4PbwY4LqHpTVJ86X4Legg5dC kka/CfPTqKj/MQT39aA73np11PAVa6hB6yhvL/Yq/ISLYCOAPqUHna9hNlKMMNoklQK69C2pgcY ODuMu473MlKrW1g6EsqiB5vTVfnSK4CJK26/aN+FuQ/lUaL+y7QTIgQ== X-Received: by 2002:a05:600c:1da1:b0:488:f453:b976 with SMTP id 5b1f17b1804b1-488fb7844c5mr438077275e9.27.1776960790538; Thu, 23 Apr 2026 09:13:10 -0700 (PDT) X-Received: by 2002:a05:600c:1da1:b0:488:f453:b976 with SMTP id 5b1f17b1804b1-488fb7844c5mr438076745e9.27.1776960789978; Thu, 23 Apr 2026 09:13:09 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-21.inter.net.il. [80.230.25.21]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891cdfcd50sm122342895e9.9.2026.04.23.09.13.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 09:13:09 -0700 (PDT) Date: Thu, 23 Apr 2026 12:13:03 -0400 From: "Michael S. Tsirkin" To: "David Hildenbrand (Arm)" Cc: Gregory Price , linux-kernel@vger.kernel.org, Andrew Morton , Vlastimil Babka , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Jason Wang , Andrea Arcangeli , linux-mm@kvack.org, virtualization@lists.linux.dev, Johannes Weiner , Zi Yan , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , "Matthew Wilcox (Oracle)" , Muchun Song , Oscar Salvador , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Hugh Dickins , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH RFC v3 01/19] mm: thread user_addr through page allocator for cache-friendly zeroing Message-ID: <20260423121222-mutt-send-email-mst@kernel.org> References: <9dd9deabd42801f3c344326991d1431c3d8db39d.1776808210.git.mst@redhat.com> <20260422171315-mutt-send-email-mst@kernel.org> <20260423074433-mutt-send-email-mst@kernel.org> <88b0765f-7cfc-4e44-83d2-c01a1755c842@kernel.org> <20260423104120-mutt-send-email-mst@kernel.org> <1ab6e58f-d984-4bae-a343-1b0d3c973ad0@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ab6e58f-d984-4bae-a343-1b0d3c973ad0@kernel.org> On Thu, Apr 23, 2026 at 05:54:26PM +0200, David Hildenbrand (Arm) wrote: > On 4/23/26 16:46, Michael S. Tsirkin wrote: > > On Thu, Apr 23, 2026 at 04:13:50PM +0200, David Hildenbrand (Arm) wrote: > >> But really, that hugetlb code is rather messy. I'd vote for leaving hugetlb > >> alone on a v1, and focusing on non-hugetlb first. > > > > I just dislike it when things are non orthogonal. > > People are used to: hugetlb = same perf as THP but more predictable at the cost > > of being harder to use and using more resources. > > Here, suddenly, we have an optimization but only for THP. > > Note that we also didn't care about user_alloc_needs_zeroing() with hugetlb so far. You mean, that it stays because of the reserved pool? > It's not that it cannot be done with hugetlb, it's just a question about how it > can be done more cleanly; and that requires more work to clean the hugetlb part up. > > Best done separately. > > -- > Cheers, > > David