From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B28E3EE1F6 for ; Thu, 23 Apr 2026 12:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776949032; cv=none; b=rTPhMsVc3PngQ3VfZCaq20en1YQ58ptix1IWewU2lN1T1VAPcnbQjfOjtN9/1kv6VdX/pc7EFI5Wv+6h5ztQ7nSLYpe8ejtuyglrbF3OAYRDQbOiBHCsGbWTCZixazDDyJhI172tPP4OO9imwLQPfuzLFm3XyzzmAIxdqUqSWhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776949032; c=relaxed/simple; bh=IKHZ3q96hTXuMIiH9BNrB3LA3G5rq5jK3yc32SGuub4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lA/+yS6wyciYX5pqIdI+Zb1BcjNti0RdWBcC/agKe3maalZsRW/rtDMAz7DI3wxM276uXnpDdfdYSiIr7W8DP2n+mqQro7sHQG5vBBfdGciMQc4KUKt9mpIkOdR3lZtX0Xoz7dNdpdacbGDY7EFh48mEFEU1m0IaQJ6r8ZtGNCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S8r3Sg2s; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S8r3Sg2s" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ab232cc803so31920375ad.3 for ; Thu, 23 Apr 2026 05:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776949031; x=1777553831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M/+1WbMY5u1hix2GJGcVANS/NpesLEU0QcdbmptLbD0=; b=S8r3Sg2sd/eGxEqiktHJyGQ/DilI95VfPrIqo4l2GSBO3PUCTSg+AJWr/8J1sWTznE 0wQl08QXQJnLYespxOhpVLr+DUhEPmcObKWpqacPWqGWdE8aLcFl38XusdpKmHFeGYTE +pQAXLBPaaEZUxxC601m6BY3qy9PAtHXii1YJgrWbBZ4JpwT+1elGMasPFJUvHakqUWk SgG7IxukxaTpnbXKNpeF8f5yBRsJKZuXul5eIQ+biACVUPvafVw2Xj4EhWnzssV637KE SMAWjMBDGILaNUzA77fnNMcna5heW9oYncEHuljcUvO7Oc8rk6381A35ooa1GS7cXaY4 XC5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776949031; x=1777553831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M/+1WbMY5u1hix2GJGcVANS/NpesLEU0QcdbmptLbD0=; b=LZJSFFLRWUCgD+Fza9KEefyBPrQX6HpQKMKRZ3v6N802QIfP6vHf4PvjsOQEtTNR1U AOkS9B2XB5FQK/ysLmUcnfSb7iqnUbO2tSyIueCFXZ1wl/ygRg1F0bYgZOr/TBgUQJM8 df1/p0A23HM8airqGpFZyTQ+wwb7eZy20FpH2/Sfybghmvj0x52K44f4PO1uKXw3kTMp pztpTMC/oKxXW5ySC/tvyTtJwfAgQqlssbxbxhYjrqqrKeLa2lCKsM9tl61IZZ5PXW1J VZFsxpefIT24FO56tdGhX7sdFMMeuZSqaHOspb20LsRaTPQSlrBTu/jTxpKUfzSGAUWl 8aqA== X-Forwarded-Encrypted: i=1; AFNElJ+kx31jD7b/KS3k5TxNp6PApokmjIlGOfoHAt5x3DyGPMb8QUfZ9ep+e/zHUzWYOHKfg2Tro2QzfKFGDp8=@vger.kernel.org X-Gm-Message-State: AOJu0YywzaNDg+/fJsb+CWk+X6SJq9ewhLPjzrqLZD2rEIVjbUjK2I8S IovT7FnlHp4jVtAsREMDHNLLuxUxGKDR7527IWZAolkXaFbrfUbRFpil X-Gm-Gg: AeBDiesrQuSIINQY7DllgPsUviC83x5AbqDYW6wJvltwtLIfnMB3cePi6oB6wvunv+F cQQ4U3cjiJaMygq4MnfEsXssWKpJNQIoMJGroamEd/fMCf6o577kqCwZJnSm6GeleEX7UlPnZIX AkkUFcOMeBljIkgPrOKA4grnY5pv33J0BXh92sm+gbfnPgvAAT/PoBQaIud5UfgYnMPaMB+Gnxj +ZxJevP1YXL6sRQO0ubj/uG+bgE/fCKaPAvTuboW9ozkHS0FVAeZrJYYmz4/HrYBB/pPqH3Mby7 c6KcP2L+K+LHGsmZBCV6oqxa6Fze9oaWIYMRmpbaytbBh3vw9jy1aEJ5XSSzZIL8SnBk8vlWHBg I94QLqT77oBW9b1ODHj772ehFpQjAO/Jk0SNAGDFvLcqg7diHjJQFkqaaryCgy9cOEqCjuyowZD WrQ0ocJqspRp5IPLkLQmiXl7RkPvLlF6PxDxEu86OnymOlpx5bYKCHKZ0X9oZoeB2yLoJy X-Received: by 2002:a17:903:98b:b0:2b0:7026:24bf with SMTP id d9443c01a7336-2b5f9eff280mr280220285ad.14.1776949030721; Thu, 23 Apr 2026 05:57:10 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9ff390sm192106545ad.9.2026.04.23.05.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:57:10 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown Cc: =?UTF-8?q?Martin=20Povi=C5=A1er?= , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , asahi@lists.linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/5] ASoC: samsung: idma: Use guard() for spin locks Date: Thu, 23 Apr 2026 19:56:43 +0700 Message-ID: <20260423125646.156599-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260423125646.156599-1-phucduc.bui@gmail.com> References: <20260423125646.156599-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for spin locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/samsung/idma.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/sound/soc/samsung/idma.c b/sound/soc/samsung/idma.c index cb455ddce253..d362136e1069 100644 --- a/sound/soc/samsung/idma.c +++ b/sound/soc/samsung/idma.c @@ -67,9 +67,8 @@ static int idma_enqueue(struct snd_pcm_substream *substream) struct idma_ctrl *prtd = substream->runtime->private_data; u32 val; - spin_lock(&prtd->lock); - prtd->token = (void *) substream; - spin_unlock(&prtd->lock); + scoped_guard(spinlock, &prtd->lock) + prtd->token = (void *) substream; /* Internal DMA Level0 Interrupt Address */ val = idma.lp_tx_addr + prtd->periodsz; @@ -101,16 +100,15 @@ static void idma_setcallbk(struct snd_pcm_substream *substream, { struct idma_ctrl *prtd = substream->runtime->private_data; - spin_lock(&prtd->lock); + guard(spinlock)(&prtd->lock); prtd->cb = cb; - spin_unlock(&prtd->lock); } static void idma_control(int op) { u32 val = readl(idma.regs + I2SAHB); - spin_lock(&idma.lock); + guard(spinlock)(&idma.lock); switch (op) { case LPAM_DMA_START: @@ -120,12 +118,10 @@ static void idma_control(int op) val &= ~(AHB_INTENLVL0 | AHB_DMAEN); break; default: - spin_unlock(&idma.lock); return; } writel(val, idma.regs + I2SAHB); - spin_unlock(&idma.lock); } static void idma_done(void *id, int bytes_xfer) @@ -192,7 +188,7 @@ static int idma_trigger(struct snd_soc_component *component, struct idma_ctrl *prtd = substream->runtime->private_data; int ret = 0; - spin_lock(&prtd->lock); + guard(spinlock)(&prtd->lock); switch (cmd) { case SNDRV_PCM_TRIGGER_RESUME: @@ -214,8 +210,6 @@ static int idma_trigger(struct snd_soc_component *component, break; } - spin_unlock(&prtd->lock); - return ret; } @@ -228,12 +222,10 @@ idma_pointer(struct snd_soc_component *component, dma_addr_t src; unsigned long res; - spin_lock(&prtd->lock); - - idma_getpos(&src); - res = src - prtd->start; - - spin_unlock(&prtd->lock); + scoped_guard(spinlock, &prtd->lock) { + idma_getpos(&src); + res = src - prtd->start; + } return bytes_to_frames(substream->runtime, res); } -- 2.43.0