From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013059.outbound.protection.outlook.com [40.107.201.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B516D30BB8C for ; Thu, 23 Apr 2026 17:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.59 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776966499; cv=fail; b=FzcKj64QuWZ9/tOZbHnzTfDM+LQ2qcn/8HgSk9+wCK1CpTporNQInME/IIgZs4frz2NNE35KbRbhLuC0a9M36oniAqfZOjkglgUvcMkBimoHiFqPgCEf/hUfprKyAicaJKSaHdH2/MelGcG3oQhPp6X5kwgmBsQexSHyNpjO9vU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776966499; c=relaxed/simple; bh=kXr8pq6jKtPPvwYXOtOzepo/e5ZqkATg39MaAU033yI=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=g0m+sPIKpMtZmG++l+Wvq7bch7mIWJe181lFYLKJGoGY54tlelE+jnFHqfp9QU4JkuoaxYBujf1cokYlOvPY1guQHPo8W7pFbXplbXaxiqgo+SmV57R0vvNOZScoMWyAeINzmojpCjBeu45B/Zad48A2Js/cGjNM7tKKgJh6tRs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QJYwhb3a; arc=fail smtp.client-ip=40.107.201.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QJYwhb3a" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C96JtKuyRmVjU9PE6anSOLPc09NgW7LbBgb5zQAkG7HYEiC1VJd7whT6LamY3jbD2iCxhCjAsqV8N10vvMkXqlo8Tg65jFy37KdkP3S0z+zE4/WkjTuwsV5AnUUjAWsCVD+3U8uW/SVx48hRgGsVeIbPrzhdM7LErJaNBkPQxG0aTQ1vhVS9byMPuwthaGDQHx2mK2Lwpec7dw19TTX4I+EFnH+55kEajae9h8rBaNgXYUIfcu84L4c1Mo8tMhTpsQaNyYhjAHm99OCtsS3qQ0pcLA6AIllyXkzMMlyH841e342zBoZ2eaT4R3qjyncNY+gzEQ8nKXMR7dCwBOoQBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HJVFmzsILr66iH/BFuDAAD+4HO2aLk7VJQiJF4yLMj0=; b=EE6spVAXg5moDBEr/P2TCJiTQjwSABzgeWgAVlv9+U5y15LnMf9jVPE5ajGsvPHBZHKDkie9yDGEgKPeqJfTX8SwclnRMpD46hjFFOPxYsQyIFtMvOmtkjtKR0fCa1nsWh3s/6nN9JNTu39jM0ZXnj9Ip3IgGyrS4SPP6PYl/xvF+SpJ4Y8FenT243dHdbx6BS7W4uXSLZBSlxEXAHHv8BfGbHV2ctGjIg9KhSqBKB5HZmscQeHRTfHTIdZgbdtd+uOpLFmYXDT6u5DRvD0vKu2ZqCjAHVK4UZUGtQnlJaC3Be5kLqelL/rXvhpv7EryPI1Wvb3kl+wEBDTW98wMOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJVFmzsILr66iH/BFuDAAD+4HO2aLk7VJQiJF4yLMj0=; b=QJYwhb3aaIb//yfs9ZVXd4P1VXvPaDjYCbxVY+qj1lLBVZcCtPW1xVp/LSJKDa1Xiv57Ev5s5bq+QFllI4y383edV5uJc4+PJN78Hj2T6+hem7LHnKqALEeZMg5jbmfPYzEdonlCN4oz9NUsaZyNj348DJT/egLlH/4GTbmyGmTbQXbAfJuKMhjOHI1hhyrFwo1EI5vSLlfsa11EIIPKD8hwA8ujUPyIXc4kC6sW2N7QpdN9w7/Xj/r7QstWct+uTRZ9cgUXiJpiOWaqklTqXi/oUisLiI123pQ3aJ2cKxpw8p7XtQXmilr2BfhF7JiKY4KwTx7nHfWg3f5hJS4iOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by IA0PR12MB8254.namprd12.prod.outlook.com (2603:10b6:208:408::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.21; Thu, 23 Apr 2026 17:48:14 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9846.021; Thu, 23 Apr 2026 17:48:14 +0000 From: Yury Norov To: Valentin Schneider , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , K Prateek Nayak , Yury Norov , linux-kernel@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2] sched: topology: cleanup comments Date: Thu, 23 Apr 2026 13:48:10 -0400 Message-ID: <20260423174811.56510-1-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BY3PR04CA0009.namprd04.prod.outlook.com (2603:10b6:a03:217::14) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|IA0PR12MB8254:EE_ X-MS-Office365-Filtering-Correlation-Id: 597a6481-affb-4c74-6086-08dea1607e79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|10070799003|56012099003|18002099003|921020; X-Microsoft-Antispam-Message-Info: uXMTpy1FnnDiR4cqhturTVDD3oyBtl78+Y6pUMS9223EoD3j+NaOgbeyNT18a0/IBHb6abeuGOfKvN2jIPMXL3/zvYEc98negG2dNIJnJ2aQyEhPy5LJ2gXjN6MjDv9QJgcwAzbwGvsZpsCn8Yjiq6+yYYFPMsoW3ITUPBy876mFLo+PiZW8Q/Ihw3DdVh14fiQAjeGiyv22LlOwflZc84UuYna0qrYPAtldN7jWkfcUV5EsUQaA1Dbni3URKnZiype5/iurh0+Npbp+1MFZeKb5WbIPhFScBlxwFsDJ2RgknIi4fC+P183MNLlyIknslthKFhd3fRWcRhafeAbSbaMxzKfYa4bSwygROH79gDJufRe/xLrcBAux+8JxGEdfyo2e4Qknh9ruQdyumzfF6IU/bF1O4xFo7N+u3MwQIceT3F4h065I2aTjb8PPVjRx5Obn2mZ8emOaRL6wVDX2fvwh1eYRMh9bNy1h+SXKYaMLjVEwoIa2IrfJqxYHx8n+L4F2lXKUtYpb5DKeRSwvlZlbwD8xOjMmhVDplXhyUQx5j33YmLMU3AKoVXnU788U83tUTcwwD6g0GQyVR8W3PW1FhXVO7uXrAI0kMrgzysuet377XUVscswBt8UU3VsNn/04gr/v/MRObpIWoYcGQXKvdvOVhm7RwC97wcsrBEeJ0Nw9mbumCBtiswRTG1vSXf03iEiu4j8dKlL7JCc7Uq4rZ9vHRAWRlVyA24tTdM5WK6sH5CHLTknhJMBgFZuHha6CjO3ObOxkKs0v+SNULe9aQ5NNH+PYQDTHDbjPGas= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(10070799003)(56012099003)(18002099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4k3mzErCELs/E1rdC+FoZ7ZY4GtlqwEGvbp4K/1kxZEqDQv1N+VSo7sr52fH?= =?us-ascii?Q?Gn1gK7j9lVs7a2tj+2MHM2GNK38qGQx6l/rQ2ZicHZcod1VFmTNfnlug8J/Y?= =?us-ascii?Q?M49X0tnrhnH305K4h58g1fN+IOJyfCRjA9wau/+ZBo18vphC/QTzJBCyKz7E?= =?us-ascii?Q?lQyGOQSjUt1s6rKdSOJAlE1NK28Iz6dw4lOcXMBeP2QTSqSy8uS+bbBUg6nA?= =?us-ascii?Q?HFnwtapBCrCI7zzRfVTCW6Bc7t1CDH96nvAD2E542n78EcS5Oucor3TYUOCB?= =?us-ascii?Q?5egb7aoxTBu/bkXlxfdrfsfb3dQ2sj/rubTKSOcLHvc/M0H/PTwAZQWtJDBn?= =?us-ascii?Q?iq/MSDuuespxLhSYt0RK6H0blQtROEEKIJlY51dvVhXXEuuOG/R9YaQjtnvx?= =?us-ascii?Q?YXFKiBOMcEZ5d2hEY1aHBxreHB5yE0V8pCOfsMGPswKusVWYZSHigZ1QUSOT?= =?us-ascii?Q?CrH55fuAUfG9PVuazKGGHBKu0OeXDRvoTL8XopikJ2fJ+oWma2qB9ffzfY+2?= =?us-ascii?Q?hGGGaXRdvBndLi9weLulfuxJ1iHlmFa/SJBWWkcEUFUelLPJmnchI5C65TuQ?= =?us-ascii?Q?rc0vbVHjdgM53kdWIwowFKMhCiC5NFrDvMNgtvYhvxec+BqF4cpgnIFxhstd?= =?us-ascii?Q?9K9jtCuVnV8IfiwCCzSqx/VbxxSDBWXjbTFPxFuAbCcCZIazNs74i39/6X4X?= =?us-ascii?Q?TnhZBG3MF3cRjoU9GaAt50gvBEIPsYR4aHR4d9fIx3xoBhmo+TWF65Gg6Szc?= =?us-ascii?Q?wD8gAax36WB1CHsDrFI0Fk/QfWoHtjw25bxv4RECSRA9eo1ZBPRtt/X+2BRa?= =?us-ascii?Q?wg2iRR3uxmwTym/ajCe4m3fla1FsJpzu3BXcFsZiCD85baZSGAyLtE2LeKRo?= =?us-ascii?Q?dc1n6Bwv6UPKeayfAXQnC1aAmcrhafZ9NlRCen30RwcaoBH37lYD/C2WS7iM?= =?us-ascii?Q?sBzMbMXjsk9O9WncMuBOJTsuWSlSCz2Txem8GV8pQ5G3sGwJm0FiFNk2Id08?= =?us-ascii?Q?Z+vmtw4VUKMOvQc/lfhMJcikSd6A5IV9p0jf/HZqKFaVsCBhYDeAD0FHhztC?= =?us-ascii?Q?VzqcdyZCb3S+z5YgSRPeQt8ir6Oc/rF+GkpAI2q7dDXboV5nP8NrtXJTq7WJ?= =?us-ascii?Q?UemxBwY2LuL4hZGD/ksKpbqyLoP9XvNI3QwB5SN/Ehn7ujj9AcC9EA96ii/I?= =?us-ascii?Q?H2ykRH4HT7OMmzgtNE9uMRXjmB9RMLShx3dI1jv3MAMgSaCg+YcVTq1WvQ2r?= =?us-ascii?Q?dH30ymbz2Z/BC+XN5aa96uj88QXItINpk37/HDY/stvsEJQ7HW4aOTkw3Mrx?= =?us-ascii?Q?mIzUySwFpzNsFbDjzTTQ+cEAFtaguupoKUve8vNpn/2iVAaXrlwIHM5DBkaY?= =?us-ascii?Q?1y8snkavFWZ45w/R3+CPu7wMT6m44NRfL4S98Rl1f6VRmsjjCREIGdSTw9VJ?= =?us-ascii?Q?pNIZXKwCjk2Y64fE6RlcC3wteomoR0txiUkFtP13mG1TND3WdqrJJ3uLwwDy?= =?us-ascii?Q?NhLKtdWAbN5RiD2qdoeJP6yoti55iIDtRXRqaynJ9NSgti00RUXKbwgdLuIk?= =?us-ascii?Q?ZXbkVOlZH1OfexY231vH5Mins+5lM3T74GsaybCLMOOXY/dbelautZ2S+f7r?= =?us-ascii?Q?2SG7JSskAhuq8sKB1eIqQT2VT38Q8O0nnPu8NopCgOumbyFL5bMSUmJiCeyv?= =?us-ascii?Q?XcSXVdf1dcn2Lx6erGeTe/dNoQk2ovparFjbo/wtHVMUx5+F7zwv1S917t72?= =?us-ascii?Q?ONId//A8t5pRzyd6z/+bw1kprReMnEhBOohi36gVT1GSXKH3AU+A?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 597a6481-affb-4c74-6086-08dea1607e79 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2026 17:48:14.6041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b5etZduxDrACnZg0cNFLYY3yVUj4pJPfA2NrQyCG0gZJXWhFS+uorOMykXv+wUSVtiUr1Qeoc3Cz6YquH8g2ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8254 sched_numa_find_closest() top comment is almost kernel-doc formatted, but doesn't appear to be a valid kernel-doc. Fix that, and while there reword NUMA-level comment, highlighting that 'NUMA level' is a synonym to the number of hops. Signed-off-by: Yury Norov --- v1: https://lore.kernel.org/all/20260401145654.16241-1-ynorov@nvidia.com/ v2: reword "Return" statement. kernel/sched/topology.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 5847b83d9d55..3d7e3d5516dd 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -840,7 +840,7 @@ int group_balance_cpu(struct sched_group *sg) * * We want to construct domains and groups to represent this. The way we go * about doing this is to build the domains on 'hops'. For each NUMA level we - * construct the mask of all nodes reachable in @level hops. + * construct the mask of all nodes reachable at that number of hops. * * For the above NUMA topology that gives 3 levels: * @@ -2236,13 +2236,13 @@ void sched_domains_numa_masks_clear(unsigned int cpu) } } -/* +/** * sched_numa_find_closest() - given the NUMA topology, find the cpu * closest to @cpu from @cpumask. - * cpumask: cpumask to find a cpu from - * cpu: cpu to be close to + * @cpus: cpumask to find a cpu from + * @cpu: cpu to be close to * - * returns: cpu, or nr_cpu_ids when nothing found. + * Return: closest cpu, or nr_cpu_ids when nothing found. */ int sched_numa_find_closest(const struct cpumask *cpus, int cpu) { -- 2.51.0