From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5FBD3AE6F3 for ; Thu, 23 Apr 2026 18:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776969511; cv=none; b=cDtpAvXunwFhPqrm+xd5+wi3xVLmWT2O4Ra62pLdntOM6OLJbFpDbkK+27fHgyV2bBUl/nBB5e83BJUxL9Vttgi/smiXRYLpjqu6vYOFi0Q3WTYFXkFH0qA5hQU2all5J6Xyt3Y2ICtSWvpnZFnqYVpsAvK/7uVhdgw9we/vEuk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776969511; c=relaxed/simple; bh=+SOrMVVHB5qOMDbPRIZTXf906cveuoXyVwOSqdhGY7Y=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HNqFEE1sh6zTL3nATPsVuMq+cH2bIqNqxVlX72yHZwwkf1K0nQyppkUc1BRq+CEVYie6CTgTGSpGy2h7kEsR2CBUi8AJNxwcASCdezQXm2mP0S0DZA34SfodaD+q7DcJlkFQNC6TFWEtzmtmsQPE9p8giZyAWajAFSBsissc6d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IqDf9HRW; arc=none smtp.client-ip=209.85.217.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IqDf9HRW" Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-612d8a59ca0so4518159137.1 for ; Thu, 23 Apr 2026 11:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776969509; x=1777574309; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L22PrPyxffGp1s35EdIqfhlvwug5UudCDFqaIR/CCpM=; b=IqDf9HRWMbgPQomjPurq9RmKiyYECNUPC3d6/qo93krOPkaYRRQxrbhTPmliJ+6vFx ItWN6sbrmzEJozWHghjPBVoFaHdhugE83hY25cinwZDN9Z7rriw3U5+8+QPFxwTSLFNP t14B5mPoUv1F6jIOCQWCHtx0zRZPdJdCqbAZGjgvcs/Dk0GETlmfLONNiQoPBlvxr3mI LsStY7FoGC3b9zL0wJaVFIBXJViZ63BDYmv0k5DamwKHvGDbKo5Jx7I6IvL3w/MPrrjz jobQcqQH8C2s22AJMhVAFNo2Mddms5DGDRBFM0kUKoKWfurJ/12HeXoXCIwbDWFVGiXq m7Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776969509; x=1777574309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L22PrPyxffGp1s35EdIqfhlvwug5UudCDFqaIR/CCpM=; b=mN7eEz/cEw642+GOa4bEd4k7bImTnAiKKgWhXsU142JynVms8aABZuFPMolK5zYxWr h5tyoeTfqCiiCbh+8aXsEl0iG/f97767v2IvbFR+k2UOE1KbxvoU6z0A1qaaOUrroahc pEoQCwIyMpfhPvq9LaoE3qjEawgcitdOUBXSsQ8MNwyZn15MwIDyy6y0MCT6fquCeY/p nEHhGjyQ88GbjUxx0PU4I2vjedioG2y0k2Qe/HphfD9dsZ8mRSdGmiks5fByMQZik2UY m0Mm7tkZgZKSgyZvMoKGQaDNC+c/IpdwvJnfMFhouAAb7mgi6dXKO0sbP7al384MZEr+ pa7A== X-Forwarded-Encrypted: i=1; AFNElJ9WlReTjvHSeqm87V5RA72xIwuFzI5qKaLMMMHHKu4WWWbR6JwHgcbUPm/R/tOXQMNPB+myKnQHAIEDHwM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1qTltWg2ykEa1D6iOykgWL0khvHkQlnvHp7s1WwpnNdTY6mvO WC+pADHy9iB+KzjCBWPjkYznMJr1hnl92U1zY34xbYMH2rY2PiASuCN4B8WdHnzyFqE= X-Gm-Gg: AeBDiesMPtfr58BNVVQu2hqN5P1Z1L5txjKQYcasZsiNslNGHmG0Yfp8Tj836XCePql 7S5qw9F8gqp3gqf11e2BTeqc0rAfxQMlgvrSE99Zy6jChzSXE2FDmN5FqWsmyrFTApFFDBmPtTd QHts3DU5B+XipBhQ5nb0x6EoalnQCiLhe/ZIKD3wHb3aqBwIChBlea2qgI0ACFf3ObJiSyzl5DB F30MkhgxR5zHATe7g9f9s1/RFwK+/yTnCtbjAixBelMw4Lwfz1uMpoKVouonRc0x03yD1u8igVK x06NWZKPKqk+Acrakzt9rl+7UngLjHDaFi+DQACezJtfy997Dk/ZypT6GB5SL3auQSShFpYjilj gDb1DSwYW0WYl0hokqrAJ4EnL1+MsjYRyJljBaNwKlN8j/XBPOoOMbz4FJLWqb77Xbh/cIvtSCr Yma0j7xgU32TS6UCfOHmCx9IIebIkdvbeDkPmEbH5itQMy6mswSdIPgN45g3u5mYbp2HC1 X-Received: by 2002:a05:6102:b08:b0:610:1c78:9531 with SMTP id ada2fe7eead31-616f71fa1a9mr14232960137.24.1776969508715; Thu, 23 Apr 2026 11:38:28 -0700 (PDT) Received: from localhost.localdomain (recod-gw.ic.unicamp.br. [143.106.7.151]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-61745c9e51bsm10788224137.4.2026.04.23.11.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 11:38:28 -0700 (PDT) From: Everton Colombo To: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, andy@kernel.org, hansg@kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org Cc: ~lkcamp/patches@lists.sr.ht, koike@igalia.com, Everton Colombo Subject: [PATCH] media: atomisp: Remove unnecessary function return Date: Thu, 23 Apr 2026 15:38:14 -0300 Message-Id: <20260423183814.84729-1-e.rcolombo2@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adressed the following checkpath error: WARNING: void function return statements are not generally useful. Signed-off-by: Everton Colombo --- Hey, this is my first patch! Any feedback would be appreciated! --- .../atomisp/pci/hive_isp_css_common/host/sp_private.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/sp_private.h b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/sp_private.h index c69778411f2f..b03ae6658df3 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/sp_private.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/sp_private.h @@ -21,7 +21,6 @@ STORAGE_CLASS_SP_C void sp_ctrl_store( assert(ID < N_SP_ID); assert(SP_CTRL_BASE[ID] != (hrt_address)-1); ia_css_device_store_uint32(SP_CTRL_BASE[ID] + reg * sizeof(hrt_data), value); - return; } STORAGE_CLASS_SP_C hrt_data sp_ctrl_load( @@ -51,7 +50,6 @@ STORAGE_CLASS_SP_C void sp_ctrl_setbit( hrt_data data = sp_ctrl_load(ID, reg); sp_ctrl_store(ID, reg, (data | (1UL << bit))); - return; } STORAGE_CLASS_SP_C void sp_ctrl_clearbit( @@ -62,7 +60,6 @@ STORAGE_CLASS_SP_C void sp_ctrl_clearbit( hrt_data data = sp_ctrl_load(ID, reg); sp_ctrl_store(ID, reg, (data & ~(1UL << bit))); - return; } STORAGE_CLASS_SP_C void sp_dmem_store( @@ -74,7 +71,6 @@ STORAGE_CLASS_SP_C void sp_dmem_store( assert(ID < N_SP_ID); assert(SP_DMEM_BASE[ID] != (hrt_address)-1); ia_css_device_store(SP_DMEM_BASE[ID] + addr, data, size); - return; } STORAGE_CLASS_SP_C void sp_dmem_load( @@ -86,7 +82,6 @@ STORAGE_CLASS_SP_C void sp_dmem_load( assert(ID < N_SP_ID); assert(SP_DMEM_BASE[ID] != (hrt_address)-1); ia_css_device_load(SP_DMEM_BASE[ID] + addr, data, size); - return; } STORAGE_CLASS_SP_C void sp_dmem_store_uint8( @@ -98,7 +93,6 @@ STORAGE_CLASS_SP_C void sp_dmem_store_uint8( assert(SP_DMEM_BASE[ID] != (hrt_address)-1); (void)ID; ia_css_device_store_uint8(SP_DMEM_BASE[SP0_ID] + addr, data); - return; } STORAGE_CLASS_SP_C void sp_dmem_store_uint16( @@ -110,7 +104,6 @@ STORAGE_CLASS_SP_C void sp_dmem_store_uint16( assert(SP_DMEM_BASE[ID] != (hrt_address)-1); (void)ID; ia_css_device_store_uint16(SP_DMEM_BASE[SP0_ID] + addr, data); - return; } STORAGE_CLASS_SP_C void sp_dmem_store_uint32( @@ -122,7 +115,6 @@ STORAGE_CLASS_SP_C void sp_dmem_store_uint32( assert(SP_DMEM_BASE[ID] != (hrt_address)-1); (void)ID; ia_css_device_store_uint32(SP_DMEM_BASE[SP0_ID] + addr, data); - return; } STORAGE_CLASS_SP_C uint8_t sp_dmem_load_uint8( -- 2.34.1