From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DF4E347C7 for ; Thu, 23 Apr 2026 20:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776974753; cv=none; b=rTT6a+Vc6BJiAyaezjV8ZwPZv4GeCENd9OLDA7nZoPyPLn9OwQUeC7moRb7EhpKCKTa9oJT/CDO2QKOMbH4wyV5V6yVexvAl68HafHRZTOPiv1B5XJOsFsFU4bnVGBkuPzESaUONrf0XEG9fWGUV3Fzy8yy5j6qvWVqPuhUIhl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776974753; c=relaxed/simple; bh=3o67tNBartiKtCDxZC5jrEXgLBAEj7xBtAGcp6wrC5c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rMbjyVto52026aUjLz8O7avGM5lnIiT050Ig+/X5Hhz/mKy8vxi+TXMKMMvjeyq24BS2SpOtioaueHOq9wEn8NnoaQ67YS0TJnWgxBKGNRsOndZAwRcnTALdqyRkrjnrEJnymLbJqPnxhS2JUSVu4YNUKXAPu0UeILG7N+Ov4tE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EHLgdsWJ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EHLgdsWJ" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso96304015e9.3 for ; Thu, 23 Apr 2026 13:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776974751; x=1777579551; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L0yq3naw4P7KBF3HnI/5iYacHkrIr5+a/lmsEJuzBgA=; b=EHLgdsWJfPxqYI19Ymm12ASi0KvT479qoq2UmyC7A7bISUo/Vw2DInYIkoccYV2rxJ 07tZT6pPiekYsRnOanGRV/CsNy4yx4mzylE5hkOjvn0YhwIuNzjy5nD1CGseTaDJg7Ev 6DZ41i2J9WUwDO5021I4ip3yztZ4072fwAwiOqbyv5XedngqdMztPRhZckdhQg0/xD8K Um0ujIxpbdjnFi5jHTG5gGmPXp3Nz74wIAcJyosE3z9U3Ri0ozEe2jf9VLjUUnEZV3BW d9bYaMzxomSo0kXwv7Lyx1Biz5DHD4VbaC+OGQ3DnmS6y1G1dmjXawrZHsharuii0ppX i81Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776974751; x=1777579551; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L0yq3naw4P7KBF3HnI/5iYacHkrIr5+a/lmsEJuzBgA=; b=VOssTbECm3trjn5fbW0pELBAzDMXJOcAkcbUYJ2rSPHsqDIzlTYjZPSsn8xXwbr7c0 720q/BsgtxPIYHwgJzbtYYJLg3rCnxzZ5pjM0gC89PZzWadoIZqj+hAbzsp98ZGOiKfX HxWPabS4hZQkV0NN7m/GAHe8qP1QBtIPWO7msDmBEgKKhlGrfV/ahaBvlPka9V5AeY2L +o2TrbEO1Zo4f7rKQ3NcJXOHhaEsSYvbxNB7yynep85PrmZQA+Bbjh2HkDjyBigYU6Yw mz5MtiBFgpaTFdAIbJqFwYJNufhHhj76/kE004+qq0d/o0cCdEdZVORZKpVqBoTQXLnQ aaHQ== X-Forwarded-Encrypted: i=1; AFNElJ+BRxadoJKV2lnNJgPyPIQGuDP0G9iM7/1N2G0GSeVdArCKseLORMKWw85+u2+976ZUnoOnPiWzgqpnlOw=@vger.kernel.org X-Gm-Message-State: AOJu0YwGx3ckxD0V1vSH0nFkYnYpxWl/sFQn+tTjbdRDHXxC77erFqXL 9MTDYay3w8D+Sn5XTGhmBVprGUz8toZ3gpTIYAKkiR0G5f8cXuHQ9RNh X-Gm-Gg: AeBDievXtKujKp1R9Ur/+B1qK2m7As7ksAR5cjx2+shFCMW0N3x4MrRjWk+HRUh4szh AZm2C/og6irUHAO12SP4zbDWGmRHPBTlNJyfTWHpDMLCLKRdhGwWV+YTRc4oggGjCVJeibD5Sms JO3ylEPPObShzDd9mt1B7PKhJ49liA6B1AAh+gpZI1X7PpciGXBp7Yo+5Wykz4mv6KmnbA0peSu PfqNB58XV2NTX4MOfPg2mf4dPSZ/R1PBTbY14m1GmzeLqsHJ8PJ6d+oVbbcBFzhZRAyS9CdzCdl VaNYbbIreOEZAtWFZn6WF20f7Jf+ueFk8GizTABT0hwFBnEU1CgJG5klVXRtFa2tSbQB/FDb2GC jtHSJq8UgFzyqGAP9eQY9gJ9Xkw84bRFRdmRbGF7q/MD7X38nnoIbovTD8S7YB42hcSCB461pOo KH00N8AF48xB2g1qzh4KwwuxWK4Bj6izPKF1co7+nRGd6OOWFlktGGZt9kNUStLsar0x7uX+U= X-Received: by 2002:a05:600c:c177:b0:488:a82f:bba9 with SMTP id 5b1f17b1804b1-488fb7804f3mr383647975e9.22.1776974750505; Thu, 23 Apr 2026 13:05:50 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:5f44:38d2:bccf:b54f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb135asm59683343f8f.6.2026.04.23.13.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 13:05:49 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Marek Vasut , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader , stable@vger.kernel.org Subject: [PATCH v3 1/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in i2c probe Date: Thu, 23 Apr 2026 22:05:46 +0200 Message-ID: <20260423200546.324187-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm_drm_bridge_add() so the bridge is released if probe fails after registration, and drop drm_bridge_remove() in chipone_i2c_probe. Signed-off-by: Osama Abdelkader Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support") Cc: stable@vger.kernel.org --- v3: split the patch into two, one for i2c probe (bugfix) and one for dsi probe, and add Fixes and Cc tags v2: devm_drm_bridge_add instead of drm_bridge_add --- drivers/gpu/drm/bridge/chipone-icn6211.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c index 5bee10c64265..4d76e1bd5e78 100644 --- a/drivers/gpu/drm/bridge/chipone-icn6211.c +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c @@ -758,12 +758,12 @@ static int chipone_i2c_probe(struct i2c_client *client) dev_set_drvdata(dev, icn); i2c_set_clientdata(client, icn); - drm_bridge_add(&icn->bridge); - - ret = chipone_dsi_host_attach(icn); + ret = devm_drm_bridge_add(dev, &icn->bridge); if (ret) - drm_bridge_remove(&icn->bridge); - return ret; + return ret; + + return chipone_dsi_host_attach(icn); + } static void chipone_dsi_remove(struct mipi_dsi_device *dsi) -- 2.43.0