From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA013112BC for ; Thu, 23 Apr 2026 20:06:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776974771; cv=none; b=KxjSH5zTzdCHy+YlNVi/TYskV8cE4twwtfoTkREJ2MWd7gej5EWl2dvTvZucZcnf3WhaX5DmyT+aHv+3dR5MnBofl5nrwlBwzaZM/4A1wQbTkncCzPfIaK6gVU/oB0i5fFi72VdjdqTVew81gLB788wwCCUfg3inpYq9IcQ7tzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776974771; c=relaxed/simple; bh=UP22mo+1wZjNYDgDQxtMRxyqhmZg1rVfPXE612H9eMU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=miQxA88EBl+wiy8+Y+leLGpOSCBpYKV+rT+EBllwSev7QlK5l5fRywsi8Ht63DYPOrVUsQfwYt94PXxWWamSoLLon1kzooot6bZk+WkNfDolCyzbOcFBsLsjQKKA52SHv1PzUCYzOM9kY9rRXTteHPeRYgTge+hHOBJNE7FfwzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AKTiycWS; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AKTiycWS" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488a88aeec9so90389645e9.2 for ; Thu, 23 Apr 2026 13:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776974767; x=1777579567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HpqVbCOfb49tloiiXQzQRUfJweaRdlqFCYtMfaiIiMY=; b=AKTiycWSIcypHJtdr8XulQn3hJ+um61BUYh5HiuLre8+/VOB1cdl3BBaCDDx9GHbqn 5y1/kUyqO6NuQrxayAls8uM3nB1qWsiSs8FG+uXw37pwgZv7yMsSQMvkD9jvlp3eQza4 NlSWz7C7Ngeno0PR1b1C9+1g1Rk3a2VM8Vhzc8a/w+wkgf1bwbQ158xVOV/ZYG2KeDns pJgR6nxiR1K5+mBMM9wxeBwFR7B0CBnd3hbdxK7v3P8k/hLzbu7ZJpjqAnRResqDo1vw /1JKQ5ksiilipFiBjDV1JK+jI4UqXweX4ZlbJPdHs5JH+GAjLqrJ4m5VpCeaMsuUTfhj npXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776974767; x=1777579567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HpqVbCOfb49tloiiXQzQRUfJweaRdlqFCYtMfaiIiMY=; b=FZr56ARvt2cHpBgjUrw4RLR465QrgtEOPAraCjmw+sxjq9V1bL+j4SVgSw0Qe1BzhW K3fTIUKXeVlu9R/9MPnYH46QE3l0EfQcAIWqYyC7+yEnDytWj836VhfVRFTIEwnud14F VXJbWpWcskfhmGKT2tMxPQM8iXn0PB6wqZtYb+DjuI/2IiK0L39b7SEXR7qXO7QfUdsd BXNFJ/SfPN64FRN/rGTC2VkEBrUgHOpYiGTdteMMHkh/8gsKCxuYphVRLsFHvUhQ++OQ u24jl4AmyF7YflYqvFSl2IWWvyYEkZ+wKT9wJtgbYAAjeujXgv89DoQNTJIOo1motVFG t46w== X-Forwarded-Encrypted: i=1; AFNElJ8iiAOe/M+n1Q7KKjMFaPUdmPYebschFHZalG/if5AG552zKEebpN8NreEuaNb8/3eL4g9ksOu/eQEw51w=@vger.kernel.org X-Gm-Message-State: AOJu0YwtCEp8BWfyMNdIO7ERi0172pGVQ3ktWJFIrsHpF6nlrztUUtZl 0/jcXx/QesK/sj1/5VO8hvWf5av59BIPz5Of1GWbgvoRBHXFNEKLTeHn X-Gm-Gg: AeBDietLSth/1dSnSE4m/kKCbOMxSqluHBM7gfqks1siHWVVlXxMaw0E4b6VLkNrgcN mEDq42DQEaacr6pDWYejbkh270Grh7K1emWCIbI1f/fo520PVgjVf6y57TSNEuVn7900bvQuWsf pnElCFBoUtMyXzWlat0yWrAXzBdumGcrALOJzdhOgbmcEe4nMbGkjZ7vWtjpwk81KxrSK1Ve2/c mzIfsNj+51PV70r/FCN2XzepwRTsCYtgq8marLUYQHizGQY6MS8WexVHHqBez/4UT1Ct/YOGGIa UdRwTEH6Xi2uqc5Hx3ihvdqMMmrbMBUAAMftG/faGRPr3Z+xebzbj3CfEVxn6Zio1Z+A5i5rM64 dv1Bxd4GYiTdzcj0QrBOjPa+UOxNPX2wm/rML7vozXlGzSrjsHLjc196rn8hDsF/i1Ysj0TDSNe xVouQrSP3I4VbUi4MujgujqONit+rnEMI1ohRhn/7N5bEQdbldb7lfYohlBr6DabvAbk7HvGbzC VZ8rf4NBA== X-Received: by 2002:a05:600c:4509:b0:489:e126:b757 with SMTP id 5b1f17b1804b1-489e126ba91mr231631365e9.25.1776974767267; Thu, 23 Apr 2026 13:06:07 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:5f44:38d2:bccf:b54f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc10019bsm552934705e9.4.2026.04.23.13.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 13:06:06 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH v3 2/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in dsi probe Date: Thu, 23 Apr 2026 22:06:03 +0200 Message-ID: <20260423200604.324615-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm_drm_bridge_add() so the bridge is released if probe fails after registration, and drop drm_bridge_remove() in chipone_dsi_probe. Signed-off-by: Osama Abdelkader --- v3: split the patch into two, one for i2c probe (bugfix) and one for dsi probe v2: devm_drm_bridge_add instead of drm_bridge_add --- drivers/gpu/drm/bridge/chipone-icn6211.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c index 4d76e1bd5e78..f53e64129ebe 100644 --- a/drivers/gpu/drm/bridge/chipone-icn6211.c +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c @@ -730,13 +730,11 @@ static int chipone_dsi_probe(struct mipi_dsi_device *dsi) mipi_dsi_set_drvdata(dsi, icn); - drm_bridge_add(&icn->bridge); - - ret = chipone_dsi_attach(icn); + ret = devm_drm_bridge_add(dev, &icn->bridge); if (ret) - drm_bridge_remove(&icn->bridge); + return ret; - return ret; + return chipone_dsi_attach(icn); } static int chipone_i2c_probe(struct i2c_client *client) -- 2.43.0