From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12783263F4A for ; Thu, 23 Apr 2026 22:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776984202; cv=none; b=ql+Btj5Cx9ul+ayHrhipuVAy+ouj8oc7O+6ceVjnhOwskgERTzgsXIjUq3y9ltgQhyFroln9n9xJ07GipRC9hxJ+03EGCkV7zzgTFaA+AGvgi3PsAeCNzinB95bkAlycedAAKgU3ViFJl7yKsG2Lx2lXcGcUfGNC3/SEQcgCA00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776984202; c=relaxed/simple; bh=CBu0C4Gbw+eSGJTiQmDn0Va7Mzdh0sn3nL6uhqMgdYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DVO4IzeigUaul/t9+qV5lo+E5IAYCraQccgN5sYPDh7QbHwvaHZlsnv5TOObpc3dOYIZO0kkgEX+wzBD0x8NOiNcQuyVI8MeJeU3vf9x+sOb7JaZrJVY4J9rF7hv59bdvJi1IgELQSQ7d1V8u9UgeG8gTVwoCKPzj0iWpBOxH7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=D4byo1ec; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="D4byo1ec" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-8cb5c9ba82bso1107507785a.2 for ; Thu, 23 Apr 2026 15:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1776984200; x=1777589000; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/T0GTDRuU/Ml1Jl3QzhDeR+2ndhb6qBdCM6HZ+ROdk0=; b=D4byo1ecu182ZU65NYkcLK45iIq24mCIKDJQpNLU0ZeV+bCkJHlGiJyPcDX9CdkGp6 qrZAWy1Ds8n6lTl2ThtzakQ3rl4gGSmUeTKgUnBgNEik38F377NrL6JFh3qLcclyTz7u 9MF8O9cjEHLcqPRh1Ut8ng+YSmRO+Cam8MYEF20HJKFvLu/S0npvRrY7YpW1UJ6YEgOj HqLLgs2EB6dEyIB192AOFRBSR16R1uU9fgMb6oxvn4K6Q+gwR3aZHDbQXbA47FE/Zmj9 zd0VSjoM/RKeVzQIDmw7hIjzTafTI5O90HbieMEBIWDtH2iJ+wxZREXguFJz6nnUAXHx 5TGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776984200; x=1777589000; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/T0GTDRuU/Ml1Jl3QzhDeR+2ndhb6qBdCM6HZ+ROdk0=; b=P661w2yJs5fIxx/mw6geesVyscu9XaRyqg7NjcrJEJfuW3Xb7pVA/r3ocKARUnWucO jirCnoc7rFHDvAmoM0MiEyI0mtHmBH7NLj4lGTSOBqkxv3Yy37QScqiQOANVU6rVTd8E j5UnYAVZzfRdrAf7KnQDlKxOh2XbM6znvWv9+pRchNTAm1e0+WX1b9C0VxJh/idmguPL oAAu4b5dvIC+KfRwOOurAomJac9dT3NjgQevqiwgeze9xcuR2OlVA0ERETHQ/ceiDrad LjlbPDkBi4K/oBugniShJEcYQXnAkXNQSiIGjQz52m7gQq7bu7LvFrqmBSFUbHwS42aj fAvg== X-Forwarded-Encrypted: i=1; AFNElJ8y2YaxCLETeb6/k0tYvivycIKLB7eH+52HbvLGm2y7CFJpULRaxUwjgS7Dn/A4A74LVd1MvAfcQPR8oF4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf4nob51h1vCYmtE8ihkzlp1bnrllsCc/VBQ7VAFMFIiVGn7Pc LA+iW5kvDZIuUxvYA40ZjX5zDj6uZTqsRToX7U7jl6V2iIW8Ft7zwid4Od9iT3kvnEs= X-Gm-Gg: AeBDiev0Zi11pyianKDHzuF0WXetzBY2TUoX2jKglXi5AOPVT6omYFTxKKYfJ6iobTS DDkK8Jkt5cjD2hG8lOIZH2KY33N15vsNkMPd5+tALeiwfoVbFt5GZndQbWiNBTq3+SbVuO8ox/j srwyvcv4CIkRcxX5mCBlq/8ZGlvzerrZVqyyRDuv22IsFlrsFwNifwP1uwLVtQqEDlCjmvGMFsj JO1YvxCE+/QZe8r6weS86ageotW453pJxJBx7f8ZitReuAISWQhZwiviUEiZ9u5Mnmx8mVw/4QH cIS+JMNHh2KtlEmUmIVEvi0++++bm15jl+TBwcaT7sONVymcj6OvIS71LDNu89AcoTtwVVV4Rfg TxJnjozQ8mg5+8w3jhys7nh8w/EugTB5QS/rA2yi9q6Hc6+MQWnXFe2C66nHNNZasDqt0jkir6H vDQNYpkZdzf6+lPZGWhrgLtuk3qH4IjZLVwgPSsWUlc106ztbXDofCGJ7MdEYggBm0NvGUPcqUc mu68Q2xKb41A524rjrLEUmYzw8= X-Received: by 2002:a05:620a:3187:b0:8f0:7516:da99 with SMTP id af79cd13be357-8f07516e40bmr1047695085a.60.1776984199901; Thu, 23 Apr 2026 15:43:19 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02aec3a3bsm169316686d6.49.2026.04.23.15.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 15:43:19 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wG2lS-0000000GLHD-1ruw; Thu, 23 Apr 2026 19:43:18 -0300 Date: Thu, 23 Apr 2026 19:43:18 -0300 From: Jason Gunthorpe To: Vidya Sagar Cc: rafael@kernel.org, lenb@kernel.org, saket.dumbre@intel.com, lpieralisi@kernel.org, guohanjun@huawei.com, sudeep.holla@kernel.org, will@kernel.org, catalin.marinas@arm.com, joro@8bytes.org, robin.murphy@arm.com, nicolinc@nvidia.com, praan@google.com, vsethi@nvidia.com, sdonthineni@nvidia.com, kthota@nvidia.com, sagar.tv@gmail.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, acpica-devel@lists.linux.dev, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1 1/3] ACPICA: IORT: Add Root Complex PASID Flags field Message-ID: <20260423224318.GT3611611@ziepe.ca> References: <20260423191417.2031652-1-vidyas@nvidia.com> <20260423191417.2031652-2-vidyas@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260423191417.2031652-2-vidyas@nvidia.com> On Fri, Apr 24, 2026 at 12:44:15AM +0530, Vidya Sagar wrote: > The IORT spec, Issue E.c (ARM DEN 0049E.c, January 2022), bumps the > Root Complex Node to revision 4 and adds two PASID descriptors: > > - PASID Capabilities at byte offset 33 (2 bytes), bits[4:0] of which > report the Max PASID Width supported by the Root Complex. > - Flags at byte offset 36 (4 bytes), bit 0 of which reports whether > the Root Complex itself supports PASID. This is distinct from the > existing ATS Attribute bit 2 (at offset 24) that only reports > whether the RC forwards PASID information on translated > transactions. > > The ACPICA struct in include/acpi/actbl2.h was updated for the E.c > PASID Capabilities descriptor (offset 33) but stops short with a > trailing 'u8 reserved[]' flexible array, so the new Flags field at > offset 36 is unreachable and the existing ACPI_IORT_PASID_* > definitions have no consumer. > > Replace the trailing flexible array with a fixed 'u8 reserved[1]' > followed by 'u32 flags' so the struct fully covers RC node revision 4, > and add the ACPI_IORT_RC_PASID_SUPPORTED mask for bit 0 of the new > field. With #pragma pack(1) in effect for actbl2.h, this lands the new > field at the spec-mandated absolute offset 36. > > Signed-off-by: Vidya Sagar > --- > include/acpi/actbl2.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) There is a whole process to change this file, I went through it once for canwbs.. https://lore.kernel.org/acpica-devel/2-v3-e2e16cd7467f+2a6a1-smmuv3_nesting_jgg@nvidia.com/ You have to make a pull request here: https://github.com/acpica/acpica/pulls And then use the generate/linux/make-patches.sh -u Script to make this patch for linux in the perscribed format. I think, something like that Jason