From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ACC43D47A8 for ; Wed, 13 May 2026 07:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778656284; cv=none; b=Xewjl7GtQ1Q8g6KQVZIcbCP7G8a4H56PrOOu5FYfxJgIcjapv2UDFczLZDdIdfQYKe1j57yIzfprS8WrJJAJ6QFJ1hRb09s6Wr/ubXlTaWneIh/PdmUzb48F8R2tdD1NNSRJI6MV1rM4y58zAbjJIpe5eTnw9DNxeNvoq4zyVNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778656284; c=relaxed/simple; bh=h207wMrvvV1Ldhg9nEqnfEuJuI1hYIKUwGDHp11u7W0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ip9lef5JGYYigv8VRUMBmmrkdpG/GkSbpnhBPxuxEIwJyFrTKugG9w8Mq6tF7xOK7UxAtNiR9toa03ec9AkokJby/mpULStbTuY0k5Kqr5ZmS4xmAIYpm3uj/XPBX02IFrEJd71Dx44rBMP/gkVZtbHqHVj9ItFPuxkWXJ/aF8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fkqUwRsc; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fkqUwRsc" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c82471904fcso2800309a12.2 for ; Wed, 13 May 2026 00:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778656283; x=1779261083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MAUm05/737IqhRNlo9FHhqv1K5HUvIKv2GcQLIvOcf0=; b=fkqUwRscrIpiH5S4k59HNWP6tdm9p4fhLeZqKE6uwF9QcRdWlPXOlzsKYCqQQi50s6 cYtGGmgRZ7S2vnArXNH+pAVC2hiO7+xCW8qo25t1bivGduMMsu9KLXMoCMRlY4iyKzvq jJ8sgwFtg79lqFWArqsmL+dVcQzRnbXzYZfZsxUWEAdnSTWliY9sOlJV2iY5teS9usig 9gq+W08qB1vH+tkBDBDz5iHO9qrK9GjWfMGJYkE8BtG06k3dRpk9BMevHmHBH9g0/aVj 8t0RxuXTYY9s4IlnSm8Mj+VtC8VdTJ0k6O5i+bVfDAL0I7gtGmxLzPW+YEApWbPOh/vi GyhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778656283; x=1779261083; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MAUm05/737IqhRNlo9FHhqv1K5HUvIKv2GcQLIvOcf0=; b=djAg+3PqLeK1k3uatv8bPRkoIqJcuC75qacrbTh03iTMqLpKRqf9XLU/jluiHSW5Ix +N5u/3tJ/QnkRwfkduRbMH3PGDQdXydDGHjloEKehykVU/4hnPU9HGitzNh/Bo3MG5eG yt7DrmX3p7QdZoRVwLSpa9YvbYBJULPaElvKPZuSTeXmTj28mg1qIQPxHAe0MeXl4Ot1 ZuXuQwrE4LgYBSPQwNKdpFV6xUt0Ha+sXDUPIn6k3h2EoL17KBOuoii+p0vnuIMKVRXK iNu1hXAY1k9eC6BMrERSQKJ2aqxBjJPr6F3qFLboVQZoQq1exbhZb1+yWUMIVnP9UgN3 EJsA== X-Forwarded-Encrypted: i=1; AFNElJ/UD7ehPy1P5ZYD8xjHH+Cv0EyJY9Yfg5auP08/DMRLCx9M66s3nbjGILW/MMfgnxZ8iGxoJT+eQ54dwyY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0oQcpaMMTfDHoYNqIYOTdqpGN2ZhxpE0PZOv4mNH8quKmJYgX g50s8F3I/WH4NFNQB8hsUg1KF4pC4YqsSf4Flna+6H2vDqbmqluwjo0= X-Gm-Gg: Acq92OGKKvxzkJdUSjHWQ5IiDMQk25B9w7b2jhJl2k3Exx/SQU2iRReX6plEO1vpTPK 1Pwl8ZVZ1Tyxd3emzM+TewsXQ3/0WHsuySCyHtbt5Tzp8xPXw3Siwox8gs/TELJKmzGC0jn73nJ dGlM1UoWuPqIZhZAnIWCtpfgJ+X4hdfsqUM0oblN0YOK/qaKcYxpk/1CJ+9X9c34+bXMa0I5WaE bQVqFiXFa3flsTrLZYAxPTodKym/nYATzMOJPaiedtpFl1rX7J398xykt8c0l3fUq/NOVdsyf7N D6Zin4gqhzDADrfHeMC2qfjG/4ypzN+QMbGrVQl1bXAdMljFxnL/AnvkQe/8IgTblL7TeB8NwOV EEniLy8Gu6WUsttg/wNsfMqOmKTSa3Mis5/GtxODNOT3kthArVynXpS7HZuQ8Ppsx4jYy+hIBy/ N2cOEflDdrG6dL68E+eyht1kQJ6dzNZ5Al2QTTKvAkgW8+ykQGG9TFOrUKhqeZmOaamuLWvhs4n v6qBfS9QNXTkhYSBAU9OKRpdEv7oJSMEDcdVzw= X-Received: by 2002:a17:903:1448:b0:2bd:2458:50d4 with SMTP id d9443c01a7336-2bd27706be2mr20525425ad.41.1778656282606; Wed, 13 May 2026 00:11:22 -0700 (PDT) Received: from localhost.localdomain ([211.198.234.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d405efsm165677855ad.23.2026.05.13.00.11.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 13 May 2026 00:11:22 -0700 (PDT) From: "=?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?=" X-Google-Original-From: =?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?= To: Sean Young , Mauro Carvalho Chehab Cc: Myeonghun Pak , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ijae Kim Subject: [PATCH] media: rc: sunxi-cir: unregister rc device on probe failure Date: Wed, 13 May 2026 16:11:03 +0900 Message-ID: <20260424000000.558-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Myeonghun Pak After rc_register_device() succeeds, later probe failures must undo the registration with rc_unregister_device(). The current error path jumps to the allocation cleanup label and only calls rc_free_device(), leaving the rc device registration and resources created by rc_register_device() behind. Add a registered-device unwind label for the IRQ lookup, IRQ request, and hardware initialization failure paths. Keep rc_free_device() for failures before rc_register_device() succeeds. Fixes: b4e3e59fb59c ("[media] rc: add sunxi-ir driver") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/media/rc/sunxi-cir.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index 92ef4e7c6f..cc64a68dfe 100644 --- a/drivers/media/rc/sunxi-cir.c +++ b/drivers/media/rc/sunxi-cir.c @@ -344,22 +344,26 @@ static int sunxi_ir_probe(struct platform_device *pdev) ir->irq = platform_get_irq(pdev, 0); if (ir->irq < 0) { ret = ir->irq; - goto exit_free_dev; + goto exit_unregister_dev; } ret = devm_request_irq(dev, ir->irq, sunxi_ir_irq, 0, SUNXI_IR_DEV, ir); if (ret) { dev_err(dev, "failed request irq\n"); - goto exit_free_dev; + goto exit_unregister_dev; } ret = sunxi_ir_hw_init(dev); if (ret) - goto exit_free_dev; + goto exit_unregister_dev; dev_info(dev, "initialized sunXi IR driver\n"); return 0; +exit_unregister_dev: + rc_unregister_device(ir->rc); + return ret; + exit_free_dev: rc_free_device(ir->rc); -- 2.50.1