From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F6ED2264A9 for ; Fri, 24 Apr 2026 03:34:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777001641; cv=none; b=Brnfli2xtaI2esEuirqMHOacdiQd3LtAwQgbkDArXPMdAf84ZVrtGR+ynSoI9NLEuuAjTSLw6AcRINF+bH9XeRs629bLp+0yTXC7fgBPCm42d9BGisXfbjb9GFkqGLEW40jFB3K7+R+ru9YRtdo/qs9de8gaEsPrPF9m0dc9Z60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777001641; c=relaxed/simple; bh=0QosxY/o8tb5B1JTDe6dmHhKbgTsbsBuSRx2bY8e0xQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O/MWf9sFYwOG35GNHcTUWdFzXDyI9p0f4yRcOowbl2raQmaGXwkEoSwcQ5UX5V3gtWSFl5jSK9DXVxlSCL83cfCvpvv4BmNHsYs9lBw/rQT5TOvd74vRklOndEmwfsqMmjDk0SqoXzlWqXO4aCpy9ejbhcwxA5rV1yJiL4H+0dQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qTB8tU3i; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qTB8tU3i" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c795f441ff7so5036396a12.2 for ; Thu, 23 Apr 2026 20:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777001640; x=1777606440; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gKZeI69AMY1zWybSYtDN8RDRjMihnobL/AcJ00QScLc=; b=qTB8tU3i60ZkW0mNwY+wvqEU3BSm/bxn2dh1BD0nCst9sg5To596uy4Wlnhj7AC7R5 PQWHPiBeCXL4b4sI+GFIb0SoA1LahNNz9IbLZyUWszH+EqIG+BzvBQTsy6IsJfSuGk7w jPPcgHNl/qwB2NeNXAd35QMgF0fySWcNWt/vyfmX/Z1EDMF7v3F9ciovH5BRU4ZeKO/1 80LCS9iEKHFgKO4Q+/NKMfsSJ33MVKlvJPb1vr1yTIZsK6e3XUfDaOGpO+mHr8w7cmeK 4AnW4Hm9wW/x9hgHABjY5X5aUJPQsFvKtfnK6qfV65xMdx2PNKM48MCynSUWD6cLkQd+ IzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777001640; x=1777606440; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gKZeI69AMY1zWybSYtDN8RDRjMihnobL/AcJ00QScLc=; b=je0SwiNFRvhUM4pYb/HC8tg3EHQQ4Qf8UQZRaggqgOs/fIdi4OITx49cYUGiKMl36+ k5KccQqRKEZaVdw7DA3TE6p6/xzsCh4SU5HT/QGuAUiOcAysFwUR3r1+2mY0mfFfRrqv byzFRV5vkJUPPrZFUGwiPl/TarTUJDFUS9TD7nkj6P2NqWmMa7dvdAsMeOYk3IKuRwS7 fL2nQ5hIUlOa+pIXdrew/7abzZapUG1/4yTHIp3rtoIT5JZ1q/Oorney2D+xbFP7GuzF S7tv8RuabDmVPY3b9J1XvBrUkDgLnNBdH10vee2j7kNN5pGnnizsPj0HmaFBZeKtAaF2 GOBw== X-Forwarded-Encrypted: i=1; AFNElJ+Dg1E7g+60G+ApeKS1rYsm4nrL4R+6MH9qQFxsuMbetc1s1lOdMUuB5eehmB0/pObS15UEd6xa6//coFs=@vger.kernel.org X-Gm-Message-State: AOJu0YypnVg/lfciUQr1C+9oWbIg6vMlPKR6BQWu0rQ27EY28r8Vbzuj MvEkuThVN5bwMAL76lTwbA1otU0GaaQ6+nyXKSs2wOemEwhEUMQnKFvV X-Gm-Gg: AeBDievAlRhpuuxsiC4VZW5zQhHTUdHBXF04mGedyt8uWkQL4OHKpA7P4bav1oTWRhc bFROdI8P37EfcRP0Nl4XYebFWcHfpZ7spXHyGTtlyRSAPJu9oAEikoYG/bPNUsrFzBM1W9OM3KD 0DsOtsBBU1YKoedwl1dZZ/B8UFY/6hQK9tzGBjpwPF3PEv8gF5Usb46iq5jL6wv++DK2b4p1ccA kxpeJ7s+5XAsMYsT/xKmyBKO8qQVwE3U8l1dG6HRSRw0Yj4BQxFk5gRvCuhZC98uXCT3VGkImfF ieUHYcIb8Q+G+a9LWwguGMJCYIhQk+wCUy87lUZ8B7/rnL6CthteeYphe56xPgMAOmLVcH9imWG Y0LlIbffvS4CUByu2UvxagDt3dXtJLFfB9voLPxbRxvs7bSC2LWM2mL760wllE2jHgAYfljwLUR dF0B7iahG8WnCpCMRR4HARjV4E0nwc4O1u9qQGNRd7cKd7d56A/gyphBf4syL7Qd6/XKyU58P+ X-Received: by 2002:a05:6a00:928b:b0:82f:6dad:7b75 with SMTP id d2e1a72fcca58-82f8c8ebc91mr33576208b3a.33.1777001639902; Thu, 23 Apr 2026 20:33:59 -0700 (PDT) Received: from ubunut-vm.. (c-73-240-82-137.hsd1.or.comcast.net. [73.240.82.137]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9cbb1dsm23797624b3a.14.2026.04.23.20.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 20:33:59 -0700 (PDT) From: Joel To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Subject: [PATCH v2 2/2] sungem: validate BCM5411 PHY register reads Date: Fri, 24 Apr 2026 03:33:48 +0000 Message-ID: <20260424033348.1917-3-joelcrouch@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260424033348.1917-1-joelcrouch@gmail.com> References: <20260424033348.1917-1-joelcrouch@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check for -EIO and 0xffff during initialization to prevent silent failures. Add error logging to gem_init_phy to report failures. --- drivers/net/ethernet/sun/sungem.c | 8 ++++++-- drivers/net/sungem_phy.c | 7 ++++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index 8e69d917d..525aba527 100644 --- a/drivers/net/ethernet/sun/sungem.c +++ b/drivers/net/ethernet/sun/sungem.c @@ -1707,8 +1707,12 @@ static void gem_init_phy(struct gem *gp) sungem_phy_probe(&gp->phy_mii, gp->mii_phy_addr); /* Init PHY */ - if (gp->phy_mii.def && gp->phy_mii.def->ops->init) - gp->phy_mii.def->ops->init(&gp->phy_mii); + if (gp->phy_mii.def && gp->phy_mii.def->ops->init) { + int err = gp->phy_mii.def->ops->init(&gp->phy_mii); + + if (err) + netdev_err(gp->dev, "PHY init failed: %d\n", err); + } } else { gem_pcs_reset(gp); gem_pcs_reinit_adv(gp); diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c index 44cbe1938..ec8800c93 100644 --- a/drivers/net/sungem_phy.c +++ b/drivers/net/sungem_phy.c @@ -296,7 +296,12 @@ static int bcm5411_init(struct mii_phy *phy) sungem_phy_write(phy, MII_BMCR, BMCR_RESET); sungem_phy_write(phy, MII_BMCR, 0x1340); - data = sungem_phy_read(phy, MII_BCM5400_GB_CONTROL); + val = sungem_phy_read(phy, MII_BCM5400_GB_CONTROL); + + if (val < 0 || val == 0xffff) + return -EIO; + + data = (u16)val; data |= MII_BCM5400_GB_CONTROL_FULLDUPLEXCAP; sungem_phy_write(phy, MII_BCM5400_GB_CONTROL, data); -- 2.43.0