From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C89F2EC086 for ; Thu, 23 Apr 2026 22:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776984583; cv=none; b=VynIPapcHXGa9ZRgXAfXb3Dcw1Gc42JiOnKvlsQJo5sM7QO6im0SMZTA/sY43erWZI3Kz+XsgEm68xdGsA2H+/AF625LVIM6oF+TGtJN7XxBrjY+4kWNqcD/ny1pn8CGkyrhuuIDlh+FwCrQYAgwniiJexYBT2KQBijb+YU+z3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776984583; c=relaxed/simple; bh=I8DOdQboblQuRvZKjK8L3HPUcg1B+69Hl309KtF+QDE=; h=From:Date:Message-ID:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=hUZwMEh3Y0Jwd+Brt5XUdu58uXcdFGD8Qqzz5BIyY0bDvNvSWAxuwC7W2ERotPORbi21UCOV2gDg8BzHZ4zOMrYWqr9EnkAzHwvC58nUF0o5QpJCc49tXIxxZUUhso2C3MzPmssUPmPVV4ktC34Qx/xTAQzNAFQ/dDnHtW8Z1+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from 07-params-reply.eml (unknown [111.196.245.116]) by APP-05 (Coremail) with SMTP id zQCowAAHlQj7oeppTYNsDg--.55784S2; Fri, 24 Apr 2026 06:49:31 +0800 (CST) From: Pengpeng Hou Date: Fri, 24 Apr 2026 06:49:31 +0800 Message-ID: <20260424070107.1-params-reply-pengpeng@iscas.ac.cn> To: Petr Pavlu Cc: Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Kees Cook , Dmitry Antipov , Thorsten Blum , linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: Re: [PATCH] params: bound array element output to the caller's page buffer In-Reply-To: <20260417075042.26632-1-pengpeng@iscas.ac.cn> References: <20260417075042.26632-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:zQCowAAHlQj7oeppTYNsDg--.55784S2 X-Coremail-Antispam: 1UD129KBjvdXoWruryUGr4Duw1kXw1xuw1xZrb_yoWxZrc_Cr yrKryftw48XF4xG3W7CFW7Wr9IgrZ7urnrZ39rKw13Jw1rZFZ8GFyqvFn8Ca1fWa18Jr98 JwsFyayrtF17CjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4xFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Cr 1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r1q 6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxV WxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUL0edUUU UU= X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Hi Petr, Thanks, that makes sense. I agree that adding an explicit size argument to kernel_param_ops::get() would be the cleaner interface. My patch was trying to keep the fix local to param_array_get(), since changing the callback signature would touch all current implementations. My inclination would be to keep the immediate fix local to param_array_get() first, since that seems more suitable for a bug fix and doesn't require touching every current ->get() implementation. If you'd rather take the interface cleanup first, I'm happy to work on a larger series that extends ->get() with a size argument and then uses it in param_array_get(). Thanks, Pengpeng