From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 896312F5321 for ; Fri, 24 Apr 2026 08:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777018547; cv=none; b=BZTie2Q5NzkliENZW8ew17c3Z6AQfq9gzhvxZ1KaiszQHf9x/zU+H6p55e5YK/3MCW0gb3VnlN4K3xNjDHvrXdsCy97saoNxS3hy4cr47PaET2nqLEUm2NXGXiVS43KFKq6dG0pI5zyeGDvYEsfHJcjK4LagXzPyN9f2SH5xPZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777018547; c=relaxed/simple; bh=undu5dkCTUgwl1M8+79fnIw1tnD/iD/mxZTBPxvLUMo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TjlgC+APwoSua4r7ebZPkytU0mrvYXPnbLTdMZi9zGNVPBAFIr486AzxCZNcpXPFvOd5ovL+5v5isq5PR85pC/OlhS9sxfE3wtWeKuXFj48whb0wSkPfSdRAAjMuZ3tOttb47qkQSDL8sqiCACpa/MNNu/S6w8OO9PvhokFfA9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pr4SIXeL; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pr4SIXeL" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-82f2766905fso3533786b3a.3 for ; Fri, 24 Apr 2026 01:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777018545; x=1777623345; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Qcv3yPzsXnW5c+HXfigOkDMAbuRYnw8S8vUv2u2wfwA=; b=Pr4SIXeLJDnpDBGlC4ysqgqrZ7WSGX1UbMsb8KKLxiUzN6g2acvnDQt94H9qJqMARo NNo35ievTIsfOLhZ7JN8Un3v1CaAA0G81XD8MGX1PJyLiO5KfDXLEfFDBXae4F6freTV dci1SU4hUswRubUnDAO+w6qyY27Rk1idC3q5Ax3VJTsVLk7S9Ahd5hyLt/VD1pLyBmCq Dg562Dwac3lh2n1vNyhx3H/hNOM3KZQdjMn4An0beg4bTa2T55/6cVFm9rsxWFm9DOeb c300IeYUBuOJ6E3QRwMBkZhvAZq2UJg7Nm8BHOPeubyLmw7uZ0YcMy7TU6c1NwUnP3OP If/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777018545; x=1777623345; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qcv3yPzsXnW5c+HXfigOkDMAbuRYnw8S8vUv2u2wfwA=; b=U0vNJAFsQ5eRQO+ZLOtPBrd0XxI73l2BAgMpBgONlP+bFGZKRqA0x4JrMKy6OI3JOy VYaY5Fj6yindmVdNM/LEmsbcvxZKtlBdGThrqqYr9BPeCP+Dg9ZR+7fx+k+Ew2FetmcO OCXMTPF8lNnisCYoRafWbr8XMi3pmSihROWj+z1Yk7FGubUFg3qi091P+L8rRH45EZ7j iIK75UTSwjLaVef+HZc4W4fDkG7OUHQrhyOsk9DdX4npr2UdnP6x3ZLU1PbJuIul722/ yGUmJWqXqrOdnsbsVLbXJJY6TgYK6SytLh/9rHpGNT79+uKEspRTCLb1C6hAvr5V/Ca2 UVjA== X-Forwarded-Encrypted: i=1; AFNElJ86eUABfKVkCGk2ys9hhHn9jbRss4ElJzWmvvQCWZ776ka190TI7u8YyvgW9QeRLnWDxWGWwni0I+v+/G4=@vger.kernel.org X-Gm-Message-State: AOJu0YwKmWryTIcLMNJQM/BkQjsGGwX0JqBXKQoRAcICnIZNkDfRVvSW 19bqsZ/TFeuFvJVv4spqebLsnhNmkJ09H1acdFlRWdVMtP50R+LpA+H+ X-Gm-Gg: AeBDietQdjceyOGsnShBu0zyjcpct0SH81iV9IYZ6PDddEwH1GPaLdD6fQou+c8inz8 dlc9YO6YK6VF5yPvPTgejKxIR5R7IZ+QUL7p1oJ22z4h0A5+ag0bg3Ianejl+nFwV1b+b10GoQT wKVSbfDhV7M9gubbr266K+1YYed6D8RTF8aZ51tGzlmCGnIftmtjMVCBXaOlRs3r3TCIg0b+393 KjwyMrEebgCI48bF/qD+N159uCvb92YeeXfMTXgAxii1pU/5hF1/0WMIIdG9iyQekgkyN2VyqZ1 RvOH1pesaUAa+6+wofsbsCR7SSzLoEpzvcfJcX4JN/tdAqVEo9b/ytwE8BxaN8uwvKk14l4qK8O o0EWkyksqrrbJWpPpcGumsc3pvCco3P56b8rWMCadMMEH2s2Y6H54NKfALMxnik536Yd6LK9P1D igu9+apgZeOwKuoG5hacD5ILJW+yBmY2TwxwuF X-Received: by 2002:a05:6a21:6d9f:b0:398:b95c:51ed with SMTP id adf61e73a8af0-3a08d8a3490mr34780945637.35.1777018544653; Fri, 24 Apr 2026 01:15:44 -0700 (PDT) Received: from soyboi ([2402:8780:1073:993:9321:304a:9347:5e0e]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797702fbfcsm17347848a12.22.2026.04.24.01.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 01:15:44 -0700 (PDT) From: Robertus Diawan Chris To: hansg@kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, andy@kernel.org, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: [PATCH RFT v2] media: atomisp: Add error check in create_host_regular_capture_pipeline() Date: Fri, 24 Apr 2026 15:15:38 +0700 Message-ID: <20260424081538.459564-1-robertusdchris@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When calling ia_css_pipeline_create_and_add_stage() function, there's no condition to check whether ia_css_pipeline_create_and_add_stage() throw an error or not. So add conditional check for the return value of ia_css_pipeline_create_and_add_stage() function. This is reported by Coverity Scan with CID 1408952 as UNUSED_VALUE. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Robertus Diawan Chris --- v1 -> v2: Add Fixes tag (suggested by Dan Carpenter). v1: https://lore.kernel.org/all/20260423060246.296986-1-robertusdchris@gmail.com/ I am not sure if omitting the error check is intentional or not, but from what I see from another ia_css_pipeline_create_and_add_stage() usage in the same function, we check the return value after the call and return the error code if it's non-zero. I also don't have the device to test this change. drivers/staging/media/atomisp/pci/sh_css.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c index 6cda5925fa45..6aa8a883cc76 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -7041,6 +7041,10 @@ create_host_regular_capture_pipeline(struct ia_css_pipe *pipe) err = ia_css_pipeline_create_and_add_stage(me, &stage_desc, ¤t_stage); + if (err) { + IA_CSS_LEAVE_ERR_PRIVATE(err); + return err; + } local_in_frame = current_stage->args.out_frame[0]; } err = add_capture_pp_stage(pipe, me, local_in_frame, base-commit: 028ef9c96e96197026887c0f092424679298aae8 -- 2.53.0