From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9165D37E2F2 for ; Fri, 24 Apr 2026 10:36:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026977; cv=none; b=jXgBFko12geiGX1Exi9fZK6c4c9Qg7VMil9lQfbDFoIAxn3i/HO9M60KctnIOF8ILpDL53f3b78RBzQzMt8EP0vXDL6sP4pw0aN3fk4U1P+QqUtBuiD8DeWYaU+z9eg7jtmtUfzoFF5Y+cGX1WzpgR+xOgvMxcrZ9FSytk+itFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026977; c=relaxed/simple; bh=OpjYnvUINC0m/fERNUlL4a3+lpA8IFC0Re5p9y/suRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nTX8zFVYzwMpd8Y61v9YSvm8929j7QXDghvyPZazyEuvblORR1/6KdPcVj86vXqqlU9m61kVSO+LSVTWByMZuuXP84KXiOBDUj3G/X59wixHOOEmUVGfMTOp7RgcLiut+DeVgig7pzSSFZv1Ck2AAC1c89V6iw0ajX9cINZuyzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sL16H7ey; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sL16H7ey" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59B25C4AF09; Fri, 24 Apr 2026 10:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777026977; bh=OpjYnvUINC0m/fERNUlL4a3+lpA8IFC0Re5p9y/suRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sL16H7ey7V/GQEHl49RxmPmxt0qMuYIyx0svxOyJm+9h1kOYKKLw9BM5O/tJcdefi TywbChtKKDhRwkerWWpcn4wDAoi283d5Vbu5HLmkM+GOLJpVBih2esZPHSK/48tx5C CGAO4rl9o3e5dV9+QbsLQA2tGNFzPydSEK+9OBhFMXrl6VPZjUeawlsAPaOv/SJZ/E 8Lrw85IlKNzhwxRAByN9iZPVt349gQ3RROklPaMr1HtwhXzqWVWOWzc2pqZI55PuXh 3l8o/F/VS4cOddU52Qeo3PFccE23xjwXqGEwhXbhgeKSBtTZHqZhFH+4VbIaR+kJVW 98jdb1H3VGMuw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGDtP-0000000AyiZ-0pJG; Fri, 24 Apr 2026 12:36:15 +0200 From: Johan Hovold To: Geoff Levand , Madhavan Srinivasan , Michael Ellerman Cc: Nicholas Piggin , Christophe Leroy , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/3] powerpc/ps3: switch to dynamic system bus root device Date: Fri, 24 Apr 2026 12:36:02 +0200 Message-ID: <20260424103604.2616657-2-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424103604.2616657-1-johan@kernel.org> References: <20260424103604.2616657-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Driver core expects devices to be dynamically allocated and will, for example, complain loudly if a device that lacks a release function is ever freed. Use root_device_register() to allocate and register the root device instead of open coding using a static device. Signed-off-by: Johan Hovold --- arch/powerpc/platforms/ps3/system-bus.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/ps3/system-bus.c b/arch/powerpc/platforms/ps3/system-bus.c index 0537a678a32f..4ead6ccea259 100644 --- a/arch/powerpc/platforms/ps3/system-bus.c +++ b/arch/powerpc/platforms/ps3/system-bus.c @@ -20,9 +20,7 @@ #include "platform.h" -static struct device ps3_system_bus = { - .init_name = "ps3_system", -}; +static struct device *ps3_system_bus; /* FIXME: need device usage counters! */ static struct { @@ -486,8 +484,8 @@ static int __init ps3_system_bus_init(void) mutex_init(&usage_hack.mutex); - result = device_register(&ps3_system_bus); - BUG_ON(result); + ps3_system_bus = root_device_register("ps3_system"); + BUG_ON(IS_ERR(ps3_system_bus)); result = bus_register(&ps3_system_bus_type); BUG_ON(result); @@ -744,7 +742,7 @@ int ps3_system_bus_device_register(struct ps3_system_bus_device *dev) static unsigned int dev_lpm_count; if (!dev->core.parent) - dev->core.parent = &ps3_system_bus; + dev->core.parent = ps3_system_bus; dev->core.bus = &ps3_system_bus_type; dev->core.release = ps3_system_bus_release_device; -- 2.53.0