From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 900B7366046 for ; Fri, 24 Apr 2026 10:36:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026977; cv=none; b=KMn5rdzA5YVuSgDx+9fvi4F1EBfaBYUu4WcKK4lc787yueiw1C52CeUp2mLSDCslXm2flATkiwKZNFzxBt8uKC6ar0Nej+5FynW6qK5aJCNSMoYCV2Aqbfs3aPpVzTBJRF2VvoYZ+usq72pbWB6lWPC+01Yxrwmc94/qKaY28lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026977; c=relaxed/simple; bh=r7t9IjXKXmo4brGWblnNZdlBkkZXdXtKpLhAebYCUJw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QbEw0o1W8F33PfZlwyk0oGVwzzmLv7Ta4p9B5/nJglmZIpeUJZIkPooo6/797H7hWyGfdzCdGFzlkV+9BvO7fbG7WfB4oHeS4CBuYlK183NKp9+UfDzLEJtemZ1eS3XMrJqje5AyQMIaxGU7LSrWJjl6BSn/o1ZSZHGipB16VgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uhuDpIl9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uhuDpIl9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64713C19425; Fri, 24 Apr 2026 10:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777026977; bh=r7t9IjXKXmo4brGWblnNZdlBkkZXdXtKpLhAebYCUJw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uhuDpIl9/P8W25DmD4zGUUPjIEs4PGArX3GqU0qqG/dKcu1QBbVK620WbzuOcV0Fh mCArJVLlL4ksuM5CeqEkwLLc7LzEzeiUr6wJ0hh4guRWrl/ZcXYjoG17Lr2PVF5Gkq QyO4uEkytfkD3h1cIWYoRU/A0oA7krXkrDvNZDl4d9bh3YFHjuGFtWSmKCWRQySn3y UKQrbZs+yEKodPgcs+/hP0NRQe04fiq0qs9PeLsgPBTN0WDht3cN1HLygdra6eo4Lu NaZoehxIPU2hdr59PKcHb4x1ZIGnDetoOQBWfqO42Cu0Wo+LjZiRHqd85kApa1zRGv ZwC10VgN//vjg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGDtP-0000000Ayid-0ttq; Fri, 24 Apr 2026 12:36:15 +0200 From: Johan Hovold To: Geoff Levand , Madhavan Srinivasan , Michael Ellerman Cc: Nicholas Piggin , Christophe Leroy , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/3] powerpc/pseries: clean up ibmebus printks Date: Fri, 24 Apr 2026 12:36:04 +0200 Message-ID: <20260424103604.2616657-4-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424103604.2616657-1-johan@kernel.org> References: <20260424103604.2616657-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clean up the imbebus printks by switching to pr_warn() and pr_err(), adding a missing newline and making the error messages a bit more uniform. Signed-off-by: Johan Hovold --- arch/powerpc/platforms/pseries/ibmebus.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c index e3b41e2d844f..8797b2137d9c 100644 --- a/arch/powerpc/platforms/pseries/ibmebus.c +++ b/arch/powerpc/platforms/pseries/ibmebus.c @@ -203,8 +203,7 @@ static int ibmebus_create_devices(const struct of_device_id *matches) ret = ibmebus_create_device(child); if (ret) { - printk(KERN_ERR "%s: failed to create device (%i)", - __func__, ret); + pr_err("%s: failed to create device: %d\n", __func__, ret); of_node_put(child); break; } @@ -282,8 +281,7 @@ static ssize_t probe_store(const struct bus_type *bus, const char *buf, size_t c ibmebus_match_path); if (dev) { put_device(dev); - printk(KERN_WARNING "%s: %s has already been probed\n", - __func__, path); + pr_warn("%s: %s has already been probed\n", __func__, path); rc = -EEXIST; goto out; } @@ -292,8 +290,7 @@ static ssize_t probe_store(const struct bus_type *bus, const char *buf, size_t c rc = ibmebus_create_device(dn); of_node_put(dn); } else { - printk(KERN_WARNING "%s: no such device node: %s\n", - __func__, path); + pr_warn("%s: no such device node: %s\n", __func__, path); rc = -ENODEV; } @@ -322,8 +319,7 @@ static ssize_t remove_store(const struct bus_type *bus, const char *buf, size_t kfree(path); return count; } else { - printk(KERN_WARNING "%s: %s not on the bus\n", - __func__, path); + pr_warn("%s: %s not on the bus\n", __func__, path); kfree(path); return -ENODEV; @@ -447,20 +443,18 @@ static int __init ibmebus_bus_init(void) { int err; - printk(KERN_INFO "IBM eBus Device Driver\n"); + pr_info("IBM eBus Device Driver\n"); err = bus_register(&ibmebus_bus_type); if (err) { - printk(KERN_ERR "%s: failed to register IBM eBus.\n", - __func__); + pr_err("%s: failed to register IBM eBus\n", __func__); return err; } ibmebus_bus_device = root_device_register("ibmebus"); if (IS_ERR(ibmebus_bus_device)) { err = PTR_ERR(ibmebus_bus_device); - printk(KERN_WARNING "%s: root_device_register returned %i\n", - __func__, err); + pr_err("%s: failed to register root device: %d\n", __func__, err); bus_unregister(&ibmebus_bus_type); return err; -- 2.53.0