From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3292E3BFE3A for ; Fri, 24 Apr 2026 11:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777031458; cv=none; b=L62uBbWeqXvPT+OD6IVnw71sjiNZjxBZ3LFJC+dA1H5jQ7ii2P9kLVKblxDoriOELCHoMl62wlevCK6kaVekWTWmlU5HSbqBBaqWbgfTsHhk63QxNdOz3F1mwA9cjATWQZNjyJ51Kupk4hkvn07455BlJZyIe4tKX6+qkdGXtwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777031458; c=relaxed/simple; bh=gXDiGCFgU9yPd3l6Mb4B1sNe97uiBVDDnnXvLu2QRKA=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=eF509/Hvy1JSlDNSoS7Z1jJtkUjwzb27Ez7TzJ/XnkXdpDa2tiB7UsD/2xulNgRvdv++yghXMaJO0bjiNJgVscoamfwFU8vf138kue1MaskwnzcPCvFKmrosNJYj9naFrtOZHR8aYpjkbcbH/YvgWrR1rgrp0MeNcxRGyQz0JeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bJ43MKqL; arc=none smtp.client-ip=209.85.218.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bJ43MKqL" Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-b9c5f899463so499973066b.1 for ; Fri, 24 Apr 2026 04:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777031455; x=1777636255; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=SWrPyM9GmNoDHKDhuqATorLaXifk2WZJVD6FV45FxQE=; b=bJ43MKqLeAn/z2PEbqEQAejKsMPMwqrhcvol/yM5Og9cOfIJaw9AVCFDD8QOcEa0Ga VhONGDhIySBmk30WDsNVslxSE9HFefC+ydwiFr3SnctwIFpiS9piHArvGqSmh1ZttRr8 JoKAxqDv59fc2e2Nilnh0sdk/FeCXG6kiuuf4LnHDH3YOPa/Jwioov5LPL2rCJPl5WrZ A9GFNTu/wVChKCsqjjXY4EuiY6NYTsoerv7CB9M0Cn24KjKl0dQrGgQBFo7UXgI/tJQ6 XgmYQffdQQtmVHkU5yY8moZFa1AfgkNzDaM+TRfDFz/kGg9LSxP4covS5vTrsY/msYKL /iOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777031455; x=1777636255; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SWrPyM9GmNoDHKDhuqATorLaXifk2WZJVD6FV45FxQE=; b=ITcCVVNEjjPczSYWVxhRkStxqvJ693yuo2uTDgczvC9ykhJQ3A7gmamtnSe75MfD6/ WhtVmwM6f6zvCs0qysxbUdlcMHhKwcTgMc3uv4CmCPwVvZ+b4Ex+vq7EVXg/5mwbWKLz z7nasO/p1MCO+AHgLZ+UPRj21CootqcBxeRRkPc6PEpl7J1Ggz24+gst4OwmRIIfz741 4KTwaOkwT5RUczXA3jQS9bruOUxpL8lUMwNp+g7whWuzM0GDye75EFXtX1JPMfQ3dMKu lDwsFtEqT0FIjP76IrUV2kSqP5SCvCb2zZwJ53c18y/ZZUWmutpfr+or/bj5AbqpPS0J hgwg== X-Forwarded-Encrypted: i=1; AFNElJ9L/ChudXxiJkzkAWd+wJbvMhxECYlrZdl6+h7Kzh+f89+hYBLKpqimB27yq9sqGP9nCAi0OK0ErAJ2CVs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw68x5zQG/P1NFqJKmMXyeDetEkiFxyHliengVHRNxGPKFyi3XZ 9oYyXkoBqBTS3gE7+M4Z2VngjW3wd6GuIXxfh3OUqPU8aQjDOII43mOqV36K0ltbceyDSqp1rKD UbfJnGyIHzWsLWw== X-Received: from ejchr41.prod.google.com ([2002:a17:907:3fa9:b0:ba2:21d4:d581]) (user=smostafa job=prod-delivery.src-stubby-dispatcher) by 2002:a17:906:fe45:b0:bad:820:65b4 with SMTP id a640c23a62f3a-bad08207055mr237495066b.16.1777031455343; Fri, 24 Apr 2026 04:50:55 -0700 (PDT) Date: Fri, 24 Apr 2026 11:50:51 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.54.0.rc2.544.gc7ae2d5bb8-goog Message-ID: <20260424115051.2082174-1-smostafa@google.com> Subject: [PATCH] iommu/pages: Fix iommu_pages_flush_incoherent() for non-x86 From: Mostafa Saleh To: iommu@lists.linux.dev, linux-kernel@vger.kernel.org Cc: joro@8bytes.org, robin.murphy@arm.com, will@kernel.org, jgg@ziepe.ca, baolu.lu@linux.intel.com, kevin.tian@intel.com, Mostafa Saleh Content-Type: text/plain; charset="UTF-8" The dma_sync_single_for_device() function expects a dma_addr_t, but iommu_pages_flush_incoherent() was incorrectly passing a virtual address. Since iommu_pages_start_incoherent() enforces a 1:1 mapping between DMA addresses and physical addresses (checked via WARN_ON), we can convert the virtual address to a physical address before passing it to the DMA API. This also matches the behaviour of the other non-x86 in iommu_pages_free_incoherent(), which uses virt_to_phys(virt); Fixes: 36ae67b13976 ("iommu/pages: Add support for incoherent IOMMU page table walkers") Signed-off-by: Mostafa Saleh --- drivers/iommu/iommu-pages.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/iommu-pages.h b/drivers/iommu/iommu-pages.h index ae9da4f571f6..e9e605b5fa3a 100644 --- a/drivers/iommu/iommu-pages.h +++ b/drivers/iommu/iommu-pages.h @@ -137,7 +137,7 @@ static inline void iommu_pages_flush_incoherent(struct device *dma_dev, void *virt, size_t offset, size_t len) { - dma_sync_single_for_device(dma_dev, (uintptr_t)virt + offset, len, + dma_sync_single_for_device(dma_dev, virt_to_phys(virt) + offset, len, DMA_TO_DEVICE); } void iommu_pages_stop_incoherent_list(struct iommu_pages_list *list, -- 2.54.0.rc2.544.gc7ae2d5bb8-goog