From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E87FEEEBB for ; Fri, 24 Apr 2026 12:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777032733; cv=none; b=rlU9ixiBZqwkzfDzZkA1bctgwGT6yvBofejIejZfuPMoSivWzJz1HbQlmbrL/GyRgmDcU5EQ7rhLcw2yXdjUk8hZxDfaP4Mbvu0Y+gW3/OD31jIbXcO1sAorPXfLxOwf85C5URs2x5TTgAC2taeY9FFvynY6gW/My1g/mf5aiJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777032733; c=relaxed/simple; bh=zEGobiCuZPPtv3wiYi3GNtsfe66Yp/DHMh5rvcwS0ss=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PuC0CZZ/eqE4yDDtY0IbtojqHqZxOWAz74ufoJoEmUMp5iISr/6i9xtL+vHv2Av/v0xGYWq14GUCPjc5eBnVcYFcLbKfODP33TuuhI5qXOuixtLjHZGl7tHmCbWG6f0+qdSUY310hK5B6PaZrreTIDGqGhjggLRN8mN3qN+FX4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hFid/JBQ; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hFid/JBQ" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso6206387a91.1 for ; Fri, 24 Apr 2026 05:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777032731; x=1777637531; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zM6Iyznzwn5aDn6I4+pyGHdSCpNCUHeTWc3+0jbTctI=; b=hFid/JBQYzisRy/540iymeX0BqB3UaaGoFwN36/z0ZM7GW3tUIVh1+70BuGdtDT63u UXyInQiNQiv6SaZUPBXeo+E5924AoQQ6RLFW2n3jYKZR5s9Ru492QZ038QolevYWyZVU Uz2B6jqZk7Zrq+uJZGYKwfCx55VGCTuMH+m5Z+PFbPr9XXLhRDcaYop6r0HvW01JsPVJ qaySnyqyaH7QpVF+Mz1lsQkpdc5vm4jyYJ5+2ysCOXFy83mE/Od6TGZfK0BqmYqmt4i/ mGGTEYInLn6cTb7bdEojPMVOgWWvVZbJRRth/Vupos4TXUFhn9RzQbTEImag/ERmS2mS f28g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777032731; x=1777637531; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zM6Iyznzwn5aDn6I4+pyGHdSCpNCUHeTWc3+0jbTctI=; b=IRni7kjC8QroUQnUhHeyGC/QFVt++6SBxIfhJMJ+fC9ZKeE6gXFXjPhEr/2BYFB6xN qQl75AMb8oElybN576LuBqlI8UTcZqWdcCfOKgHXGPJa5+j38kAuM/xzT+POCUaaAWH5 erUY7xPD8Jq0dKpu9+sFEO9vVdqfrC+rzLkcLEqJPb7a8JyJP5xtDe9SuoeQeJ1dFAU2 pYHYNgHDfPe6Rmt358gOKYrppba+zWFZwy/xgmQp4Xtz/DNmsypy4mhHmluOAq5D0tGB 2VYWqT0jtNVwKuaMQaP+vznOFSzd+LNPHoGhYBBzoDzicUncaVGAuhjMGyIoheHE0HsF 9LzA== X-Forwarded-Encrypted: i=1; AFNElJ/Xw/Dg88PwX92owo1+bhFwYQAOdEZAppj/lUbvcS/Y+ie3vM2p3F+pAVIn8cEzKHeeRU77DsSVqpdSbks=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/eoiqlsPpsZk7CfKSGRdt0orqW3Ixcz+fNHZv5f1LAAu5MJwp Gj4p4xHBlRyePv7ju7T/LpJj+X+4KXTeWeR1od44Mw8NsWVPj2BPyk0= X-Gm-Gg: AeBDiesNOYUsQB8GeNvr4DnrTAmUdePJvBdnxE4g/7U0t/DRjqBP8HIRWZKWUuTBLi7 GsTisBXwD3hL7P/oM6ZtDjevo3QcRjzgCVAc6LOzGxWRKVrRoZlDFzWGx2l/pA/3iIzjvdA0W6T YrdXeVC9+NfTbWQHbJKK7eztvpJ9qPdR3v5q6D8TXxFBs4Fn382J1EoMQXZ5rC7LAuhgI5dWx0W nIoSHHtAHuaPAR4DOH9zKPzl4tiI4uD+f60b0i5N79+/fa4+uKME+cV9bjtzyS6wyr1lH+gKaBL 0kzdGVy4SmGrqGNPlBuvXzetM+eSLi3qV2br0c4Zi1dDnMvcCtTfP32NaidR7cHuKcLTVdtCV2f k2Uv5eFGTYVCUv93qzhhLgM6/uDoJYcH4xYie2pvldyCTU4ESJdqS7oNdyLWLqj1vARlyshwZ+O Jt3KJGJaRZMkBir1Xb+auDtANc/QuNFRYowzgQpy5tceH2hUnCdmg/HPS9XfhThlvsAi252SU2B h6Uv0Ajew== X-Received: by 2002:a17:90b:3c0f:b0:359:855f:ff96 with SMTP id 98e67ed59e1d1-3614048b2f5mr30642540a91.17.1777032731227; Fri, 24 Apr 2026 05:12:11 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36141898ebasm23482206a91.7.2026.04.24.05.12.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 05:12:10 -0700 (PDT) From: Myeonghun Pak To: Alain Volmat , Raphael Gallais-Pou Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Myeonghun Pak Subject: [PATCH] drm/sti: hda: Fix bridge leak on component_add() failure Date: Fri, 24 Apr 2026 21:11:51 +0900 Message-ID: <20260424121206.14558-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sti_hda_probe() registers its bridge before adding the component. If component_add() fails, probe returns the error directly and leaves the bridge registered. The remove callback unregisters the bridge, but remove is only called after a successful probe. Remove the bridge locally when component_add() fails so the probe error path matches the successful-probe remove path. Signed-off-by: Myeonghun Pak --- drivers/gpu/drm/sti/sti_hda.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index b739782788..9223135c93 100644 --- a/drivers/gpu/drm/sti/sti_hda.c +++ b/drivers/gpu/drm/sti/sti_hda.c @@ -741,6 +741,7 @@ static int sti_hda_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct sti_hda *hda; struct resource *res; + int ret; DRM_INFO("%s\n", __func__); @@ -783,7 +784,11 @@ static int sti_hda_probe(struct platform_device *pdev) platform_set_drvdata(pdev, hda); - return component_add(&pdev->dev, &sti_hda_ops); + ret = component_add(&pdev->dev, &sti_hda_ops); + if (ret) + drm_bridge_remove(&hda->bridge); + + return ret; } static void sti_hda_remove(struct platform_device *pdev) --