From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A89DF3B19D1 for ; Fri, 24 Apr 2026 12:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777033439; cv=none; b=dfk0vSGkL+VjVk24kBxfpNCOp6KvKQyyLPMp2B5bVJ5yON3RF7T4GZfGe2e7RDOGI8uWKSWFVgpnmCxQ/tgzzJ7hFLn8CEuBCORWy3AD9K3OpNsLS+gCwzvNIkB1GBTurUzlvSBDj7jxUWWMjEkholE1eURQ1xWOOR2CyepuxNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777033439; c=relaxed/simple; bh=kb6mw1egEFoOKxuEaGhM9YRs6JyH4BI8ZRlMmfK06J0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O5gxax5QsCzgUs7Ri5ZACUpscAfWx+HSMuVRfRvHTvYBHE28ERqDM3lJGqpBBr3QVMCQYrvMUG9APdr9TBUX/uaQtTTPxUj/05N2ehoG4YtpxmSh4ei0zGp7Z2xuSdRcmRGR/yAJGDaUboH4ud9CddleCGBzpBAT4RAF2/0lVI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ddGOR0d6; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ddGOR0d6" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a9296b3926so45506035ad.1 for ; Fri, 24 Apr 2026 05:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777033438; x=1777638238; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=C71odJl+wa8fdrMSB/JV4uI6qaWBDJ3Egjrlc4m0udU=; b=ddGOR0d6JRbwxd+8fdbFOl2H5o+34qaEBGXmF6jUTKD7WftNO2OsTsZhFspK5TbpQ2 FCAgz9Si6DAksWsoadwfu1eXbbygqsorh52ZYAYZnAmr+pvcoR3g1vvcBWAU2Z8F5AFU 3+mUqe14WhK9iuvr3IPDSivEbAtYHAmHRSbZ6+9iW0shHxhLqtzm3M3d41t95T5f370y CSwkzLFQrZ6+UgrTQX4Z2B1jjUh6kSUxeUHUHpqrk20R34D4k7QBu6F3gbzngD6GzvJe oQlxFwoBzbC9S60ZdWWs2P3At1tTGt1O0gn/oRrjv3kaWZv4EHTfBhBXaFFXBHkSd6W7 gMjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777033438; x=1777638238; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C71odJl+wa8fdrMSB/JV4uI6qaWBDJ3Egjrlc4m0udU=; b=fCUWGoBpaj1rGAadUvyuw7TvbL1+U4VCfi5sjN3zAFzk0VGON/P5omRe4MO6aw45Os fjmeKsSYj4ZZJjCDSTb8PpS7QZwNGb+7G2Cbzmmigzq+TBl+DpgVeXaT/7Qa4GkPOhRH oEYNin1hCTCD/MERNch23xAUq001Rpy52IlviOqOIydCb5S/ogLYGWmLVWy/0Kch6jac NFKfW1n6+nSwQWzX6F6UTfYPt+NFmnWcZQe+RT6vAGaein0+9ZmZ+aR0FAiqDgoz+KSa Womz8AdNgMtqTRBcS7qkhkgKqEtUhkkdLl0RWms9g3O3yprGY+Zk6nCTzledDlLCAZ1o UuIg== X-Forwarded-Encrypted: i=1; AFNElJ+Bl+cLKd5MeZe9LTiXT2ANjWmjdcWCZDE9oJ3RI6sejRPmNKWw/SrxwpVM0otVWtlL05lv4skd1YDXT6U=@vger.kernel.org X-Gm-Message-State: AOJu0YwFoo0+q7HwUISYLXAsSxm1wcemZzsg5nzUX+qivMA1kcmBdrVo uxnYlNhMQY2pPrHKPuoZ1dXQjNEc8dl/VTJhYo+dEvU+a3CO4ZO1/wGwS230XXhx8Q== X-Gm-Gg: AeBDietiFiP8GBO9kpKu+ODBIiw+8uT/cQwxEBVK0mjnVXiIgf3WXoapmYjU4erKQYz ihUvrlfFA9yMLpGNBZTEnKDHktWZL+JTmM1imYQid1xlC9+3J5P49PTpcld1pQUtYCFpYZ2PoF0 eoChHnA5Jgk5pMEjP+XiyM5dFPs406bb9SvkhgshW7QijQqwgANt7Gp16ziDLjkWVyDBfIHLWA0 c1Mcp5602bv3hhHtjb+UDesn7mVymllAUyPAJFMUDQIs2roZ3myExYg1uLNU3wQm5o8E6DXzTjO aG8zguvZ4gF3ukRcV6wiDRaamT4wJpwXmymeXw0XxYM+7MAgXyHjNpJBacgTsgEkX9AzgaEtHEs i9exaSWHhVWdvcVEAf7NTbZED/sQ4kq84GJ6OqN1BecxVOb1N9P4A7AEk+UUEkt2fbAaNZqOc8P apuGEake54CgjI1wk6dE1Q9Pey7hKNT482aK+bInIrWC0Vwvg8daHrQGrq22rHGLZ7UU3xFjzMw zAln1Xifw== X-Received: by 2002:a17:902:cec6:b0:2b0:917c:bc4 with SMTP id d9443c01a7336-2b5f9e8e3c0mr355839025ad.4.1777033437987; Fri, 24 Apr 2026 05:23:57 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa30134sm230574895ad.30.2026.04.24.05.23.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 05:23:57 -0700 (PDT) From: Myeonghun Pak To: Alain Volmat , Raphael Gallais-Pou Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Myeonghun Pak Subject: [PATCH] drm/sti: hdmi: Fix bridge leak on component_add() failure Date: Fri, 24 Apr 2026 21:23:39 +0900 Message-ID: <20260424122352.20930-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sti_hdmi_probe() registers its bridge before adding the component. If component_add() fails, probe returns the error and leaves the bridge registered. The remove callback unregisters the bridge, but remove is only called after a successful probe. Remove the bridge locally when component_add() fails, then continue through the existing adapter unwind path. Signed-off-by: Myeonghun Pak --- drivers/gpu/drm/sti/sti_hdmi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index f8222e60b1..d7b61b5b35 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -1460,9 +1460,15 @@ static int sti_hdmi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, hdmi); drm_bridge_add(&hdmi->bridge); - return component_add(&pdev->dev, &sti_hdmi_ops); + ret = component_add(&pdev->dev, &sti_hdmi_ops); + if (ret) + goto bridge_remove; - release_adapter: + return 0; + +bridge_remove: + drm_bridge_remove(&hdmi->bridge); +release_adapter: i2c_put_adapter(hdmi->ddc_adapt); return ret; -- 2.50.1