From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A483CE4A4 for ; Fri, 24 Apr 2026 12:35:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777034116; cv=none; b=kvw2rU9n8EO3kdq6+ZtnqQNkIKSda/YlqH5tiYjPX1AyVxZY7Rf/YdQ1o8Fef3tFRrEKjt8Xs5emPFSH4kQbldzadB1LkxSxY+MpXmicAMvTfI7UYVd3wlS3od95Riv8KC6c5BgQuf69ivTykUkA+6tIUPWvxPvcbrbqspH4Tk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777034116; c=relaxed/simple; bh=oUQ4zOnhcCXCb2NZHPW7X+oOw+LqffcoU1PnIqoAs7E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HxT12WzKdGYuWaC+cSqL+Dz8TFykmpJp4z9CVt7uLTTCQO7WIwVJnvIU9z+hYiz9LjyJ2LdFylbjuEEhWJAVRM4Kt6gZ2dc8ipUGuM91vXvAWBp2TrNbJKZwK4aBEK7MoASJS0VkCLqz9htz56cAi9woEFSNBPzUkfzQg98RZXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T5EIhgpN; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T5EIhgpN" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a8fba3f769so35276625ad.2 for ; Fri, 24 Apr 2026 05:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777034112; x=1777638912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ru7oTacAH1AHj/CyXoHHypjd6b0Mk6YIUe6NpkAx0hI=; b=T5EIhgpNMkTtXu+SPoqk2HGkIhOXzkJNgHwtyyqjYIQFsq628VM1+8fcvyqgif7c2V 76w4YyqmpEOZ2aw4P4Oyt1rBPlcJyxJMc5EI3EftXj6nxTF8GJeHov69VEL1Pa7lZceP 3Dzsp0kIFqIo3u3bFcnwTKrjTtH9F6OInKZ9G6L9Nd1pWizrjj+0IyovJEKcsCs0J2mr +H6NFJF0nc1oKqUW1Uq4l71RGf3bnAKdDF22+mZta2sTnG85sBFrEPbLAYorEW2pkO2a 5pQ8Z5Q5W/tqr7nF13NtocQGfSTZYMa7BZJXCwLW0lCyR4Ni+yhHLbZgsVGuMyNdk948 7A6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777034112; x=1777638912; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ru7oTacAH1AHj/CyXoHHypjd6b0Mk6YIUe6NpkAx0hI=; b=IN7oOZDIxiySfhsHsTT9cpUKOfNdoA4uwBzWXvtniOQ5TlwtuncdQoQsY1q1ZmwPwA IfdwB9kLXzydbfznELPE9KQaztuOf8A5DxfomLZ8mboaKq5oQYsDOaUdTlTMDNIcV7yx 1G9IfEsw8wO6tjitooChQ3XjGpLxdz+Izs2uHYRf6dYcqoXxgHCdDafKeMgfLI8U/cnn AgKpJI7JNI6SWNTzQMesAedWtgYUx4IcJ7fdTksl9MZlKwmfzITtjOWmzgqBDD/KFIA2 wA7RxD+pPpd52yL5tXsY3I5Naqq/9dda2fR07CkeHDG0ppVQUOGR+tBt3CXXM+lGnS7p jPvQ== X-Forwarded-Encrypted: i=1; AFNElJ+Tf7p4BCg3csumbIbtjke0qC7idQZ2Jkjl3k64hWeCBG32fijkFGaBvkVL2l4gDNr8hdoGBwGzACCvaY4=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ7hzW4LP9wt1wlDR+S/YEWcARJDLp8H+9aywtV3htKFNN9s7M JfptjOBCebass1TGEsD2jogsU95HqjG6PvCoau3PH4ImI+lZNLED0nE= X-Gm-Gg: AeBDievmq+kIiK86ndtfDodDBSCR/be17NTwRkhIyXp7W2DxlNk1JLUVK+Pqg1KVqHd k1vHkLzNb3SsRXU1a+uaXPYYaESJw7ameZxKAfGoiDxB4l2Z1apjx0196r93pvaleOldr0tXPm4 U8jcTwyTW6jaW+U7KJfmvg/4AZE4w8g7xDc+fx8C+Ifa8VDZC/XtefxacEpHpM1027HIx+t5CKl pHdmi8lTNzPfqwZ6wG2gpKE/l/qF1azamSjzm4+kmyN89H0LnipA09IP1PigI4wm9DJk1CoFtXt WvbN1/0JEXUpZO4gm1LXM6d30bRHumSYTwn7PQ8sE/tLPlGd10GkbCejXQxxtoNGSm0xpaSub2R cI9KAWNYk3gDnwqhnvEOuwxn1D4otYa16rz5oqOYKCt8prdLn4tmRhPY17aLYRpVEP3OgTMkZAc blpt/AP/lS7SYUPdHfDoZA5+rzPV4cTG4Rwlhau2tN1mFJmG1CKTlVNtCFh/24hFFyxtKosUr7A G+rBy4rNQ== X-Received: by 2002:a17:902:bf4a:b0:2b2:4e5c:69a9 with SMTP id d9443c01a7336-2b5f9e79fa8mr242778605ad.5.1777034112041; Fri, 24 Apr 2026 05:35:12 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cdbbsm224428665ad.48.2026.04.24.05.35.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 05:35:11 -0700 (PDT) From: Myeonghun Pak To: Gerd Hoffmann , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Myeonghun Pak , virtualization@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bochs: Drop manual put on probe error path Date: Fri, 24 Apr 2026 21:34:28 +0900 Message-ID: <20260424123506.32275-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit bochs_pci_probe() allocates the DRM device with devm_drm_dev_alloc(), which registers a devres action to drop the initial DRM device reference on driver detach or probe failure. The error path currently calls drm_dev_put() manually. If probe then returns an error, devres will run the registered release action and put the same device again, after the first put may already have released it. Return the probe error directly and let devres own the final put. Signed-off-by: Myeonghun Pak --- drivers/gpu/drm/tiny/bochs.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index 222e4ae1ab..5d8dc5efec 100644 --- a/drivers/gpu/drm/tiny/bochs.c +++ b/drivers/gpu/drm/tiny/bochs.c @@ -761,25 +761,21 @@ static int bochs_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent ret = pcim_enable_device(pdev); if (ret) - goto err_free_dev; + return ret; pci_set_drvdata(pdev, dev); ret = bochs_load(bochs); if (ret) - goto err_free_dev; + return ret; ret = drm_dev_register(dev, 0); if (ret) - goto err_free_dev; + return ret; drm_client_setup(dev, NULL); return ret; - -err_free_dev: - drm_dev_put(dev); - return ret; } static void bochs_pci_remove(struct pci_dev *pdev) -- 2.39.5