From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E4783570C1 for ; Fri, 24 Apr 2026 13:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777036045; cv=none; b=QIXD4iYod5Ic+Wsg2FW3vNmQTR0/2pkwVHrmqSTToc92EF9b/nkt5NWx5BsIEn+VE48NCtmyDO0tWCZp6d1Vz6MPATRri3PwmKI/jd83L2Ao7V1f2tlHnDAT42cZVVE0/vjYjuTfwbE/MoWHouECQ4S5TSWX/XFKz2uLQxCi48I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777036045; c=relaxed/simple; bh=sCDsqy7W85Y+a7LgGvlm9lAlQEpBmlPprmn2dzvWLuA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GMBs1LX09F1meAnUsWMMifKUvSs6ar1+N1qGL4oQGb+qct7HcovffWKz1ReLbURmi4lnfMg82DDgIuOozh7sfRNNujLbYh0JMH+oC8UdGRnJEhRKo7kKbzhU7iAJnj3D8aRrPIV8oanX+V90NdfWUoKNUsNtH1fjj0wucCnMnls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=D89hNELS; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="D89hNELS" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-8a58057d7baso93583376d6.1 for ; Fri, 24 Apr 2026 06:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1777036040; x=1777640840; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jFFzAgMltD5d+nB/EpmdoiPIkhUChneGMHd/GOz+Z24=; b=D89hNELS+hyk+xe2IQqLOjtC/EfAsz9EUrgmTsXEPN9Mem74lNDsIgFxUZV7XWSZSA fQQ+pZp4P8r0DczIKMG8Zdv+C3m4UHBcbjBtlaNhArCCrMuMe46zayK7CxAJ2+JYpH81 J99eH9vKLSZ0aLOq/wHonqSh/dyMQwLhI2orMfaUfh1aJbgls2MO0qD4W+N+xS99sKLI cdD3lvsjmVAFrmCSeGm1+3kOv3RRkwc0UAd6LdlAoNsFqjZaBuog8zCMFOemdD39OmAr BHiWraPcDHOhhyhB6jmiPkAyjeNI9tvWpBWJoVtajlGvRo3Ey6rGtEht5HKSghq2Cou7 LkNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777036040; x=1777640840; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jFFzAgMltD5d+nB/EpmdoiPIkhUChneGMHd/GOz+Z24=; b=hofIQzOhD88i876oEMuabE6dgp2v5sT61whY+y2SqHy6PjZJtTyS/wG4M2V4knX39y 0YmYH+ISJUsWvlcOpWsM0H0JjJBQIvjmYV+qaFv847bfViAHArvgR0cHBz2RJiBXNenN 2Cxfo4YB8ZyJTRmoQsdVFGPFDHopS4Mnb15SHITVf132YdC3U+euLCnlc18899wUoHe5 A05lxJnEYNypwCSaAQPOIFaDo2KFKolSgpm39gNQ92568SrJcomFeAE3rnb8kBKQMkpG tFIrcvUFwFui7TwmFmaum10rXBB2e7UoZsaASf/q9AQXPoM+j1Pmns2OOZjPfj1fqKIb YZ2w== X-Forwarded-Encrypted: i=1; AFNElJ+x/7KUE2tcN0S+LQ99J9UxLbZQp64ikppSK29ckVi28JKlhgTiW8hH2SCN760K6XtASuqs2gAzGxecm6s=@vger.kernel.org X-Gm-Message-State: AOJu0Yxdzfxg1w0n4w/mx9ZBfOh+7QA+z98J3oZqCy0Nsq6p5t6miVu3 KyTwTSxbpHDI+pBQhlBrLZUg21gCgdas617GKxtHqGveYY+6pWyK2WUFEir5/8A/xtQ= X-Gm-Gg: AeBDiesCPq5RIZljJb/Z9G2DVTJpEImh4kwYfpnd/zB+T+uFavjOBL0libUr/s/UENR Vlcd34XYbS4DlS5V1v4jDBrRQMjT44j/tBHxim5BD8KvwAFUnuGwwxEBPAed2Yb7XwG9kEyZCW8 YbOenJQkMqDn4kJgP8prK0hnXbzaajFWAOrgO5PS2I3ZkpYtf3tjIwPF1oaAl3OHw8mLiRFhUgO qRQtls/z879TmNvHkI8CkYP38LZvaVXSXQnv51R/qg/XMOQ5o/QqkkAAjci96gtkAUWBUGNcezc ZVOZdsFGe27bnwmKLQIEvASkovHHT09BN+ahqcmCH4eh0LCAPrPMn26m82sLQKDyybapftnYsOz z67P2fJic5jhqrdbNLcYGVQ0VV38OFuMn7QC5PlMqUwKVT+fOfDBPwuaF8rsTMvL4oyREYkom44 2C2q0ow6hz8uKokh2TFtdaj57cviY3NgnVntgg1CYQvAL/vJ6VHHXyTzQBIv9DQZ7i+DGwX0orK vT8pzs4/07yiw13 X-Received: by 2002:a05:6214:cc1:b0:8ac:b4b3:3ce2 with SMTP id 6a1803df08f44-8b02813ae21mr473334926d6.41.1777036040137; Fri, 24 Apr 2026 06:07:20 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ae5ec2dsm192148296d6.29.2026.04.24.06.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 06:07:18 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wGGFa-00000002P8B-031d; Fri, 24 Apr 2026 10:07:18 -0300 Date: Fri, 24 Apr 2026 10:07:17 -0300 From: Jason Gunthorpe To: Mostafa Saleh Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, joro@8bytes.org, robin.murphy@arm.com, will@kernel.org, baolu.lu@linux.intel.com, kevin.tian@intel.com Subject: Re: [PATCH] iommu/pages: Fix iommu_pages_flush_incoherent() for non-x86 Message-ID: <20260424130717.GX3611611@ziepe.ca> References: <20260424115051.2082174-1-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260424115051.2082174-1-smostafa@google.com> On Fri, Apr 24, 2026 at 11:50:51AM +0000, Mostafa Saleh wrote: > The dma_sync_single_for_device() function expects a dma_addr_t, but > iommu_pages_flush_incoherent() was incorrectly passing a virtual > address. > > Since iommu_pages_start_incoherent() enforces a 1:1 mapping between > DMA addresses and physical addresses (checked via WARN_ON), we can > convert the virtual address to a physical address before passing it to > the DMA API. > > This also matches the behaviour of the other non-x86 in > iommu_pages_free_incoherent(), which uses virt_to_phys(virt); > > Fixes: 36ae67b13976 ("iommu/pages: Add support for incoherent IOMMU page table walkers") > Signed-off-by: Mostafa Saleh > --- > drivers/iommu/iommu-pages.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jason Gunthorpe Jason