From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74F523D412F for ; Fri, 24 Apr 2026 13:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777038674; cv=none; b=EAcYpMuSe1rdprUVRsmIKPYvAQCblPrkI4KfSYf4fzgMbVFnSCJTzhB689XyzDOK7bqb7F+OR56zhW0O24utzAsNJh7VMOGG3spC/EsJgh5RNFjSN+LgZexoweWMMsRalfdNNHQftJnYHkxWBpEnI0BeUSKBkV6mXV15RTBAWpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777038674; c=relaxed/simple; bh=858P5mFpF+TrKrI6ZyGiotk5+CzcEz31qN54eKosWAQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=j/8eguy9pyvvmU7OFLLvIhf3ExQiyNdqlHaio5ohZNwTa3Mm0Z6UkfK9rrCCJqFiol4Pf2b1XCyx1R6SAoSPjfGzEayH5z1bPVYAvpG5/RX7We1STJoAdw24b8tLN6ubc38t1pUD4o30A1tkQ7CiVWzfDSEXxLPLoF2lqrsbCsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cznsQXEE; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cznsQXEE" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8296d553142so4523224b3a.3 for ; Fri, 24 Apr 2026 06:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777038673; x=1777643473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5BzP7d1QHnmFXYW9OV542PaMIY/QnoUuc/2j7D+PjyI=; b=cznsQXEEMwHAveO4Uxx/xWl5VJxSOL/au8OU9oKdR2sDP31241rakHs8I5v9EYqZMu lPlPRII2yJcuXxNBX6WNvCXErWyTpBNBlTFHBtg0FahHT2iNydo4OSc9UCgqwIIFXA/J qlPX7279SnHS91aBK/b94W5mdp/kQb0uCVW0RkDjpJ7RqSfDa97tFuSjluu/8B98iO3c /THZp7Lov3MY7x8sUV9KjGnPuNkGNmC4xHhRmKAGPChrxYC2D70KWQnlOiE3eXsBox8J OWhIU59W28hjeeD69vjxneHcvlh593UWOc2kkzJSBBxSgsa9W6k0rAyKv2kJmXp1fOYy N7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777038673; x=1777643473; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5BzP7d1QHnmFXYW9OV542PaMIY/QnoUuc/2j7D+PjyI=; b=FYp3Icu9/uN6H6wU2P8FA3rgRkQwYV8TVCahQZgWmymKdndhGCzU8LnfR5OzheIzFa 65BWracauq39I3Wqdk1WMtFIZREJ4+++UWUexyndyF8riLJdsQJVnU8pwSgv8EfWT/7Q 2vTHQjqQsVMe1x95uYMXm7yx+rlKpYgrkntWcyStrBaFcQp5XCcPER8WD1ZB6NEoXZTk NvHoE+55GrYlZgwMCpGySo04volpq8a1exIwIh1501Dnck0IWuhn5+0CjkBqcMmDp4Yf kwCzXhe8kHgmQCplmWRbpjOjJhLy/WmY0Ac2drQ110Aw9IWMO2YpH6RUP5vBFAT00qkb hFiQ== X-Forwarded-Encrypted: i=1; AFNElJ/SLqtH9aORwGAfmBYMT977qvjKB3p+FbASYGSdIre5Bd4zK882vM7t4j+FpIPM8YlDs1tlkRnZUOq7yOI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/Psn7FrYXl8yvqFdwxqgor0v16tFv58HVtxSFydHJ51RDWOHi PiPXqMs+yO3PI5kZqazdnUZwEmpeOJX8MicUvfHdfVgBkLfvVprzEc2mry2fjw1NlQ== X-Gm-Gg: AeBDieuKbxv4Nk2SUvM2j0+1bAmaSMkECfwxeh3oPW0/sHPbavcDNBeKNBE0uoaGUXl N9roMluPaxbjVNKyGnbf8i6f2KbbqmKfhlTHBjN2EnE3TlTGlpo/o2nl30Et1wVxSjZY7YfHohp qdCWYBLQTdco73Ts4TKLaD6X0P3mgkc8dCaf1YWb999d0W7jW/G9dhn7t/5xpWXLeRi0A6MFf7A rA/ms3gmVUnp7CUPu+SRUXLRj+EVVsy/CYfiYiIAxsiqF+ARfD3GWb1y2o1f5KHoMu6aV7Pz7PE 7n6JYayMmcICnDFOqPZ5vkBhpn3qIyHUOyYUPHknbLD74SpWAiUeTLNhieDiXjrBJbmanSGfxon uxwOb0ulmeiQsXIlI6QAk0UoqAQ/24AgvYbNvH6+EuLJN5BhYHpzwu7A5hPP+SHIwbPmWSznlxT bhj0b78sinS9ofbAqY08fQ9zaf8qkEPsgeDZXzoO6TMFEmCtgLxxBTwFVmURsRyvPFOQftnyHuk o3D6CTPFAjnJpw= X-Received: by 2002:a05:6a00:1307:b0:827:3b1b:43e6 with SMTP id d2e1a72fcca58-82f8c83bf5dmr31712297b3a.21.1777038672699; Fri, 24 Apr 2026 06:51:12 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9cbb28sm22402386b3a.13.2026.04.24.06.51.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 06:51:12 -0700 (PDT) From: Myeonghun Pak To: Wilken Gottwalt , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak Subject: [PATCH] hwmon: (corsair-psu) Close HID device on probe errors Date: Fri, 24 Apr 2026 22:50:51 +0900 Message-ID: <20260424135107.13720-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit corsairpsu_probe() opens the HID device before sending the device init and firmware-info commands. If either command fails, the error path jumps directly to fail_and_stop and skips hid_hw_close(). Use the existing fail_and_close label for those post-open failures so the open count and low-level close callback are balanced before hid_hw_stop(). Fixes: d115b51e0e56 ("hwmon: add Corsair PSU HID controller driver") Cc: stable@vger.kernel.org Signed-off-by: Myeonghun Pak --- drivers/hwmon/corsair-psu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c index dddbd2463f..76f3e1da68 100644 --- a/drivers/hwmon/corsair-psu.c +++ b/drivers/hwmon/corsair-psu.c @@ -796,13 +796,13 @@ static int corsairpsu_probe(struct hid_device *hdev, const struct hid_device_id ret = corsairpsu_init(priv); if (ret < 0) { dev_err(&hdev->dev, "unable to initialize device (%d)\n", ret); - goto fail_and_stop; + goto fail_and_close; } ret = corsairpsu_fwinfo(priv); if (ret < 0) { dev_err(&hdev->dev, "unable to query firmware (%d)\n", ret); - goto fail_and_stop; + goto fail_and_close; } corsairpsu_get_criticals(priv); -- 2.50.1