From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DAAC3DB644 for ; Fri, 24 Apr 2026 14:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777039692; cv=none; b=tgL9JsnCdqwRhCk8/dlSA00Ys2YfP7lB3Ec2z5GwKzWlaDOxv7TUHxRKgiaWOcKSs4n+Vct85VRdxOBENeuyKlnV7+4d/Hf8WDir/hoVm2sL2/dxbzUF5+VFQBBYBrabiA8I/Ci9kSib7IdeH5VJMjtpG6OGpOPSa7Znwl6Gcls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777039692; c=relaxed/simple; bh=eqsoHMIOOabBLTi9Vt6IUu2GMKr3JRX0N3iuQ2xWg/Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iVnLLZJ83DqWIUdQ+vLQOFMgfMcz4XImcGn6pWwlTG8p5q1y4AStjT5W96Zy4GghPtCGSiDiUhapPA2pMt3fdBSwiexFjaJbSTURGCtzl5AOpm/RWmnYjrxx1Q61hZkP3uGNuMSDS5icBsJIAVf0Ma95EHq687UWgvbwQYV2WJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fxXR2Fm9; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fxXR2Fm9" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-82f8892d4d6so3479922b3a.0 for ; Fri, 24 Apr 2026 07:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777039690; x=1777644490; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=H8i0Gpepc+zFweLSIN4Cg/R5ifn3iGWjVwE5PfxJUKQ=; b=fxXR2Fm9GUuCDlkvZ98tIX4UJXqKIU0OM7457fN6WTnN91K8CevFZkUZCywzcAN/QX 7Hw1K+LSk/U5CWugbAjXXRnyqwjaRmhJFh4dmL1X2TPe0bcNalHnhioa5lcOOY3l5ze/ 3v/+P+Ejl+l9LZE2y+cAt/X18v3HxeKAtAOMXjP+i8dg1BJEIeFSDVTxMEXvuHJU7LQV Ms0bdLSIOPOimpoqPXuHk8iydvltF8Sq0hDq7/MIskvXbJNIYdEZ4da0cKBqmehtMU8H E1JqRBI1HQwwhi2fmz68tdBjsKMH6LXAGE5D1rkPdddQkdQP8XnM3kf6vHuEbTguU+5a e29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777039690; x=1777644490; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H8i0Gpepc+zFweLSIN4Cg/R5ifn3iGWjVwE5PfxJUKQ=; b=THV3H8bHCTyMzFEAsqz1Lyi3v24u4FGdeVb88wJdD7jQNqRM7bgqIF2ePsvE7dTgOH jfI+SeOl+IKi7Ebbdg49Autmaqud3GSGcyurSMTKGIqfjqekSzrF9k/FyXTCc69fBTm5 nd1NACaABTaVpGBFRaZIi9czzJZWKpWpU+X7+bPeEcoz4gFXL4CT/W01HS6JuQYdn3O1 fdsi9MxTkgQcYpz78LfeMzNMVsf189pF/Tkl5a69cGt9CGayBnQgabOBaZbC7uinon1o Z7hjA5qHPPs8Ndo73A+qN/tOAwWqDUGSq8Htg3FwUaG53LZU4R1xEwJ4Vj7XUGGHd4jc ALSA== X-Forwarded-Encrypted: i=1; AFNElJ/LCaFktHxmSVWrUSgtW024rAMpo94lqw1VIXL1vG8G5FeiWug5okcPqojsSAXvxE1HLPET7guDLv+IOkA=@vger.kernel.org X-Gm-Message-State: AOJu0YwgANUScamEc04Cbq/vOm0/OLZClwzqgWbtDZl97RgdFJOg/MI1 TdF72NQQsG17Zwgrmng+J9CCVKQWkydY2TaSEKSYfe4flcx8AHqwMhZm1zX9dgTIuQ== X-Gm-Gg: AeBDietBAJllm7TyPPp9hxhgmLzgg2yPvLuLe1YRRk83YepQPGka4i4Y9OMGOfETndI Zke/p8mBiK4x4yREerjqPTqipClpbDtGgWqr1FCkKX8LLwyhN65uEfF9UsCOrVK5Ya9NxOnL+13 nKR06wJb0J4zaQEIP8f0kBTVitxlyGr+GFeWL5ktpc+M2JyX4gguRQnNh9sV5ruRF4dSuixm6VT 6GANRx3rBLWEOE5RNpM5cy6jvefgka0eW9/UCPEZ4IrEojlqxnLIoUOKi0K2yjZL2320sgC7IwJ m/9FACFmvCliK5bEAFczlqYJO7cK64MPDdZaUuBb7PvrIRFlGK38VJQtT0i5mpYsQ/IHRm1+lNR RGWEeqLQWkmBJHbnWEAYlLAaDEIxouICujDIMvQPYg+OrrH9B00ebICizQmePN3EWwwYxS9X3Kx vL9H0OsPq99wge75bRj0nk8cW/h6RNp38haWxZkYiKuluczuPQGWHLALloV8QmIhh5JYhRxl4Q9 AwbuSoImQ/HLtM= X-Received: by 2002:a05:6a00:2d03:b0:82c:ebae:3cb with SMTP id d2e1a72fcca58-82f8c91924dmr33416449b3a.43.1777039690269; Fri, 24 Apr 2026 07:08:10 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9d9a1csm25404664b3a.20.2026.04.24.07.08.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 07:08:09 -0700 (PDT) From: Myeonghun Pak To: Benjamin Mugnier , Sylvain Petinot , Sakari Ailus , Mauro Carvalho Chehab Cc: Myeonghun Pak , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] media: i2c: vd56g3: Clean up subdev state on probe failure Date: Fri, 24 Apr 2026 23:07:41 +0900 Message-ID: <20260424140804.31568-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vd56g3_subdev_init() calls v4l2_subdev_init_finalize(), which allocates the subdev active state and requires v4l2_subdev_cleanup() to release it. If vd56g3_update_controls() fails after finalize succeeds, the probe error path currently skips v4l2_subdev_cleanup() and returns an error. The driver .remove() callback is not called after a failed probe, so the active state is leaked. Route this error through a subdev cleanup label before freeing the control handler and media entity. Fixes: 87aa97fc3157 ("media: i2c: Add driver for ST VD56G3 camera sensor") Cc: stable@vger.kernel.org Signed-off-by: Myeonghun Pak --- drivers/media/i2c/vd56g3.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/vd56g3.c b/drivers/media/i2c/vd56g3.c index 157acea9e2..43f792288a 100644 --- a/drivers/media/i2c/vd56g3.c +++ b/drivers/media/i2c/vd56g3.c @@ -1427,11 +1427,14 @@ static int vd56g3_subdev_init(struct vd56g3 *sensor) v4l2_subdev_unlock_state(state); if (ret) { dev_err(sensor->dev, "Controls update failed: %d\n", ret); - goto err_ctrls; + goto err_subdev; } return 0; +err_subdev: + v4l2_subdev_cleanup(&sensor->sd); + err_ctrls: v4l2_ctrl_handler_free(sensor->sd.ctrl_handler); -- 2.50.1