From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736493DC4C1 for ; Fri, 24 Apr 2026 14:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777041374; cv=none; b=bYATSDOastuhH9U45ylD1WCZcpIY0Kx341pUyozHB98ymYaPHMofeLnkoUvg2M1FrKQN4JrtqHxOWzqInF1ULK4OpD2gFA/odr2yg7ZgegjgUts+5/g5XFHZrjoAy+hckazW+EZgY3+zUwzgknCGDL5vYFGx8F3RkUF+HaPcBH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777041374; c=relaxed/simple; bh=qmCZG3NsgyNnx//Q3I0cBUENxgZbXGkZyQVfNZJYt74=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qbeatc6JUY+Gy1SXsJyd5vGliP0uyeZzFiLpaRsEwjiFISqBKuvUNvub/FScrnD2mF8a9Q9YAtNPE+Xb3JsZXUnkSMwrZdKZsojnbfbrRZzwUvYnNJuZorkjkdpyB/k8bzmENFMIYyyWWsBpDn2AylOyRV2nOBZu3p40jD9HFj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MkYEtM2a; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MkYEtM2a" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82f0884bcfaso5471081b3a.1 for ; Fri, 24 Apr 2026 07:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777041373; x=1777646173; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fiYSxmjQt4BB8G17wfMVpfBYmyS+agHfH0aiwr6Qa6U=; b=MkYEtM2a7gBK98Dj4C2Ll/4viZRU0UwZPO+3sc95EqY/8zE6cUrPDrec0oyb9eE6Ns M9cw+MWGy0xbtZxmgCJaVswojnnX8dOotv3NDEqNrNjKGTkrtRRWG7JZf/xCy55p7am0 8grjR6x06Blt8f6Q/zZ892nD07EuIlZHRObGQRYww2KIUHbnSHxCB5/sPNbmocUfSgqz kQkoFJ/II9vP5/cyXNY2kNT5CPfgMI0q26Vji9P58gRTYcnPMp6HlU6emUi40eUMHWp4 YuycsCRof3TH5PZzTrbVDSatS1WfbRajST7iGdIJm0MV1iMt9eucbUz7JDI3ZaacAl1Z 8TiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777041373; x=1777646173; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fiYSxmjQt4BB8G17wfMVpfBYmyS+agHfH0aiwr6Qa6U=; b=XQN284OAJgN7oY+jTPhK5ZxE6DHCW5Uf7u8rSFV2is+x0DlsE0bp9J8YA4tc/2ImU/ jKr1zYtRDNtTrV9MKkYyeOcTMLSeBYtpxPJSSO7HFCEt9J/KbLUYdHOBhqrEgBTK04Mt iWSo82MeYsmgHArLm7ERnOBr4g3aQnBwV4tDZUSFLkeroM/SOpIwIyYri+WqilfxqPoT FSM4+7gAYlGp4AK5kXJFsnQmVKyufmR/5Gg3jp0ZThhOe1+EzA48YDlGgOXQJ3TB/x8J 8SXaCJDzUJK/64X0s9sBvtLZY50cY0QZVqJu6IBB8Ny4Mz/tH216P0YGaXNj8hPdOVGX PIrg== X-Forwarded-Encrypted: i=1; AFNElJ88j4+1Ii+05cfghU8CzlN1wxG4E1QMQUDNgFatucji+c8J71sGg/UApDWvCNPLPmnB2pg8KrQQBBWtLes=@vger.kernel.org X-Gm-Message-State: AOJu0YzUWL+ZYpVmuj+eCfJ5+PBa3+/Gv9VmSZ6JzSn9B+Y4Rl1FH92R l/v/Tw3KOHIKXUd/c2ytUB15hdYasa59qp9qr+FIfcxrR9ovgI7mML8= X-Gm-Gg: AeBDievTk4clc+P8lgyrOpsdeIZUzc7nbe4orVezNnPA7FbA/M7/PQxVxflHqgYWUfO hUmNlV0qvmfR6HnVMRTjm0iGPsimAAHZLlMyTP6jZjbPNCDVHy2+GyjwF5DjieZUXLkTHZUFhWd ZCs9HT2BZuGI3lklQwAly0FFmquhzG6TcXWteE7NiVVqagitXMAwDS1/H48d/6ePVGR72SoWV/E 2rDqACWs4ph/IHZ67ghnSTXPW//Uib0RqMuIdVe/X8BW1gsjweFkBqzeNVh68wK+XWrOW/n8mdG BC9wm5P3ywCq1ePxaN8WiC0W7PSFVFznrHLAkMg3051rOScud/s5vI5xfPL51fvmI9dWSrvm/05 x4U2Vvw9Kss/Knp4MIvAhBel+noyz0s7+zu+L762rz2gBhPrnC7UWpguVTV8GfMrVuvLe9xzMk+ Bsqm6LOfS5b2/vb5ptUO28Qd0vCGxuS6G/z8dIT/8LRVSulApe6hBrRoFv5DXBOnrcD8cNTfRmj glvjD1uCg== X-Received: by 2002:a05:6a00:4fcc:b0:82f:5034:77a4 with SMTP id d2e1a72fcca58-82f8c8409b4mr34482294b3a.21.1777041372626; Fri, 24 Apr 2026 07:36:12 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9d35acsm24448401b3a.15.2026.04.24.07.36.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 07:36:12 -0700 (PDT) From: Myeonghun Pak To: Ettore Chimenti , Hans Verkuil , Mauro Carvalho Chehab Cc: Myeonghun Pak , linux-media@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: cec: seco: unregister adapter on IR probe failure Date: Fri, 24 Apr 2026 23:36:01 +0900 Message-ID: <20260424143607.60807-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If secocec_ir_probe() fails after cec_register_adapter() succeeds, probe returns an error and the driver remove callback is not called. The current unwind path unregisters the notifier and then falls through to cec_delete_adapter(), which violates the CEC adapter lifetime rules after a successful registration. Add a registered-adapter unwind path that unregisters the notifier and the adapter instead. Fixes: daef95769b3a ("media: seco-cec: add Consumer-IR support") Cc: stable@vger.kernel.org Signed-off-by: Myeonghun Pak --- drivers/media/cec/platform/seco/seco-cec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/cec/platform/seco/seco-cec.c b/drivers/media/cec/platform/seco/seco-cec.c index b7bb49f023..97ed9654c7 100644 --- a/drivers/media/cec/platform/seco/seco-cec.c +++ b/drivers/media/cec/platform/seco/seco-cec.c @@ -649,7 +649,7 @@ static int secocec_probe(struct platform_device *pdev) ret = secocec_ir_probe(secocec); if (ret) - goto err_notifier; + goto err_unregister_adapter; platform_set_drvdata(pdev, secocec); @@ -657,6 +657,10 @@ static int secocec_probe(struct platform_device *pdev) return ret; +err_unregister_adapter: + cec_notifier_cec_adap_unregister(secocec->notifier, secocec->cec_adap); + cec_unregister_adapter(secocec->cec_adap); + goto err; err_notifier: cec_notifier_cec_adap_unregister(secocec->notifier, secocec->cec_adap); err_delete_adapter: