From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C1DA363086 for ; Fri, 24 Apr 2026 16:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777046632; cv=none; b=ELZBpJ4fadf+uLxGFOjZCyWKH0YL0T97RRQj8PQCwKi6AptDuq2cqa+h1q8HJHXDjjJ/BB5Wj4xhG9M5SIMw5wwX+Jocu3Q5bOJcl/9ayvm+cDt24sDWkMZHyNi/fsyagdGDPN6CJ5Uo184t9BITYJnTY+hUOrPGmJJzU3h/k8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777046632; c=relaxed/simple; bh=mqneH79EzeFeOxrWkixTrTTzC47bHkuPKa7R4p811E0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XsumpzY7mB1u8FiPdQHkemW20nFz9mFY+eEyMUl/KMyu0p33Yjib3zhY5wCtgkViiUbR99wqz2Dj8oAaFocyfrBGGzrWVpBtrWH6VOUKAVGSXSmJwRGhk/wxFyXR7YsAEIBD1gZxpa7PtiLhyuwW5Pjn87ZAme3LweW7NoK1Eds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r+d0lrtA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r+d0lrtA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2AF9C4AF09; Fri, 24 Apr 2026 16:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777046632; bh=mqneH79EzeFeOxrWkixTrTTzC47bHkuPKa7R4p811E0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r+d0lrtAK3edmQEWczLVMByJvn0kIOzzMnds3YFkbiPrX1r3WRvzC8exTrN+1nJIF /PgMNBXy1lU5/HS6P53nIZyZv+dQoXvB/FAVAwBIZK401OuPCWowGf7i5NWRQVFTi3 dGegIUJsNmZOSofyzTkO286YEL2QUVjKQhRRld02seX2Z+MVupWjstk4IzZPUnD+UA c8OMJ8+3n9oXDmwTOm3EZ96Vr0MAYK2PfyJcfEtDv4ZHpu46msW/TOWCgCKKpaDxJv jcFJVELPANYwkLtKNwxUDdCVyC0+gxergtuoMzjBP7pUKe5RPAUTyjm2lvoEbphzJL fXEFjfnvLYQBA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGJ0P-0000000BDJh-3Lxr; Fri, 24 Apr 2026 18:03:49 +0200 From: Johan Hovold To: Geoff Levand , Madhavan Srinivasan , Michael Ellerman Cc: Nicholas Piggin , Christophe Leroy , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 3/3] powerpc/pseries: clean up ibmebus printks Date: Fri, 24 Apr 2026 18:02:59 +0200 Message-ID: <20260424160259.2672722-4-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424160259.2672722-1-johan@kernel.org> References: <20260424160259.2672722-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clean up the imbebus printks by switching to pr_warn() and pr_err(), adding a missing newline and making the error messages a bit more uniform. Signed-off-by: Johan Hovold --- arch/powerpc/platforms/pseries/ibmebus.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c index f2064e0b975d..24c3ec76b0c1 100644 --- a/arch/powerpc/platforms/pseries/ibmebus.c +++ b/arch/powerpc/platforms/pseries/ibmebus.c @@ -206,8 +206,7 @@ static int ibmebus_create_devices(const struct of_device_id *matches) ret = ibmebus_create_device(child); if (ret) { - printk(KERN_ERR "%s: failed to create device (%i)", - __func__, ret); + pr_err("%s: failed to create device: %d\n", __func__, ret); of_node_put(child); break; } @@ -285,8 +284,7 @@ static ssize_t probe_store(const struct bus_type *bus, const char *buf, size_t c ibmebus_match_path); if (dev) { put_device(dev); - printk(KERN_WARNING "%s: %s has already been probed\n", - __func__, path); + pr_warn("%s: %s has already been probed\n", __func__, path); rc = -EEXIST; goto out; } @@ -295,8 +293,7 @@ static ssize_t probe_store(const struct bus_type *bus, const char *buf, size_t c rc = ibmebus_create_device(dn); of_node_put(dn); } else { - printk(KERN_WARNING "%s: no such device node: %s\n", - __func__, path); + pr_warn("%s: no such device node: %s\n", __func__, path); rc = -ENODEV; } @@ -325,8 +322,7 @@ static ssize_t remove_store(const struct bus_type *bus, const char *buf, size_t kfree(path); return count; } else { - printk(KERN_WARNING "%s: %s not on the bus\n", - __func__, path); + pr_warn("%s: %s not on the bus\n", __func__, path); kfree(path); return -ENODEV; @@ -451,20 +447,18 @@ static int __init ibmebus_bus_init(void) struct device *root; int err; - printk(KERN_INFO "IBM eBus Device Driver\n"); + pr_info("IBM eBus Device Driver\n"); err = bus_register(&ibmebus_bus_type); if (err) { - printk(KERN_ERR "%s: failed to register IBM eBus.\n", - __func__); + pr_err("%s: failed to register IBM eBus\n", __func__); return err; } root = root_device_register("ibmebus"); if (IS_ERR(root)) { err = PTR_ERR(root); - printk(KERN_WARNING "%s: root_device_register returned %i\n", - __func__, err); + pr_err("%s: failed to register root device: %d\n", __func__, err); goto err_deregister_bus; } -- 2.53.0