From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA1B83E6DDA for ; Fri, 24 Apr 2026 16:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777049565; cv=none; b=Tw+lgGXHp6LO7DTYuwqKarbWsTfkBXjgyBQyZzWIEToJ4gfcF/yuVZwmUf4yISQ3u+gCIt294+st8/d3pGeyp5Qnh+t6xuHJIGC/vlw0l8bfAcVMuyTcTZpPf6q6XYrbEHF7+HLTaPEuTk3fywtN3elFuKRH5Z9uoj01OSzmtNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777049565; c=relaxed/simple; bh=gOq1TfW+S0UWD7Z2KXCott8iD54/eMJygLK8vcCtgp0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hw0ANVTzPzk//1gwbSHH3yu4hY9+/SWAnmXs/bW3Vtl2g4Fdcv1dLzbvclkrMhaSHpQTEiL42UxAbs+gyQMAUDR4kgFb6xZQYt7hZMoHGtaXCcJoAk6aC5uHEJGpCthmx8/n2ap7eFeBBduhmap+nCYU4swMF3TJDG+3HqRUz7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HcKRubrl; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HcKRubrl" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2b299b3c739so37722445ad.3 for ; Fri, 24 Apr 2026 09:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777049563; x=1777654363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N8m0d9jgffml56tOWD/yiI/9bSBwutf977iNuQiC6e8=; b=HcKRubrlSQ7PC7nzavVHXfghnZn1C/YbRWO8DaN/buFU0/PAZlWqoCPt4bwMxyGUO2 9iD/RZRQxp3RJHoOANXZwI59iWzuEiw+/BFnIszwjpIEMqyTdGk6OevIcJz89/4JfH2Q 9DBRXDbzlC9tJtYVlHy0bXsIRIn57vAwXy3OoJQZrdU8jtinjThtTbk5rFg22hNBE/3P SPJMWM5lcMxRn1TvFcxlLjlJksKlwVIi7gaQCeBrGqjoqtMzQICr/pH6EIFL6+MJ1zBh GM/jYOsjoYR2WxhOHZ3dJywHrupQAoW3GPCXlpSUg5xoJGt/LewTx5Dhh6uLAAkwkVQQ Sapg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777049563; x=1777654363; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N8m0d9jgffml56tOWD/yiI/9bSBwutf977iNuQiC6e8=; b=hWjgsoPQrRLaMV6I1QmqJGv4MN19DtCJWThhuaWDWYmwuTmE6PxuoBAy+ZoH83QAjC n0k1qJpWwSZz6eKnHwJGcm942EHLWABsf6eceDUiyihnRC8aXpl1/wmbpsY8bQQ4jLJN McKL6+EGWgFTrY5ncOFCgdhFA7vcSPB+0im0bIGbpcJWmRM8b6yb39mbo8EeMReWYaeu +CU0h+Ud6I59LRX1Y/mPCfC8+9RHaIXjUCTy3jSE05EHUBwgEZ8zO3suzBWNV/2tho4C I5GaUVuvPPw3pQ7B7+UbcCuu6lswOa3s5Wep0LoQa5Hu2Yu360mMZvpGdds5dlNOBsB9 HjQQ== X-Forwarded-Encrypted: i=1; AFNElJ973DjeP74T9U/nhhq1KGp1frRfkoCl4C1OXfWYQc6nVjGo9R0/ogFNuY+mVU/rMDUdneiUsdjtdJIvjoY=@vger.kernel.org X-Gm-Message-State: AOJu0YxMRRI3jH3DARDm6WLe3C1EIGckTsDZAvwuAfFYvEQ0uyflfiok 1+wNBT1uokjSrhDfND9CXthwYlgRHJ0Ilr4Z4Gst6qBDwrCfWyNY/ms= X-Gm-Gg: AeBDieumqRGEIT41tlbvm4bzMRlNQyVNqicmFrlXJwzuCC2L7Z35whnvSc7Z1Ti8ws4 opG2xaUZXV02e40rqZ0PI97dCnVTIiiLoX4q0lVkKrv4TnRagDsiu9o1BJJRcYuz5OHne13+ZX5 UPSdnI42KN9lPBmTEKDuEMeE+ZvJ08LiNUPQ9B5Pcyh4JapPhoUJXUPJZn9qxxjjfnPgBWn8fcl A7FdZmd/c26PiEs+fARafrwSTplcHoSDYTXZgzlM+kPP/606Djz8lBVF9PuvxiO/Z14SRFAr3x3 ZfVHsQ+/cOSFdSJRkXMmB7AEA42lA0F9rc9eAP3F/YcbPIYOPyFFEAs67HDRyTnrOeVYGo6zGh5 vOVqhn4RBNBR/Dz7+RySKa/a3KrY3gq6uTiDoLFawH0tZhcYa59Ex/NHL2PBd9NMUiVlFofzaYS 0qEgug2GV+2UZ8X/Y74CoQX5kAYI2/70icERTYsL6cdUw1ieNunR4Ya+DoIM1jnWv+ZcIIIjIL5 XsTDTSDgg== X-Received: by 2002:a17:902:f98e:b0:2b2:481b:de5f with SMTP id d9443c01a7336-2b5f9e86057mr239985835ad.5.1777049562978; Fri, 24 Apr 2026 09:52:42 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab30f29sm229362825ad.68.2026.04.24.09.52.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 09:52:42 -0700 (PDT) From: Myeonghun Pak To: Benjamin Mugnier , Sylvain Petinot , Sakari Ailus , Mauro Carvalho Chehab Cc: Myeonghun Pak , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] media: i2c: vd56g3: clean up subdev state on probe failure Date: Sat, 25 Apr 2026 01:52:10 +0900 Message-ID: <20260424165238.31333-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vd56g3_subdev_init() calls v4l2_subdev_init_finalize(), which allocates the subdev active state and requires v4l2_subdev_cleanup() to release it. If vd56g3_update_controls() fails after finalize succeeds, the probe error path currently skips v4l2_subdev_cleanup() and returns an error. The driver .remove() callback is not called after a failed probe, so the active state is leaked. Route this error through a subdev cleanup label before freeing the control handler and media entity. Fixes: 87aa97fc3157 ("media: i2c: Add driver for ST VD56G3 camera sensor") Cc: stable@vger.kernel.org Signed-off-by: Myeonghun Pak --- Changes in v2: - Use a lowercase subject summary. drivers/media/i2c/vd56g3.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/vd56g3.c b/drivers/media/i2c/vd56g3.c index 157acea9e2..43f792288a 100644 --- a/drivers/media/i2c/vd56g3.c +++ b/drivers/media/i2c/vd56g3.c @@ -1427,11 +1427,14 @@ static int vd56g3_subdev_init(struct vd56g3 *sensor) v4l2_subdev_unlock_state(state); if (ret) { dev_err(sensor->dev, "Controls update failed: %d\n", ret); - goto err_ctrls; + goto err_subdev; } return 0; +err_subdev: + v4l2_subdev_cleanup(&sensor->sd); + err_ctrls: v4l2_ctrl_handler_free(sensor->sd.ctrl_handler); -- 2.50.1