Re: [PATCH v2 2/6] iio: accel: mma8452: sort headers alphabetically

Andy Shevchenko
2026-04-23T07:47:59Z

On Thu, Apr 23, 2026 at 08:00:28AM +0530, Sanjay Chitroda wrote:
> On 23 April 2026 1:00:10 am IST, Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> >On Wed, Apr 22, 2026 at 10:26:39PM +0530, Sanjay Chitroda wrote:

...

> >For this driver the regulator/consumer is a regular header and can be moved
> >to be between property.h and types.h.

> Andy, Thank you for your review.
> Along with alphabetic sort, I have also grouped different header(s), at top
> linux direct header, then iio headers and at last regulator headers for
> readability.

The grouping of some subset of linux/* or other headers is done only for the
purpose of pointing out the strong relationship with the certain subsystem.
For example, driver of the regulator belongs to the regulator subsystem, and
grouping regulator headers (in case more than a single one in use) makes at
least some sense. This driver has nothing to do with the regulator subsystem,
it doesn't belong to it.

In the above I described just an example, the same applicable for any subsystem
and driver. I.o.w. use the common sense.

> If you suggest, I would include this in commit description.

Yes I do suggest to move it back to the generic linux/* group.

--
With Best Regards,
Andy Shevchenko