From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010021.outbound.protection.outlook.com [52.101.85.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C9703F54B7; Fri, 24 Apr 2026 18:32:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.21 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777055523; cv=fail; b=ABZElx9vvMnZw4joY7ufvyFh+O9k/IYVaVM314u8Gk0Q6Uo3Ytg7+HYpeEplPjLYphEhPAjcB2s8SSKVAEJOdwg9S/2UKvPXIMfWRyNeBOLLqNbWDgdsVFWNcQuTd1Sx8FXQYZ+EZZILnj8N3aQFi4srZwWrcixRc/1j7qdZpT0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777055523; c=relaxed/simple; bh=XyVLLG6AOc6z2sqEOWbSl7dztJGXwwTg2ZpEDE9lGgA=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=BqwMYo04UTWlWpmeVdfdN86gTylKJZoG8ZcAAPdyESJFz2D93LW+8m44r7aMXiA4fp2ZdatVyErntyqaRiey1Jw4hH8rngszajEaeWvyv4oukY5YEIa5J4HpcHo5ymo4CYyZG0XVmFVqQ5Cgz+KUrpB3wwQyStve/KrpaNL7ZC0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qYgyXtBy; arc=fail smtp.client-ip=52.101.85.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qYgyXtBy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uLv8EA+WrMKTrnC5FOq91QkIUvqFBd/SXCrZk/0ZBIIbr4qoU7oQWrOhhTwetNfIBnZqbE8EQFLmu7moe3aymR4dYZQUKbWLHcf3uV+cNmlyiPs11Tn4pX/bOMYY+Ncwa1yrlcbQge9ZwOUc3WTSxzGRrMwl4+Z0/BZAozYzr6IOaPj7k8QPHw/aQusGLRXUIPJB+Vgl64m1fdMyVvcGZ1vo7jnXIIFcfwHdYHyEhGYBhM9Poq6KfqsagchdJRb/dbyHkHtx5kLvHEKwvZFTlY+uprlaUCmaBeYSwX/K/BGRpYVyhmefNegxkbFkgG1l+EtYEkWZFkVj2scEYrxokw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r9MRAeLVFUMHgD6BzisL/E3Ccb0RUihrqxAQX+qRoZE=; b=wOSR2EY/D7oMbdwMPcn80Xgcdfzms9Bkc47NZKmFcBHubHhPA9P68ipgQvpm2AV1qDCvGL0Vbn9ahJk+U61dcasbf9ufeoplMCp0bdgPzNAQmg77cUQ7WQOPismxyAJ70t/mwAGl4PSl7kxZ3p4XQ7SAGdp5wxZpsc1GFC7PI0ONlG9Ta82nQOImA7JPl9YNomeZUOrS3fsxPhxZunEHXfMFCO+hge82KC77B0sLlmOC4V9xpkk8HBzPZgiF0q+OrVQU56BQLpIJ/yLB2X8mY43d0yVQoBL+L5pU/wwgPjeN/FYy2sUxiyFa+ENVunodPxg5AQ/QLBaLtUwGrycvTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r9MRAeLVFUMHgD6BzisL/E3Ccb0RUihrqxAQX+qRoZE=; b=qYgyXtBy0UXjZHR3yAncMB7a1iZ3jyHQ78KrBt6vjocf8SGfJgSK8ZFSwMH6UhHF1sF12/PBIeOBZ8sOuGnTn+i6fyQE1BK2m6XkrzcnbveTj8ZDeZHSGgW3l4mxW+GzsrAtTJq6996AgyH8AWKqZZqEjrtmyFOP0BciTnWH4E0H5gx73oJNMfOB44sITRVVkLcCYVtcUJaNRr0sQGAJ0Y81MlL/bh34C51qBRRbtluH07RhZon9pbqNGWePtKrJluNcM7QaOHn54tmGihDldPZjO9lzepkGpTpz7+9czXILM621v0WPPq4kM3c41sllzTb57UoIMIngAKgEMTROOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by BL3PR12MB6476.namprd12.prod.outlook.com (2603:10b6:208:3bc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.21; Fri, 24 Apr 2026 18:31:55 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9846.019; Fri, 24 Apr 2026 18:31:54 +0000 Date: Fri, 24 Apr 2026 15:31:53 -0300 From: Jason Gunthorpe To: Matt Evans Cc: Alex Williamson , Leon Romanovsky , Alex Mastro , Christian =?utf-8?B?S8O2bmln?= , Mahmoud Adam , David Matlack , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Sumit Semwal , Kevin Tian , Ankit Agrawal , Pranjal Shrivastava , Alistair Popple , Vivek Kasireddy , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, kvm@vger.kernel.org Subject: Re: [PATCH 9/9] vfio/pci: Add mmap() attributes to DMABUF feature Message-ID: <20260424183153.GJ3444440@nvidia.com> References: <20260416131815.2729131-1-mattev@meta.com> <20260416131815.2729131-10-mattev@meta.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260416131815.2729131-10-mattev@meta.com> X-ClientProxiedBy: YT4PR01CA0359.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:fc::23) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|BL3PR12MB6476:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ad76bd2-2963-4c86-c812-08dea22fc286 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: xcCc6LDo9D+P43AEj92B6NahyqPeamQhg2XVZ7bmYIhSqRGXGD3S4TJRNN+sD15vtruNixkVyHrtHQKTASwQY6u0r+wKDjtmYajKHVWmP7me3n8SGI7LhbwHAMacE6Te3kv1mCA0OZoBejRHIjRpQ1WtNmW+tN1KMonby+0+9PmwjzfCdfQlJVZdy/OwFjlpYCBHZaFBc8C3+iA3LBzvi+hhwOlgXMkVELvVZDnrwUFp24/HCALe1T4UcnBYlM8ofCSd7mqZ0yZKzhleNAuuUl8Xy6eiqiNAuqNCMA/iiSZCQEVY3P/wekThwLrNlM6t2eOWmh5wjMEL0fqY/k4ALHk14PhC3stQx7a+j18ALUhvTTEabO9y3aqGa1TBpbwMeTrGcpw39N1F0+JcV2FXXUsGWUZIF9cw+5lNvWek3QPHpJSFgFZSjtC8bsquNwBeQbEyEJJaM6IYLpbJWr97XH3QP7rb541sbvL/IBHrjLuIWFARS9dRP+uZzy2BvWjfBvNsuSjCZrvCzkqrZDcR2HnGSr+HPHfsbu5/87KAYGYuq3mggbr8MtRKJo/QX6l23bOfPQsJG3alFrNOQcjAW1/w8yZeavtwXNR+mF9qM1qmKWVkUlH6lb2CaR94DBa4UeQZBh/DjyYnGqpmUdtUhoCC5nUftUOgyiW+2Cy/wQ67Qub4EqJCqVJ35NrTlSj3Sc0CXsEBrQ+M8Wgr9miNRR7zR+9xlijzmlZvpGj00UY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KJauQdAp0eUfpHUbrJtMlcbMSbCCY3ZhoTA89jEblu1QM0URJxMoNTm4TsH9?= =?us-ascii?Q?0IC6zkbfZlZajjaSkhKnhj47u8qHMlx+KTzqajzj/pWoXTxadKSwXdqs3ZKe?= =?us-ascii?Q?P10QsVpvnnp7KLTHPisI2T5maugpkQDjSmzaijDtypFGPd/lw12DGqRXSUje?= =?us-ascii?Q?vDD2L1lRypi065fS2AGHSY6mQs+LRI/GToiMYzgv+vderDGRipErFVYDKz7A?= =?us-ascii?Q?s7FrMSKdk0RT+m/U3c7dQ+v6hUiDmOvVxrelrAnfO0gNZkpCW/qRmG8aJzNe?= =?us-ascii?Q?8nMpDVeF1eyXcTvcLrnE2lC09/VlKMBONFD/BdakkNz5Vr8AK+7fIL9/qEhx?= =?us-ascii?Q?e25CYfrZHp7C1j9DyxMyhN3oPezlmX1/8noRRpBWD7adzQh+PucP6OQxWmaD?= =?us-ascii?Q?PPRG9TjQuPamec7Bc3VbaGttjQPI6UP3xu+6a2UaT/7G63d2VFoLWQQ1pwDO?= =?us-ascii?Q?sukkhB4hc4kCBvpWVcqKD83aLVVGDibc+XXJIBzqOMlvh9u9k3dA+Y4grVWG?= =?us-ascii?Q?yxhHisPl1C35cNIzUYdcINbJklGK7yXxVVu0dTI2UItfFvNEGc0+zlzJUsnj?= =?us-ascii?Q?rwL2HheQqg+XRNPA6k5HbNcmGeIIlk1ZUz/eor9bh2KpuVoieFsZ6hOVjRmY?= =?us-ascii?Q?9Yzl4QyfWt+cJzw3CP1Hy7XnBOrGVoHfa2b6j0wjZItUlOV6+oVrNJbLKizg?= =?us-ascii?Q?4VG2096nR29GeseXMsuvcJKc8pTXEk3isW2Yf3X/Nh1ZaDmB6woI4ugR8eEh?= =?us-ascii?Q?5LXx0r8FN3LMhnWYVOJcFaxXwUcmW5W+tVEraeROux89RA6jAJRN5qz/k4YF?= =?us-ascii?Q?165iXpq7zanI9EqT6x/4LnZm8NEUDYEqWy680NphVTNVT9eBPXotGYY/cz9A?= =?us-ascii?Q?LSJtbkWlUJ+vcEa4X2uxZ5BRfohTIzphtNNqTbqToVtSr+YhXkYmOwe2ShE/?= =?us-ascii?Q?lA1LyE1G3M3M32cmUo3BRvxUqCDKxWC47H3oHoRoduiQidFrh3DLuKFm318e?= =?us-ascii?Q?wAV09jJRT8ZNYoU60BIa3FGbxDrr8bjzTxFgK1jEUGKSup6yUqSu908Avuzq?= =?us-ascii?Q?AhdXb7TO2dEkrfFRMy9ccpr15Lw26CpQNNPmE8PBzPPzSylzwv7+8+My9CPW?= =?us-ascii?Q?oMFkIKGQB8oHY+vo6TR9kNCJsUplnVOSKGjwlRRhaMiWGpeZvtGC8SEg/SKk?= =?us-ascii?Q?ohtW5UGfrjdvjSXSzbZeI7AkUN84v+r1qWdP6fpKhX2q6pc32wqvE7TxDMYq?= =?us-ascii?Q?laQ8k4m9W28Dn24OqB8oN8GuLRws9nUqXoSPyGV+gawaxXnuEnTBcApWNaTE?= =?us-ascii?Q?X/Rci5WbdqVzJIiJaicjBeAb9g1x6HrCRfsid0wxCzWE/gevZE6+c2mcp7lb?= =?us-ascii?Q?VGukxHq9NrOGKR+cGF3337hYxMllprWbls17Vi1P2QRA3htk5fpkJVSigRav?= =?us-ascii?Q?OvUPM6mrkL56xe+Fnb0XXhAES5S439AhUgqAfSKb8dd0P9lX3BaHojnrf7QK?= =?us-ascii?Q?wnLEpK/LBd39lwk4/t3zbykpmCPg57Sax+jpZKMDTRXYxjEsMImCUJ9pURC2?= =?us-ascii?Q?zul0y7qLmYJeXAyoTvmh5DFQGWvX52jSMz3ECA3HY8flNdvTa6qWNe43LMk3?= =?us-ascii?Q?+uMEacEsFeVe7lJVldH/+lruUie1xpxFtvsJb51ZQeiwf3Di41EhZ4O5uIV3?= =?us-ascii?Q?vsIOCKzNc2lb9CoV4I1oz8CV+RnHO8++GFHMSrWp8ZAbL81S?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ad76bd2-2963-4c86-c812-08dea22fc286 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2026 18:31:54.6330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0b3otYlj65BJiMiO4XrGW/gxlufC22/CkXeGj42hxuMwy08Vy2PoxVhSp3lDexFc X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6476 On Thu, Apr 16, 2026 at 06:17:52AM -0700, Matt Evans wrote: > A new field is reserved in vfio_device_feature_dma_buf.flags to > request CPU-facing memory type attributes for mmap()s of the buffer. > Add a flag VFIO_DEVICE_FEATURE_DMA_BUF_ATTR_WC, which results in WC > PTEs for the DMABUF's BAR region. > > Signed-off-by: Matt Evans > --- > drivers/vfio/pci/vfio_pci_dmabuf.c | 15 +++++++++++++-- > drivers/vfio/pci/vfio_pci_priv.h | 1 + > include/uapi/linux/vfio.h | 12 +++++++++--- > 3 files changed, 23 insertions(+), 5 deletions(-) Nice and simple Reviewed-by: Jason Gunthorpe > @@ -1549,8 +1551,12 @@ struct vfio_region_dma_range { > struct vfio_device_feature_dma_buf { > __u32 region_index; > __u32 open_flags; > - __u32 flags; > - __u32 nr_ranges; > + __u32 flags; > + /* Flags sub-field reserved for attribute enum */ > +#define VFIO_DEVICE_FEATURE_DMA_BUF_ATTR_MASK (0xfU << 28) > +#define VFIO_DEVICE_FEATURE_DMA_BUF_ATTR_UC (0 << 28) > +#define VFIO_DEVICE_FEATURE_DMA_BUF_ATTR_WC (1 << 28) > + __u32 nr_ranges; Though why did the diff format like this, is there some whitespace changes? All this did is insert defines it didn't change the members Jason