From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1E4C1CAA78 for ; Sat, 25 Apr 2026 00:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777076699; cv=none; b=dt3oGtDSbl6IL3XM0TRMQYc/yXZBtYX3/Ps5RmIe3Dyx8+D9KfVWGOG6U+nLuZgjF2/YsKazUtt0Z5skjo58IXgexAMqwcTUGiQdlvD8Gf28+BkU97/tVpD7HXHhdxFsk+XaPD0LUsyCDn+3B1OFGne+OOrxxGLh8IIEXX5cnXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777076699; c=relaxed/simple; bh=yekA/fLC52CZh9ofH4e0iJWuXm6tLedi58HlqbuGCuE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UT9ywlbcS/j2T/ZOQ+h9V6XMXhseowc3Rr2CBXHxNR2DDGXMlR3Uwr6Gwui8cF5PlyEAHuAj8ozFwQ18D9QYvxNnnndp7O5dH9s5rstxYq2LV3CilFpZhfyKRH7WyXBBJOGiPEKLZ/fJylg7HJAH5mODGBQakBxBkaCix4NPrc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YEPkCYZq; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YEPkCYZq" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2b4678c6171so83089575ad.1 for ; Fri, 24 Apr 2026 17:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777076698; x=1777681498; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4wiJYfQEx2I1gNyVCcAbOWCRuneaP+oLGnQ3LZHljgU=; b=YEPkCYZq31Up7koIQC+qwbubEd2KlrTvE8x8ow1BYsqgVnXM2SCxJ/1o7A5VFbBoFx GKUJGfh5ZnYSSpdW7rZEc6T87wDL5h6VQ77Alrr7yxFes7Qk01tQOmnrwufxoH5Ugzcy eu440yPJ58ZINEBDRNB1+g8QooqilJwLNXM6SB9YXdwgOZ1JXSFOjtZRZ+/yaEz9aYAa Kv1jyzLskLpSARJQsLGDqvEWRI6A1SZ0J0zmxPPfxSAH3Nbh6HaHBmFPo+ZVc+nZQJ38 Zp5e1mxEGF0rfZ0jyIKihj2NkcBk3AZfO9/oivuOQ9BKXWM0HAdGlRwGsVGFUtyvZMOS o3YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777076698; x=1777681498; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4wiJYfQEx2I1gNyVCcAbOWCRuneaP+oLGnQ3LZHljgU=; b=lfCFJ5++cVMJCcGekvWLIuhAdfuQvDI9GenV3gWA+tVI6gm8/OfCNbAZNibTlWJFkD 13KpKH4ndKBt4brC+nTXBpuammfMtS3wuwSELclvs3MWFnDVIX00wBS8UTFE0EsnR+gH 0kkLlMuzqs0RBui8mHKBRuIW9S9JCCyr2lypzK+x8l4ytoMZtxMZYuGaqLZoZ9yDrtBm V5L4YPI7mz3NAW1jEdRVzlGBDO//TRPt1cdQIM4MdFFaIWBj3lAbhsXsFHwciJFUiAvU fiSu+1grdaebC4CCGHqvR2iKefS5c1glLo34zJLrl2z5YNa+eTwjeb0NC64NsSjax6Op K+lA== X-Forwarded-Encrypted: i=1; AFNElJ8DWZSj/FcbaYvkaX6tKv08OCvD0VLIb0KSKFgcG7JiW6ctuu7IJNu0Y+KCUSaOQS6CoJeGNrFAMhjyw3Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yys4WebBjVyJD1j/NXBsHnhmnndyqv4y9FrHEACAnY0XE0MV+lq npq72ZeTPKP+6Zb+ksg6OLT1NAndxLSP+jKjR7lgPM7vkqC3T3M5FvWJZqX9oFlf1EKHv6J2TLc aYlvs5nPkJ/wM32H/M+oGdadFhA== X-Received: from plsa9.prod.google.com ([2002:a17:902:b589:b0:2b2:5616:36aa]) (user=hramamurthy job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1aac:b0:2b2:4d36:7ba with SMTP id d9443c01a7336-2b5f9d69075mr306727115ad.0.1777076697866; Fri, 24 Apr 2026 17:24:57 -0700 (PDT) Date: Sat, 25 Apr 2026 00:24:48 +0000 In-Reply-To: <20260425002450.163421-1-hramamurthy@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260425002450.163421-1-hramamurthy@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260425002450.163421-3-hramamurthy@google.com> Subject: [PATCH net v2 2/4] gve: Fix backward stats when interface goes down or configuration is adjusted From: Harshitha Ramamurthy To: netdev@vger.kernel.org Cc: joshwash@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, willemb@google.com, maolson@google.com, nktgrg@google.com, jfraker@google.com, ziweixiao@google.com, jacob.e.keller@intel.com, pkaligineedi@google.com, shailend@google.com, jordanrhee@google.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Debarghya Kundu , Pin-yen Lin Content-Type: text/plain; charset="UTF-8" From: Debarghya Kundu gve_get_base_stats() sets all the stats to 0, so the stats go backwards when interface goes down or configuration is adjusted. Fix this by persisting baseline stats across interface down. Cc: stable@vger.kernel.org Fixes: 2e5e0932dff5 ("gve: add support for basic queue stats") Signed-off-by: Debarghya Kundu Co-developed-by: Pin-yen Lin Signed-off-by: Pin-yen Lin Signed-off-by: Harshitha Ramamurthy --- Changes in v2: - Add a NULL pointer check in gve_get_ring_err_stats() (Sashiko) - Use local variable to prevent inflates from u64_stats_fetch_retry() (Sashiko) - Add u64_stats_fetch/begin to protect base stats (Sashiko) drivers/net/ethernet/google/gve/gve.h | 7 ++ drivers/net/ethernet/google/gve/gve_main.c | 88 ++++++++++++++++++++-- 2 files changed, 88 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h index 1d66d3834f7e..702b1641d984 100644 --- a/drivers/net/ethernet/google/gve/gve.h +++ b/drivers/net/ethernet/google/gve/gve.h @@ -794,6 +794,10 @@ struct gve_ptp { struct gve_priv *priv; }; +struct gve_ring_err_stats { + u64 rx_alloc_fails; +}; + struct gve_priv { struct net_device *dev; struct gve_tx_ring *tx; /* array of tx_cfg.num_queues */ @@ -883,6 +887,9 @@ struct gve_priv { unsigned long service_task_flags; unsigned long state_flags; + struct gve_ring_err_stats base_ring_err_stats; + struct rtnl_link_stats64 base_net_stats; + struct u64_stats_sync base_statss; /* sync stats for 32bit archs */ struct gve_stats_report *stats_report; u64 stats_report_len; dma_addr_t stats_report_bus; /* dma address for the stats report */ diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c index ef00d9ca1643..1fec8e1e4821 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c @@ -106,9 +106,34 @@ static netdev_tx_t gve_start_xmit(struct sk_buff *skb, struct net_device *dev) return gve_tx_dqo(skb, dev); } -static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s) +static void gve_add_base_stats(struct gve_priv *priv, + struct rtnl_link_stats64 *s) +{ + struct rtnl_link_stats64 *base_stats = &priv->base_net_stats; + unsigned int start; + u64 rx_packets, rx_bytes, rx_dropped, tx_packets, tx_bytes, tx_dropped; + + do { + start = u64_stats_fetch_begin(&priv->base_statss); + rx_packets = base_stats->rx_packets; + rx_bytes = base_stats->rx_bytes; + rx_dropped = base_stats->rx_dropped; + tx_packets = base_stats->tx_packets; + tx_bytes = base_stats->tx_bytes; + tx_dropped = base_stats->tx_dropped; + } while (u64_stats_fetch_retry(&priv->base_statss, start)); + + s->rx_packets += rx_packets; + s->rx_bytes += rx_bytes; + s->rx_dropped += rx_dropped; + s->tx_packets += tx_packets; + s->tx_bytes += tx_bytes; + s->tx_dropped += tx_dropped; +} + +static void gve_get_ring_stats(struct gve_priv *priv, + struct rtnl_link_stats64 *s) { - struct gve_priv *priv = netdev_priv(dev); unsigned int start; u64 packets, bytes; int num_tx_queues; @@ -143,6 +168,14 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s) } } +static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s) +{ + struct gve_priv *priv = netdev_priv(dev); + + gve_get_ring_stats(priv, s); + gve_add_base_stats(priv, s); +} + static int gve_alloc_flow_rule_caches(struct gve_priv *priv) { struct gve_flow_rules_cache *flow_rules_cache = &priv->flow_rules_cache; @@ -1533,6 +1566,29 @@ static int gve_queues_stop(struct gve_priv *priv) return gve_reset_recovery(priv, false); } +static void gve_get_ring_err_stats(struct gve_priv *priv, + struct gve_ring_err_stats *err_stats) +{ + int ring; + + if (!priv->rx) + return; + + for (ring = 0; ring < priv->rx_cfg.num_queues; ring++) { + struct gve_rx_ring *rx = &priv->rx[ring]; + unsigned int start; + u64 rx_alloc_fails; + + do { + start = u64_stats_fetch_begin(&rx->statss); + rx_alloc_fails = rx->rx_skb_alloc_fail + + rx->rx_buf_alloc_fail; + } while (u64_stats_fetch_retry(&rx->statss, start)); + + err_stats->rx_alloc_fails += rx_alloc_fails; + } +} + static int gve_close(struct net_device *dev) { struct gve_priv *priv = netdev_priv(dev); @@ -1542,6 +1598,12 @@ static int gve_close(struct net_device *dev) if (err) return err; + /* Save ring queue and err stats before closing the interface */ + u64_stats_update_begin(&priv->base_statss); + gve_get_ring_stats(priv, &priv->base_net_stats); + gve_get_ring_err_stats(priv, &priv->base_ring_err_stats); + u64_stats_update_end(&priv->base_statss); + gve_queues_mem_remove(priv); return 0; } @@ -2784,12 +2846,24 @@ static void gve_get_base_stats(struct net_device *dev, struct netdev_queue_stats_rx *rx, struct netdev_queue_stats_tx *tx) { - rx->packets = 0; - rx->bytes = 0; - rx->alloc_fail = 0; + const struct gve_ring_err_stats *base_err_stats; + const struct rtnl_link_stats64 *base_stats; + struct gve_priv *priv; + unsigned int start; - tx->packets = 0; - tx->bytes = 0; + priv = netdev_priv(dev); + base_stats = &priv->base_net_stats; + base_err_stats = &priv->base_ring_err_stats; + + do { + start = u64_stats_fetch_begin(&priv->base_statss); + rx->packets = base_stats->rx_packets; + rx->bytes = base_stats->rx_bytes; + rx->alloc_fail = base_err_stats->rx_alloc_fails; + + tx->packets = base_stats->tx_packets; + tx->bytes = base_stats->tx_bytes; + } while (u64_stats_fetch_retry(&priv->base_statss, start)); } static const struct netdev_stat_ops gve_stat_ops = { -- 2.54.0.545.g6539524ca2-goog