From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CCC627453 for ; Sat, 25 Apr 2026 01:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777080640; cv=none; b=rmT32Db4Pi/xmIj5eb/1AkbLN/2CfJ03Jety4Xrxc1tAEqTZAjDjVnNRVvd2jmVOBp+iwFGt/c6xZRikH1iizbQmXcMGn5F4zBhITlZwYNIlgYSjf2gG+23/fNvuQ+iiGjoqJsrtlPNZ2jt0SL6TXeshfe4sqHgbX+Bg6mz5yFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777080640; c=relaxed/simple; bh=1Li1v/z4AI1HDPIQlMFbgqUBJzJ0+NGYWz+n+mOwMjY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RdzWH4rlKaRKhk/B/cbnrChxSOB7hntZLAe9uaNcknukd20C7qYYRdPaU0OeJuWPY8prErawAVcyTnGsiloOyZypjxP/M+klvH6B94nAi5UDpdYgZdPuq2OfurB7pctw735I3AUywfS641vEOZP69cG4aotqUhDy4O15IhCAKtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pYwAQ8SO; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pYwAQ8SO" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82f431c0ab6so3938245b3a.0 for ; Fri, 24 Apr 2026 18:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777080638; x=1777685438; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e+G3DrkqN/4PurMQeEE3NidJZYF70aW0MCaMm3xLhHk=; b=pYwAQ8SOcM2boppmDB8N14cQSuP97pA2r2dZCR2OWPQ5Nux3F70Wm1B9InY7ubBld5 avh1Vv+BZksIz6CK/mu9pV0IeNkoLSl69kqdr/u+hbOKYBjF+5m5Q9wcmGdXwMnH9/YJ Wk7O1Os2e33DSCPxkVv/ARr7br1JEC/JUNsdx0r0B8FlyW9TkGyMQoruqtElWKz5EYKK ixLcfVAnXpUQKmUhk5hu/iE5gamQTi9YvwGJYcGQqKvO4TG8BKYmKQySYbaNJYwD382/ SsKueFgd6QcGgga0/qQ3aPnbKuvvfrE19dF2iIrLVMz6tZ7EvlAztJmoRuurAxT7LbUv R9zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777080638; x=1777685438; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e+G3DrkqN/4PurMQeEE3NidJZYF70aW0MCaMm3xLhHk=; b=HQRezrguzdtJQoYTcz3dwegpaLsSVw3yZn4ZHc8zJOsweUPPpFCIEzfoO+fVZXTkrt NBO7AqNMVP9Tn4qhNwMurNGht5bGDQ4BIX3G6UwafNOT6R5Q2CobZ8wN2zSmTLtnnrS5 aAQoawcfucJpvGDzzfQEcnYHedIJTbVIoET9jkRV8dKZJcW5C6olgllAl3YlZaK69r1g A00505vUe/HPcvZslI2bnUS+KkSyKbqVDjSrrH0AyItHcol/ZAeWCKjkznl+4uYSrRSb PZtW42mK1wlhez9Lqkc0pX4z74O30pHhbsq1dGqe57t5mZ+8yV1/fj5MhXCHUVA2Paeg ydHQ== X-Forwarded-Encrypted: i=1; AFNElJ9tCrwFcA26PaURF57gP/2KKS0PU579hjpnZ2tbJ7EZhNMRB/6zHueJyH4aZZlETFOq/g7/KBDj6BypbT8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/nBykOJjDzErYWcEkZ8Y5B41nfXK4WQLtvTesH8ukvv9xJSX4 ujWM5Dbs7UTfrj48lCYMdt6akRZIcXehWUOtSnO5FjQI4gSzAoV/CrBliNRd5Q== X-Gm-Gg: AeBDiet/EKWSUL2+wmo+wfPVws4OCu91y6AcQk/0/Aa9nvVCvXHGBZiwAfQdmJ/unSZ Y/lK1seGp7Zs2kiDxfWfD8GdOoz8igjI+syF1SguMNo5mngvKtmPThnfgW5pXsXxYd+JvRLHfvf SYioPUaZt+UwEWWS7Kqc5hV3qHRPSPhNIOBXxelLnksr8sAEl0z+Ru+lemwgSUD0FHspdTR8jO4 EE9GxEmc26zYSZD8Og3RZukx/CV3ArkzNbFFpjw4ErbknKIrMId/juR/u/IWleDrOLbWc4MZd2G DqrkmFP9KOhnuX7lk1aVFDRwyrX74Fv4wxu6nGGXpaWJ7yyzMm2rALuGC86gQxU04Ua1fLt9eIx E5Tpv7GfsgTM5W36RzAwrsKVEB2g5rOXkZEPBhd1OFrA0lq4Q+Oe59LGpgkBCmT2QOKjHqt9Pl3 fJY+DHhtFdGcWx6VqHQXjPt1d6PwBB4qewEVOy1biyv0wMS/xIUbiFqLWyDW2ccvWZFfNTVFgci IwTjcI5H7Gb2nbT+sKMCr+64Q== X-Received: by 2002:a05:6a00:a90:b0:827:433c:ba7e with SMTP id d2e1a72fcca58-82f8c970703mr35175890b3a.41.1777080638313; Fri, 24 Apr 2026 18:30:38 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d::8bd]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e981d00sm24353027b3a.5.2026.04.24.18.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 18:30:37 -0700 (PDT) From: Rosen Penev To: linux-sound@vger.kernel.org Cc: Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ALSA: ctxfi: simplify mixer allocation Date: Fri, 24 Apr 2026 18:30:20 -0700 Message-ID: <20260425013020.430496-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Combine 3 allocations into one to simplify memory management. No need for 3 separate frees now. Replace void pointers with proper types. No need for void here. Signed-off-by: Rosen Penev --- sound/pci/ctxfi/ctmixer.c | 27 +++++---------------------- sound/pci/ctxfi/ctmixer.h | 4 ++-- 2 files changed, 7 insertions(+), 24 deletions(-) diff --git a/sound/pci/ctxfi/ctmixer.c b/sound/pci/ctxfi/ctmixer.c index e3ee76bd8482..50ab69aca2fa 100644 --- a/sound/pci/ctxfi/ctmixer.c +++ b/sound/pci/ctxfi/ctmixer.c @@ -965,35 +965,20 @@ static int ct_mixer_get_resources(struct ct_mixer *mixer) static int ct_mixer_get_mem(struct ct_mixer **rmixer) { struct ct_mixer *mixer; - int err; + size_t alloc_size; *rmixer = NULL; /* Allocate mem for mixer obj */ - mixer = kzalloc_obj(*mixer); + alloc_size = struct_size(mixer, amixers, NUM_CT_AMIXERS * CHN_NUM); + alloc_size += sizeof(*mixer->sums) * NUM_CT_SUMS * CHN_NUM; + mixer = kzalloc(alloc_size, GFP_KERNEL); if (!mixer) return -ENOMEM; - mixer->amixers = kcalloc(NUM_CT_AMIXERS * CHN_NUM, sizeof(void *), - GFP_KERNEL); - if (!mixer->amixers) { - err = -ENOMEM; - goto error1; - } - mixer->sums = kcalloc(NUM_CT_SUMS * CHN_NUM, sizeof(void *), - GFP_KERNEL); - if (!mixer->sums) { - err = -ENOMEM; - goto error2; - } + mixer->sums = (struct sum **)(mixer->amixers + (NUM_CT_AMIXERS * CHN_NUM)); *rmixer = mixer; return 0; - -error2: - kfree(mixer->amixers); -error1: - kfree(mixer); - return err; } static int ct_mixer_topology_build(struct ct_mixer *mixer) @@ -1228,8 +1213,6 @@ int ct_mixer_destroy(struct ct_mixer *mixer) } /* Release mem assigned to mixer object */ - kfree(mixer->sums); - kfree(mixer->amixers); kfree(mixer); return 0; diff --git a/sound/pci/ctxfi/ctmixer.h b/sound/pci/ctxfi/ctmixer.h index e812f6c93b41..dd23d227aeb5 100644 --- a/sound/pci/ctxfi/ctmixer.h +++ b/sound/pci/ctxfi/ctmixer.h @@ -41,8 +41,7 @@ enum MIXER_PORT_T { struct ct_mixer { struct ct_atc *atc; - void **amixers; /* amixer resources for volume control */ - void **sums; /* sum resources for signal collection */ + struct sum **sums; /* sum resources for signal collection */ unsigned int switch_state; /* A bit-map to indicate state of switches */ int (*get_output_ports)(struct ct_mixer *mixer, enum MIXER_PORT_T type, @@ -55,6 +54,7 @@ struct ct_mixer { #ifdef CONFIG_PM_SLEEP int (*resume)(struct ct_mixer *mixer); #endif + struct amixer *amixers[]; /* amixer resources for volume control */ }; int ct_alsa_mix_create(struct ct_atc *atc, -- 2.54.0