Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error

Neil Armstrong
2026-04-27T07:43:08Z

On 4/25/26 07:39, Christian Van wrote:
> mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable()
> currently ignores it and always reports success.
>
> Return the DCS command result so callers can observe enable failures.
>
> Signed-off-by: Christian Van <cvan20191@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> index 4f8d6d8c0..dbdb7e3cb 100644
> --- a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> @@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel)
> /* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */
> msleep(200);
>
> - mipi_dsi_dcs_set_display_on(ctx->dsi);
> -
> - return 0;
> + return mipi_dsi_dcs_set_display_on(ctx->dsi);
> }
>
> static int feiyang_disable(struct drm_panel *panel)

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil