From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C26E2DB7B7 for ; Sat, 25 Apr 2026 09:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109432; cv=none; b=NtkXeL4osLQKZWG3BJVCIB8tF4fZmf9kIG5L3eHgAqC5K9GArZUkfyTFEfGSkdrWnazuBifpTKHNZXr+UE7jWt/iIbZp+6UYeLxf40iqXQzDa2ykJnKl/7yJGMR9aS3o5GycIElfHJ2VAUUijV8PcEb1noowTbcrnd6Ot95CbrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109432; c=relaxed/simple; bh=N9ijW3AsBy/p+PwIdQE2e41ehaiY4fwBhwF0z5uyDWk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RDRaoQEwTss9yrdTwJxD3lSVL1MuWoO90jGsoy29VBs07KtKs67UAzscq8HVSFF1X3F9O/BXCtTBZtChNi87pa9Pr5AbM+VAkGgNmKJHwd6i5Zs2C7b8te/Fj+f8lTlyzouZyWg1wu1UGXBSlfr8wSWb9AKNh9vFIrwq8C44H0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fuWsAWxP; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fuWsAWxP" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43cfd832155so6339853f8f.1 for ; Sat, 25 Apr 2026 02:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777109428; x=1777714228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xyL6eQDTOa83HsK8N08HXtdZVDzA0HoYcQ2NsR08O3Q=; b=fuWsAWxPkUdjkzeiJ+pBcluWKajhMmK/d4loORNHDQ9r6NHUCuzOfVthwCYYErxWgK S6cSYUUFSFBulw9BnswZ5A1IG3LlkKGUuEqqKdmJevs3f+VtspJ1izJ1tZ3ZTaJCE4nl DT5zL7+v1W4KcksmIiXEVvFti2VdkuTm5mkVp0NsvHqATNio1wiPFBG2InkrUKeoivS+ DJSr2vvMtKYdWBjYoXLdG9sxGstPXq8M9wC9sRlg1fDGMd5yXkQRSJGxMUljD1+Jg1fY ANyqEABVleHZdYybIfgL2h6fUNScop51w7yme/3c07oKtt7NQtXxE589bs+QW4NGlU0M R4qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777109428; x=1777714228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xyL6eQDTOa83HsK8N08HXtdZVDzA0HoYcQ2NsR08O3Q=; b=NziH0yU9yBqHI13yjaPTA+NVtV2Sfwja1FlKBm+X4e158wE9pH0xJ96+RUshNR2lwc UIf68I9RYzeOXYp6QyOvrw5zfwyrpLPx91ruzqatYPc1vqxJ6vVcfzjjhv/a8gzvTCRm AeWFDQaJ6wAkD8Av21IHGdrgUf2Ug/+70vQrlkhcktHJ97l6dzSeQZcIKshqFZs5MF1i KgE7/m3oiZhdsS2Ga1MIO4YEK76yZ2iILgf7RX3t9CuaMWtC3cFAVRSpInYqG3xfQWRJ eoEAZee6XvwnGcI2ZoVjAaLYMErm81RLKWa5Ceefxih/f0i93OxMlzVrpn90i9OFpfef 1wQA== X-Forwarded-Encrypted: i=1; AFNElJ85D9mtMPTKYy7TzrPrJS5WOywCRf4FKqDYPg4x2cnybLBLWSzHWT9dhA8tbDwtZ8NakowhKx8of/B/j8E=@vger.kernel.org X-Gm-Message-State: AOJu0YwriwsFSQZaqNdMNDHno/FBsKJC/c4WqY8p8wbzg/4U7H91Wt8n NDyx9FFHIlJCPJVUfaP4MoN4LeShcAD6uda2E2x9L5Q7G/kC1nxQTYfF X-Gm-Gg: AeBDieuHypGx0wF5bIh+rCO3SZ3xr5dkJR3xkkmvGzS2cO4wf8FDBJTJlksICB+6eHM +21I1IBD2PcUirNFUVTxOeuLK0z67DP91nsO2UtCoc46QOdjHDAJ87E5K1LirjMelzDNUbAUkWN M559LGauGQEq/ooclUXiRlI83dpwODUrcWWKXr7YSqxCn009rFnw/VXx8sMOzyL61O0/0IdHM2q hufpY9ZI/vKHIBQiGrdu5vsMz7mFZjMFAf8f97zJr0XEJSSje4llmeQ2+3qhf7nNLY7AGzQsMMK E7Cgbkx6LzfYfVMcnNYEKdIxsmEvONaML/9cW0qavVAkfXyAAhntEe6sAoYj+SCCjVjNXhO3pIK Hx1XwLNT/npXI7+MsbJl5X9oWmMjfE0ZEyQnT68KbTLD6m3bo5GzWv3W16g0nr1HQiMMiNjE3iA oy/ltqVnbQdFiD56pO6tfNu/epymnDl4ilp3zIouYQSGkk+/ZSWN2Zsj2POM2P0dNTDYSmJcSJD Tv1 X-Received: by 2002:a05:600c:468f:b0:489:1cd2:610a with SMTP id 5b1f17b1804b1-4891cd2624fmr339312755e9.9.1777109427813; Sat, 25 Apr 2026 02:30:27 -0700 (PDT) Received: from localhost.localdomain (ns31537009.ip-141-94-163.eu. [141.94.163.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7b2716sm204422615e9.30.2026.04.25.02.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 02:30:26 -0700 (PDT) From: John Madieu To: broonie@kernel.org, heiko@sntech.de Cc: jon.lin@rock-chips.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, John Madieu Subject: [PATCH 3/3] spi: rockchip: Drop dead zero-check on fifo_len Date: Sat, 25 Apr 2026 09:29:36 +0000 Message-Id: <20260425092936.2590132-4-john.madieu@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260425092936.2590132-1-john.madieu@gmail.com> References: <20260425092936.2590132-1-john.madieu@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rs->fifo_len is assigned from get_fifo_len(), which returns 64 for the two known SPI controller versions and 32 for everything else - never 0. The subsequent if (!rs->fifo_len) return dev_err_probe(...); is therefore unreachable. Drop the check. If unknown controller versions ever need to fail probe explicitly, that should be expressed in get_fifo_len() itself, not through an impossible post-condition. Signed-off-by: John Madieu --- drivers/spi/spi-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 231fbcf0e7aa..1bd48376498a 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -824,8 +824,6 @@ static int rockchip_spi_probe(struct platform_device *pdev) } rs->fifo_len = get_fifo_len(rs); - if (!rs->fifo_len) - return dev_err_probe(&pdev->dev, -EINVAL, "Failed to get fifo length\n"); pm_runtime_set_autosuspend_delay(&pdev->dev, ROCKCHIP_AUTOSUSPEND_TIMEOUT); pm_runtime_use_autosuspend(&pdev->dev); -- 2.25.1