From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09E72391517 for ; Sat, 25 Apr 2026 10:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777114578; cv=none; b=Efd0+PDxjBpgL9gNlF9eoRX36JfhPY6kGnSAtOj0Pnb6lxW0vDbEhkvyZs5O+SvH9OEIrEu47vjO4oRCWVKMG9eMtswG5y8mf67Scwvxtca7FoD2VX65tnrbRsFU9x/jzAkVoXkl6sPAKHxyKfDNL0TpJBe2DYfDBCOrt1LmDuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777114578; c=relaxed/simple; bh=0DFMRmRmnT3HIcrBDMAr1tbxa08F3uNrVtX65Evd/tg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aMeeSVvT9xDOJ3lK8U0Ga+V8Wmf7kkblnhwRohAnyKOuBkBkZrgbook/UZXxz7EIcQywIkmHtTT5/rMXpKRsurl92E8uiKtz2KQHajCzo4qRU0LE7BmATmf1TIQz6Aojf38tbldESY9EOhsBslJsW9us3HnEwipOtoc1CTPRlWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pBKHsWUU; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pBKHsWUU" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2b2d3a9e149so45853195ad.1 for ; Sat, 25 Apr 2026 03:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777114576; x=1777719376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s6Yo5rERlGwlb3Ci6vxCe4GRUzMyoCAKAgtEtNiZmzs=; b=pBKHsWUUQFqC4Jr2gMSQdSUOJyg57E/uvYIZTTf+HL8H5SieX2Fpn8kKEUpNwDasfF bJKz2FZ+XeLhXw7J22Hj60BkEhN2/QgcQ3fhDuie68MfQDq7n7A36v4OrjnqY1fRbIfO EvwCHmZSzRA0orFpglAahu2qb3iHjq3aOmbg8dhFokereqIHNdktTlPxlLY7Sw6uXEuw GI8ZRg9q8S96g9TLHCmwcGglupPTiXSaDSRzlA629oNdPLvLL4WLayY10BuJByh691qe DLmT63b0oOwKT+EWHGw1sX4N4qXvawPac8fqK0eHmNtEtWvZgCNfCjK9hEjINOcrtChV OXxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777114576; x=1777719376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=s6Yo5rERlGwlb3Ci6vxCe4GRUzMyoCAKAgtEtNiZmzs=; b=XIg1i6hxX8ikNdBvzTgYysbPCGmZtwFp0f9dRcWr8e9KfGuCXwhmMrLLQutXgApSn1 0x2/j2CjwKETUWqgAYx+PP6cg+N/1Duq2XXZkFV67HrBFgJCs2yHoz2R/7nMwbzAd6yr ox/ip0UxlvaWEY3Z8ZZ+uocO27NptV4mK3ZmKqcDqRDwa8nPi7nMAg9YJdZqAqcIsQus SPOKVVuvAZX9JwgFynCoN4ibRA7TIDX2nttehuoEVocSvVcmSrKc5+XyHO2I39Al92N5 4xM8niZ2g6KWksyy0nk0mI2hDCkM0PTWO3FecopwcFTUA1UjpccjbugnalcX7wiCaspz szWQ== X-Forwarded-Encrypted: i=1; AFNElJ9J7ihyC3jNKMwzuYi3jMSgb0MdIWWLWUwcIzaKfGNAsN70iWqvx4eLQWqdSB3DARyRe5TBOE75YrNr2jQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwTvuRxoXI5Z76kd0Uag41EDke9jEUV12yDco3nN+Op2tTfFvTy snXN5QZrqb3FaGsx7X1gMqhXSJAJ9crPc57uTSSQX1lWVCbV5Xw5kqYT X-Gm-Gg: AeBDietRuthYoFT5wVvMUG1BCK8vo/iev0alLAdjgxp5XYS83ABrpKmZ6VMyY2JImxJ 9uDGxQsoHeKy8N+fb9/oOuKBQwyMg6jHPZrXiiR1djah42Ezr1ngnDQzOZX4nUtzRw3Y2QeDyA3 iWAy8i10a5Y5PMCIjKf0oH9ee//Gq5OXPSYfnV9xo5htegUYrOJ+2p0BJINnFUpRaO5aWYzMYTE mc+4Fb2wbQhye/GL07x6EU6f359QfYjTh/p4T7FMM+NwQESVo9nJOzr5bY8xxIjKWshkqQex+qZ DuVFryjuryNAxFGKj0OQnfSKcRsEbuPI6qnEOTok8BpdQEYQiq5QlZ49OFUNv2kqsApXU2er7DJ amm7AdbwuYxp9S1d9KLvHZHztI6q79e1R5lyC6by3r4ICLMKmykU6H6RCNZ1dw6AW+CTs5onurz nENxn4EQzjhHaKOK3poXz+KvutwpX0 X-Received: by 2002:a17:903:11c3:b0:2ae:5346:d4e6 with SMTP id d9443c01a7336-2b5f9ef78e0mr323118295ad.28.1777114576428; Sat, 25 Apr 2026 03:56:16 -0700 (PDT) Received: from nuvole ([144.202.86.13]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa33486sm303832345ad.33.2026.04.25.03.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 03:56:15 -0700 (PDT) From: Pengyu Luo To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Martin Kepplinger-Novakovic , Sakari Ailus , Mauro Carvalho Chehab , Hans Verkuil , Martin Kepplinger Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Pengyu Luo Subject: [PATCH 1/4] media: hi846: fix hi846_write_reg_16 handling Date: Sat, 25 Apr 2026 18:52:57 +0800 Message-ID: <20260425105300.745044-2-mitltlatltl@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260425105300.745044-1-mitltlatltl@gmail.com> References: <20260425105300.745044-1-mitltlatltl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hi846_write_reg_16() does not clear a positive *err value on success. pm_runtime_get_if_in_use() returns a positive value when the device is already in use. When hi846_set_ctrl() passes &ret holding this positive value) to hi846_write_reg_16(), the function returns with ret as is, the positive value propagates back as a return code, which callers interpret as an error. Fix this by resetting *err to 0 only when it is positive. Fixes: 04fc06f6dc15 ("media: hi846: fix usage of pm_runtime_get_if_in_use()") Signed-off-by: Pengyu Luo --- drivers/media/i2c/hi846.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c index a3f77b8434ca..09c109f3fba9 100644 --- a/drivers/media/i2c/hi846.c +++ b/drivers/media/i2c/hi846.c @@ -1270,6 +1270,8 @@ static void hi846_write_reg_16(struct hi846 *hi846, u16 reg, u16 val, int *err) if (*err < 0) return; + else + *err = 0; put_unaligned_be16(reg, buf); put_unaligned_be16(val, buf + 2); -- 2.54.0