From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7BA7175A7D for ; Sat, 25 Apr 2026 11:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777114961; cv=none; b=gAzbFhZnFw4b/ApWgfBitmDDyP5NeX6Cw6/2+8TfNTxoQJ1cC/2SOOI0sPlVXps+KgbLYaTLgw1UXqkZAQeYlyj7uoHjxY31VGZJOHJKnzZx5YWI3Tf2o9E9CIjzoKbUmI0i0jBHWv9Dk0sn6hbG1T5fQaBPXCHigzNefs3tLrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777114961; c=relaxed/simple; bh=0Hl10w3oRmON33yMhRyufkLV9NZ+ydMT1q3LCnmE5nI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kz6quqPFoR1Iy3iYoxy/k4QtK/SKzNIm8EPc37nGO9Z+R0ifS1K9jzJL4JTcMYMO1CE6luAx/x6h6A6uJY9igIIVSJYZk4XlSgkAJJCuEwFGoByyLUzONS8Lx51UFCMmptOZtdi58ABZ+RChX4/WCgaT7ZHZIo915FB/b4Lr/NY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OHSxUDCv; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OHSxUDCv" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso86448815e9.1 for ; Sat, 25 Apr 2026 04:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777114958; x=1777719758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=krEC5W4u3Zy98qJoM/+vZPkJBJL5qw1cHHHERcq1ubA=; b=OHSxUDCvZ+gQMXs1YhXZbN1B7B2fvk5rJAotUytKyfo88p/k3L/DoOA7tONqrbh3OB KhAcnj1Apq7wmkFgcXRKfz13uE/FwrkcMborqmq9NSr9EpyNiHXHQr9Fc0Smfstma6u4 2h7iGB+D4EaZR3lpyv9PTlEFbvFDogEA9YcpQaz6VpJSEGZhJX7/tbZ7jf1vQDrSShBV CoaBYxnJymcljIbwUQRxHB0R1PCwzMUukitwEuBVTGEdhOe/Rj0WRcmFrBNl/ONxXPV5 +S1lo0boaJenWRLz0pDnvfBIzI+KpcD9iZiYFpHWp9DVMRU5U3/g56AT0l7Cn/xkliOG 0SeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777114958; x=1777719758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=krEC5W4u3Zy98qJoM/+vZPkJBJL5qw1cHHHERcq1ubA=; b=CLnH2TpMPW937HtAsNf401YVouSljEXylhglJLeMMfctoZ2WStw7vu8Rcagp+rBhGm UgX4EIX29PgT9OVsrQll9c27qkReYI2n/BzlNzpDXyVyrroD2c6JT6rPIlmQZbW2kr40 l1nPPRgXQ8mnPOhxKi2FAfD8A8Rniz5GiZnku6IS0/4qrO5pgaAdnOFtRlU7/0RgGbud 8Y7ui6wysOZK+KvzVu1nAkmHI5ZMTWq1eG/ABnMxrBZ2G1I591grQiPIlbzPn354raLj PX0+4adcsq8DGDgPhUtXH7XL65ceI7mx8z/jCFIaldXS3SNEi/zCBGz/9R8WGkoB+Sq9 ZRNA== X-Forwarded-Encrypted: i=1; AFNElJ+gqBWv4aSCjloPSHhuNvFadGj8w1t4bGDyigAEsLu6fffYLHvQzMhLyjSUkUlOdnq0wnNmjsAppoucd20=@vger.kernel.org X-Gm-Message-State: AOJu0YyJu80M8Fdi6ALvJGw0aUvXC9UAOeLEWwYPC/97hakfUqiDzpZr gbzNlqY8tbTsqNAlQR0CV9EzyhhVeUTKYcabJbkrk0sBLv8Dzq2/O+x3 X-Gm-Gg: AeBDievvuD/p9Cy6nEKyjqmumlVPPByuCcyOCFfbAGz2S1o4RxUACB2xMHioOcudxX4 SL3sJ20oUGfVxPIUbDPXATHJLMuDAjBdqHunaYI7bCLZjFGgS4HVYMpN9lBMuUZRmtA0NYagDa/ ZSBOkn9cQLdCyMPd5ArerNn2nZzaLKeXND4Am5eRAHGa2bashCywdYNRCnyZhCKMVj0xCg6K3oJ VVOWu7EZAmOGQC+QXly7BPVEe4EfPcmieXYEOlvAgDCLMvH+Qv99GWfvf+7qsCtMOcrXGn81vMX p52lxCq1O2Y44hZ1ddZ12RKht9r2/3Drsbpis7Kw4RFHwiZqpcdrI8lMl9NsQcIsFUnRad/EixN dueEq1LqTcsFn2dwjM9UCOYf7ECd+ej3P2jAjbJ0qlmnN553vKf10h6evukDw3pLt4lLD8/si50 rUK8CEAWOrGvkY6i86oSRqUp+n2DZDp+YBRV5uQgrwod8hkHzyBCmItrMqVWpLQShUapu0D50/D TE8jmhDDVemFg== X-Received: by 2002:a05:600c:b96:b0:48a:5339:a46 with SMTP id 5b1f17b1804b1-48a53390f6cmr295415295e9.9.1777114957837; Sat, 25 Apr 2026 04:02:37 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb77b001sm312125075e9.3.2026.04.25.04.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 04:02:37 -0700 (PDT) Date: Sat, 25 Apr 2026 12:02:35 +0100 From: David Laight To: Helge Deller Cc: Ai Chao , nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, linux@armlinux.org.uk, dilinger@queued.net, adaplas@gmail.com, James.Bottomley@HansenPartnership.com, FlorianSchandinat@gmx.de, alchark@gmail.com, krzk@kernel.org, kees@kernel.org, rene@exactco.de, tzimmermann@suse.de, rongqianfeng@vivo.com, thorsten.blum@linux.dev, chelsyratnawat2001@gmail.com, soci@c64.rulez.org, gregkh@linuxfoundation.org, daniel@thingy.jp, linmq006@gmail.com, fourier.thomas@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-parisc@vger.kernel.org Subject: Re: [PATCH 03/35] fbdev: sisfb: Use safer strscpy() instead of strcpy() Message-ID: <20260425120235.2ec10089@pumpkin> In-Reply-To: References: <20260425065926.1091168-1-aichao@kylinos.cn> <20260425065926.1091168-4-aichao@kylinos.cn> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 25 Apr 2026 10:08:08 +0200 Helge Deller wrote: > Hello Ai, ... > > - strcpy(ivideo->myid, "SiS 730"); > > + strscpy(ivideo->myid, "SiS 730"); > > The compiler knows at build time the length of myid, and the "SIS 730" string. > Using strscpy() has no benefit here either. Contrary, the code generated > because of using strscpy() is probably even larger. > Don't replace such code with strscpy(). Both should get converted to a memcpy(). If you increase the literal to be too long I'm pretty sure you'll get a compiler warning/error from strcpy(). OTOH strscpy() is more likely to truncate the string (I'd need to check). So leaving it as strcpy() is fine - and possibly even better. The header files might get changed to error strcpy() unless the compiler knows the source string has a constant length and the destination is big enough - but that hasn't been done yet. David